michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: serial: bouffalolab: UART_INT_CLEAR is write-only

Browse source 
Fix incorrect read being made to "write 1 to clear" register UART_INT_CLEAR

Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
This commit is contained in:
Benjamin Cabé 2025-06-09 17:14:19 +02:00 • committed by Dan Kalowsky
commit b33e28d233
1 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
drivers/serial/uart_bflb.c
View file

@ -90,28 +90,30 @@ static int uart_bflb_err_check(const struct device *dev)
{ {
const struct bflb_config *const cfg = dev->config; const struct bflb_config *const cfg = dev->config;
uint32_t status = BL_RD_REG(cfg->reg, UART_INT_STS); uint32_t status = BL_RD_REG(cfg->reg, UART_INT_STS);
uint32_t tmp = BL_RD_REG(cfg->reg, UART_INT_CLEAR); uint32_t clear_mask = 0;
int errors = 0; int errors = 0;
if (status & BIT(UART_INT_RX_FER)) { if (status & BIT(UART_INT_RX_FER)) {
tmp |= BIT(UART_INT_RX_FER); clear_mask |= BIT(UART_INT_RX_FER);
errors |= UART_ERROR_OVERRUN; errors |= UART_ERROR_OVERRUN;
} }
if (status & BIT(UART_INT_TX_FER)) { if (status & BIT(UART_INT_TX_FER)) {
tmp |= BIT(UART_INT_TX_FER); clear_mask |= BIT(UART_INT_TX_FER);
errors |= UART_ERROR_OVERRUN; errors |= UART_ERROR_OVERRUN;
} }
if (status & BIT(UART_INT_PCE)) { if (status & BIT(UART_INT_PCE)) {
tmp |= BIT(UART_INT_PCE); clear_mask |= BIT(UART_INT_PCE);
errors |= UART_ERROR_PARITY; errors |= UART_ERROR_PARITY;
} }
BL_WR_REG(cfg->reg, UART_INT_CLEAR, tmp); if (clear_mask != 0) {
BL_WR_REG(cfg->reg, UART_INT_CLEAR, clear_mask);
}
return errors; return errors;
} }