michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: i2c: Remove invalid syscalls

Browse source 
i2c_slave_register/unregister must not be syscalls since it provides
callbacks that will run in supervisor mode. Nonetheless, verification
functions were missing which means that these functions never worked
from usermode.

Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
This commit is contained in:
Flavio Ceolin 2020-03-11 11:23:12 -07:00 • committed by Andrew Boie
commit b0b320b7dd
1 changed files with 4 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

14
include/drivers/i2c.h
View file

@ -275,11 +275,8 @@ static inline int z_impl_i2c_transfer(struct device *dev,
* @retval -EIO General input / output error. * @retval -EIO General input / output error.
* @retval -ENOTSUP If slave mode is not supported * @retval -ENOTSUP If slave mode is not supported
*/ */
__syscall int i2c_slave_register(struct device *dev, static inline int i2c_slave_register(struct device *dev,
struct i2c_slave_config *cfg); struct i2c_slave_config *cfg)
static inline int z_impl_i2c_slave_register(struct device *dev,
struct i2c_slave_config *cfg)
{ {
const struct i2c_driver_api *api = const struct i2c_driver_api *api =
(const struct i2c_driver_api *)dev->driver_api; (const struct i2c_driver_api *)dev->driver_api;
@ -306,11 +303,8 @@ static inline int z_impl_i2c_slave_register(struct device *dev,
* @retval -EINVAL If parameters are invalid * @retval -EINVAL If parameters are invalid
* @retval -ENOTSUP If slave mode is not supported * @retval -ENOTSUP If slave mode is not supported
*/ */
__syscall int i2c_slave_unregister(struct device *dev, static inline int i2c_slave_unregister(struct device *dev,
struct i2c_slave_config *cfg); struct i2c_slave_config *cfg)
static inline int z_impl_i2c_slave_unregister(struct device *dev,
struct i2c_slave_config *cfg)
{ {
const struct i2c_driver_api *api = const struct i2c_driver_api *api =
(const struct i2c_driver_api *)dev->driver_api; (const struct i2c_driver_api *)dev->driver_api;