michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: sensor: iis2mdc: Store sensor trigger as a pointer

Browse source 
Fixes the iis2mdc sensor driver to store the user-supplied sensor
trigger as a pointer rather than a copy. This enables the trigger
handler to use CONTAINER_OF to retrieve a context pointer when the
trigger is embedded in a larger struct.

Signed-off-by: Maureen Helm <maureen.helm@intel.com>
This commit is contained in:
Maureen Helm 2023-03-08 15:51:41 -06:00 • committed by Carles Cufí
commit b079316b4e
2 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
drivers/sensor/iis2mdc/iis2mdc.h
View file

@ -59,6 +59,7 @@ struct iis2mdc_data {
struct gpio_callback gpio_cb;
sensor_trigger_handler_t handler_drdy;
const struct sensor_trigger *trig_drdy;
#if defined(CONFIG_IIS2MDC_TRIGGER_OWN_THREAD)
K_KERNEL_STACK_MEMBER(thread_stack, CONFIG_IIS2MDC_THREAD_STACK_SIZE);

6
drivers/sensor/iis2mdc/iis2mdc_trigger.c
View file

@ -36,6 +36,7 @@ int iis2mdc_trigger_set(const struct device *dev,
if (trig->chan == SENSOR_CHAN_MAGN_XYZ) {
iis2mdc->handler_drdy = handler;
iis2mdc->trig_drdy = trig;
if (handler) {
/* fetch raw data sample: re-trigger lost interrupt */
iis2mdc_magnetic_raw_get(iis2mdc->ctx, raw);
@ -54,12 +55,9 @@ static void iis2mdc_handle_interrupt(const struct device *dev)
{
struct iis2mdc_data *iis2mdc = dev->data;
const struct iis2mdc_dev_config *const config = dev->config;
struct sensor_trigger drdy_trigger = {
.type = SENSOR_TRIG_DATA_READY,
};
if (iis2mdc->handler_drdy != NULL) {
iis2mdc->handler_drdy(dev, &drdy_trigger);
iis2mdc->handler_drdy(dev, iis2mdc->trig_drdy);
}
gpio_pin_interrupt_configure_dt(&config->gpio_drdy,