michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Bluetooth: BAP: Fix issue with setting invalid iso data path

Browse source 
BAP would always set up the ISO data path in both directions,
even for unidirectional CIS. This meant that in the
unconfigured direction, the data path configuration data
would all be 0, which causes issues on some controllers.

The new refactored approach implemented by this commit
will always ensure that the data path is setup correctly,
and that we only set the data path in one direction for
unidirectional CIS. The unset path will use the default
ISO path of HCI and transparant format, which should always
be allowed by a controller.

This is building on the requirement in BAP that all streams in
a unicast group shall be QoS configured at the same time. This
ensures that before any streams in the CIG has been connected,
they have all been configured.

Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
This commit is contained in:
Emil Gydesen 2024-01-19 13:13:08 +01:00 • committed by Carles Cufí
commit aef39f6923
8 changed files with 46 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

6
subsys/bluetooth/audio/ascs.c
View file

@ -1929,11 +1929,7 @@ static void ase_qos(struct bt_ascs_ase *ase, uint8_t cig_id, uint8_t cis_id,
* we have the ISO <-> EP coupling completed (due to setting
* the CIS ID in the QoS procedure).
*/
if (ep->dir == BT_AUDIO_DIR_SINK) {
bt_audio_codec_cfg_to_iso_path(&ep->iso->rx.path, stream->codec_cfg);
} else {
bt_audio_codec_cfg_to_iso_path(&ep->iso->tx.path, stream->codec_cfg);
}
bt_bap_iso_configure_data_path(ep, stream->codec_cfg);
ep->cig_id = cig_id;
ep->cis_id = cis_id;

2
subsys/bluetooth/audio/bap_broadcast_sink.c
View file

@ -892,7 +892,7 @@ static int bt_bap_broadcast_sink_setup_stream(struct bt_bap_broadcast_sink *sink
bt_bap_iso_bind_ep(iso, ep);
bt_audio_codec_qos_to_iso_qos(iso->chan.qos->rx, &sink->codec_qos);
bt_audio_codec_cfg_to_iso_path(iso->chan.qos->rx->path, codec_cfg);
bt_bap_iso_configure_data_path(ep, codec_cfg);
bt_bap_iso_unref(iso);

4
subsys/bluetooth/audio/bap_broadcast_source.c
View file

@ -294,7 +294,7 @@ static int broadcast_source_setup_stream(uint8_t index, struct bt_bap_stream *st
bt_bap_iso_bind_ep(iso, ep);
bt_audio_codec_qos_to_iso_qos(iso->chan.qos->tx, qos);
bt_audio_codec_cfg_to_iso_path(iso->chan.qos->tx->path, codec_cfg);
bt_bap_iso_configure_data_path(ep, codec_cfg);
#if defined(CONFIG_BT_ISO_TEST_PARAMS)
iso->chan.qos->num_subevents = qos->num_subevents;
#endif /* CONFIG_BT_ISO_TEST_PARAMS */
@ -884,7 +884,7 @@ int bt_bap_broadcast_source_reconfig(struct bt_bap_broadcast_source *source,
iso_qos = stream->ep->iso->chan.qos->tx;
bt_bap_stream_attach(NULL, stream, stream->ep, codec_cfg);
bt_audio_codec_cfg_to_iso_path(iso_qos->path, codec_cfg);
bt_bap_iso_configure_data_path(stream->ep, codec_cfg);
}
}

48
subsys/bluetooth/audio/bap_iso.c
View file

@ -129,19 +129,12 @@ void bt_bap_iso_init(struct bt_bap_iso *iso, struct bt_iso_chan_ops *ops)
iso->chan.ops = ops;
iso->chan.qos = &iso->qos;
/* Setup points for both Tx and Rx
/* Setup the QoS for both Tx and Rx
* This is due to the limitation in the ISO API where pointers like
* the `qos->tx` shall be initialized before the CIS is connected if
* ever want to use it for TX, and ditto for RX. They cannot be
* initialized after the CIS has been connected
* the `qos->tx` shall be initialized before the CIS is created
*/
iso->chan.qos->rx = &iso->rx.qos;
iso->chan.qos->rx->path = &iso->rx.path;
iso->chan.qos->rx->path->cc = iso->rx.cc;
iso->chan.qos->tx = &iso->tx.qos;
iso->chan.qos->tx->path = &iso->tx.path;
iso->chan.qos->tx->path->cc = iso->tx.cc;
}
static struct bt_bap_iso_dir *bap_iso_get_iso_dir(bool unicast_client, struct bt_bap_iso *iso,
@ -164,6 +157,43 @@ static struct bt_bap_iso_dir *bap_iso_get_iso_dir(bool unicast_client, struct bt
}
}
void bt_bap_iso_configure_data_path(struct bt_bap_ep *ep, struct bt_audio_codec_cfg *codec_cfg)
{
struct bt_bap_iso *bap_iso = ep->iso;
struct bt_iso_chan_qos *qos = bap_iso->chan.qos;
const bool is_unicast_client =
IS_ENABLED(CONFIG_BT_BAP_UNICAST_CLIENT) && bt_bap_ep_is_unicast_client(ep);
struct bt_bap_iso_dir *iso_dir = bap_iso_get_iso_dir(is_unicast_client, bap_iso, ep->dir);
struct bt_iso_chan_path *path = &iso_dir->path;
/* Setup the data path objects */
if (iso_dir == &bap_iso->rx) {
qos->rx->path = path;
} else {
qos->tx->path = path;
}
/* Configure the data path to either use the controller for transcoding, or set the path to
* be transparant to indicate that the transcoding happens somewhere else
*/
path->pid = codec_cfg->path_id;
if (codec_cfg->ctlr_transcode) {
path->format = codec_cfg->id;
path->cid = codec_cfg->cid;
path->vid = codec_cfg->vid;
path->delay = 0;
path->cc_len = codec_cfg->data_len;
path->cc = codec_cfg->data;
} else {
path->format = BT_HCI_CODING_FORMAT_TRANSPARENT;
path->cid = 0;
path->vid = 0;
path->delay = 0;
path->cc_len = 0;
path->cc = NULL;
}
}
static bool is_unicast_client_ep(struct bt_bap_ep *ep)
{
return IS_ENABLED(CONFIG_BT_BAP_UNICAST_CLIENT) && bt_bap_ep_is_unicast_client(ep);

1
subsys/bluetooth/audio/bap_iso.h
View file

@ -41,6 +41,7 @@ void bt_bap_iso_foreach(bt_bap_iso_func_t func, void *user_data);
struct bt_bap_iso *bt_bap_iso_find(bt_bap_iso_func_t func, void *user_data);
void bt_bap_iso_init(struct bt_bap_iso *iso, struct bt_iso_chan_ops *ops);
void bt_bap_iso_bind_ep(struct bt_bap_iso *iso, struct bt_bap_ep *ep);
void bt_bap_iso_configure_data_path(struct bt_bap_ep *ep, struct bt_audio_codec_cfg *codec_cfg);
void bt_bap_iso_unbind_ep(struct bt_bap_iso *iso, struct bt_bap_ep *ep);
struct bt_bap_ep *bt_bap_iso_get_ep(bool unicast_client, struct bt_bap_iso *iso,
enum bt_audio_dir dir);

22
subsys/bluetooth/audio/bap_stream.c
View file

@ -31,28 +31,6 @@
LOG_MODULE_REGISTER(bt_bap_stream, CONFIG_BT_BAP_STREAM_LOG_LEVEL);
void bt_audio_codec_cfg_to_iso_path(struct bt_iso_chan_path *path,
struct bt_audio_codec_cfg *codec_cfg)
{
path->pid = codec_cfg->path_id;
if (codec_cfg->ctlr_transcode) {
path->format = codec_cfg->id;
path->cid = codec_cfg->cid;
path->vid = codec_cfg->vid;
path->delay = 0;
path->cc_len = codec_cfg->data_len;
path->cc = codec_cfg->data;
} else {
path->format = BT_HCI_CODING_FORMAT_TRANSPARENT;
path->cid = 0;
path->vid = 0;
path->delay = 0;
path->cc_len = 0;
path->cc = NULL;
}
}
#if defined(CONFIG_BT_BAP_UNICAST_CLIENT) || defined(CONFIG_BT_BAP_BROADCAST_SOURCE) || \
defined(CONFIG_BT_BAP_BROADCAST_SINK)
void bt_audio_codec_qos_to_iso_qos(struct bt_iso_chan_io_qos *io,

2
subsys/bluetooth/audio/bap_stream.h
View file

@ -17,8 +17,6 @@ void bt_bap_stream_reset(struct bt_bap_stream *stream);
void bt_bap_stream_attach(struct bt_conn *conn, struct bt_bap_stream *stream, struct bt_bap_ep *ep,
struct bt_audio_codec_cfg *codec_cfg);
void bt_audio_codec_cfg_to_iso_path(struct bt_iso_chan_path *path,
struct bt_audio_codec_cfg *codec_cfg);
void bt_audio_codec_qos_to_iso_qos(struct bt_iso_chan_io_qos *io,
const struct bt_audio_codec_qos *codec_qos);

13
subsys/bluetooth/audio/bap_unicast_client.c
View file

@ -806,17 +806,8 @@ static void unicast_client_ep_qos_state(struct bt_bap_ep *ep, struct net_buf_sim
* we have the ISO <-> EP coupling completed (due to setting
* the CIS ID in the QoS procedure).
*/
if (ep->dir == BT_AUDIO_DIR_SOURCE) {
/* If the endpoint is a source, then we need to
* configure our RX parameters
*/
bt_audio_codec_cfg_to_iso_path(&ep->iso->rx.path, stream->codec_cfg);
} else {
/* If the endpoint is a sink, then we need to
* configure our TX parameters
*/
bt_audio_codec_cfg_to_iso_path(&ep->iso->tx.path, stream->codec_cfg);
}
bt_bap_iso_configure_data_path(ep, stream->codec_cfg);
}
/* Notify upper layer */