michaelh/zephyr
1
0
Fork 0
Code Releases Activity

kernel: init: Simplify early rand get

Browse source 
There is an API to get an specific number of random bytes. There is
no need to re-implement this logic here.

Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
This commit is contained in:
Flavio Ceolin 2022-03-09 12:07:57 -08:00 • committed by Anas Nashif
commit ac079fcba6
1 changed files with 1 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

21
kernel/init.c
View file

@ -361,7 +361,6 @@ static FUNC_NORETURN void switch_to_main_thread(char *stack_ptr)
__boot_func __boot_func
void z_early_boot_rand_get(uint8_t *buf, size_t length) void z_early_boot_rand_get(uint8_t *buf, size_t length)
{ {
int n = sizeof(uint32_t);
#ifdef CONFIG_ENTROPY_HAS_DRIVER #ifdef CONFIG_ENTROPY_HAS_DRIVER
const struct device *entropy = device_get_binding(DT_CHOSEN_ZEPHYR_ENTROPY_LABEL); const struct device *entropy = device_get_binding(DT_CHOSEN_ZEPHYR_ENTROPY_LABEL);
int rc; int rc;
@ -394,25 +393,7 @@ sys_rand_fallback:
* devices are available should be built, this is only a fallback for * devices are available should be built, this is only a fallback for
* those devices without a HWRNG entropy driver. * those devices without a HWRNG entropy driver.
*/ */
sys_rand_get(buf, length);
while (length > 0U) {
uint32_t rndbits;
uint8_t *p_rndbits = (uint8_t *)&rndbits;
rndbits = sys_rand32_get();
if (length < sizeof(uint32_t)) {
n = length;
}
for (int i = 0; i < n; i++) {
*buf = *p_rndbits;
buf++;
p_rndbits++;
}
length -= n;
}
} }
/* defined(CONFIG_ENTROPY_HAS_DRIVER) || defined(CONFIG_TEST_RANDOM_GENERATOR) */ /* defined(CONFIG_ENTROPY_HAS_DRIVER) || defined(CONFIG_TEST_RANDOM_GENERATOR) */
#endif #endif