michaelh/zephyr
1
0
Fork 0
Code Releases Activity

boards: kconfig: Fix enabling USE_SEGGER_RTT for various boards

Browse source 
HAS_SEGGER_RTT is assigned by various Nordic boards, but assignments
have no effect on promptless symbols. This symbol is enabled through
being select'ed by SOC_SERIES_NRF52X.

Holyiot, nRF52833-PCA10100, nRF52840-PCA10056, and nRF52-PCA10040 only
assign HAS_SEGGER_RTT without assigning USE_SEGGER_RTT. They probably
meant to enable USE_SEGGER_RTT, so do that instead.

Also add a help text to HAS_SEGGER_RTT and a warning re. HAS_SEGGER_RTT
vs. USE_SEGGER_RTT to the documentation.

Flagged by https://github.com/zephyrproject-rtos/zephyr/pull/20742.

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
This commit is contained in:
Ulf Magnusson 2020-01-13 16:17:10 +01:00 • committed by Carles Cufí
commit a8fe2964ee
9 changed files with 14 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

1
boards/arm/bl652_dvk/bl652_dvk_defconfig
View file

@ -9,7 +9,6 @@ CONFIG_BOARD_BL652_DVK=y
CONFIG_ARM_MPU=y CONFIG_ARM_MPU=y
# Enable RTT # Enable RTT
CONFIG_HAS_SEGGER_RTT=y
CONFIG_USE_SEGGER_RTT=y CONFIG_USE_SEGGER_RTT=y
# enable GPIO # enable GPIO

1
boards/arm/bl654_dvk/bl654_dvk_defconfig
View file

@ -9,7 +9,6 @@ CONFIG_BOARD_BL654_DVK=y
CONFIG_ARM_MPU=y CONFIG_ARM_MPU=y
# Enable RTT # Enable RTT
CONFIG_HAS_SEGGER_RTT=y
CONFIG_USE_SEGGER_RTT=y CONFIG_USE_SEGGER_RTT=y
# enable GPIO # enable GPIO

1
boards/arm/decawave_dwm1001_dev/decawave_dwm1001_dev_defconfig
View file

@ -9,7 +9,6 @@ CONFIG_BOARD_DECAWAVE_DWM1001_DEV=y
CONFIG_ARM_MPU=y CONFIG_ARM_MPU=y
# Enable RTT # Enable RTT
CONFIG_HAS_SEGGER_RTT=y
CONFIG_USE_SEGGER_RTT=y CONFIG_USE_SEGGER_RTT=y
# enable GPIO # enable GPIO

2
boards/arm/holyiot_yj16019/holyiot_yj16019_defconfig
View file

@ -7,7 +7,7 @@ CONFIG_BOARD_HOLYIOT_YJ16019=y
CONFIG_ARM_MPU=y CONFIG_ARM_MPU=y
# Enable RTT # Enable RTT
CONFIG_HAS_SEGGER_RTT=y CONFIG_USE_SEGGER_RTT=y
# Enable GPIO # Enable GPIO
CONFIG_GPIO=y CONFIG_GPIO=y

2
boards/arm/nrf52833_pca10100/nrf52833_pca10100_defconfig
View file

@ -9,7 +9,7 @@ CONFIG_BOARD_NRF52833_PCA10100=y
CONFIG_ARM_MPU=y CONFIG_ARM_MPU=y
# Enable RTT # Enable RTT
CONFIG_HAS_SEGGER_RTT=y CONFIG_USE_SEGGER_RTT=y
# enable GPIO # enable GPIO
CONFIG_GPIO=y CONFIG_GPIO=y

2
boards/arm/nrf52840_pca10056/nrf52840_pca10056_defconfig
View file

@ -9,7 +9,7 @@ CONFIG_BOARD_NRF52840_PCA10056=y
CONFIG_ARM_MPU=y CONFIG_ARM_MPU=y
# Enable RTT # Enable RTT
CONFIG_HAS_SEGGER_RTT=y CONFIG_USE_SEGGER_RTT=y
# enable GPIO # enable GPIO
CONFIG_GPIO=y CONFIG_GPIO=y

2
boards/arm/nrf52_pca10040/nrf52_pca10040_defconfig
View file

@ -9,7 +9,7 @@ CONFIG_BOARD_NRF52_PCA10040=y
CONFIG_ARM_MPU=y CONFIG_ARM_MPU=y
# Enable RTT # Enable RTT
CONFIG_HAS_SEGGER_RTT=y CONFIG_USE_SEGGER_RTT=y
# enable GPIO # enable GPIO
CONFIG_GPIO=y CONFIG_GPIO=y

9
doc/guides/tools/nordic_segger.rst
View file

@ -162,10 +162,17 @@ To use RTT, you will first need to enable it by adding the following lines in yo
.. code-block:: text .. code-block:: text
CONFIG_HAS_SEGGER_RTT=y
CONFIG_USE_SEGGER_RTT=y CONFIG_USE_SEGGER_RTT=y
CONFIG_RTT_CONSOLE=y CONFIG_RTT_CONSOLE=y
.. warning::
There is also a ``HAS_SEGGER_RTT`` symbol that indicates that the platform
supports SEGGER J-Link RTT. This symbol is set automatically by the SoC
Kconfig files. Do not confuse it with ``USE_SEGGER_RTT``.
``USE_SEGGER_RTT`` depends on ``HAS_SEGGER_RTT``.
If you get no RTT output you might need to disable other consoles which conflict If you get no RTT output you might need to disable other consoles which conflict
with the RTT one if they are enabled by default in the particular sample or with the RTT one if they are enabled by default in the particular sample or
application you are running. For example, to disable the UART console, application you are running. For example, to disable the UART console,

2
subsys/debug/Kconfig.segger
View file

@ -3,6 +3,8 @@
config HAS_SEGGER_RTT config HAS_SEGGER_RTT
bool bool
help
Indicates that the platform supports SEGGER J-Link RTT.
config USE_SEGGER_RTT config USE_SEGGER_RTT
bool "Enable SEGGER RTT libraries." bool "Enable SEGGER RTT libraries."