michaelh/zephyr
1
0
Fork 0
Code Releases Activity

west: sign.py: always log the rimage command

Browse source 
rimage is very verbose by default and has no -q(uiet) option, so saving
one line out of more than 100 lines is pointless.

RimageSigner.sign() was already very complex and suffering from
combinatorial explosion of parameters. With .toml
pre-processing (#65411) it's getting worse, so we really need all build
logs to show the complete rimage command.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This commit is contained in:
Marc Herbert 2023-12-11 01:26:58 +00:00 • committed by Carles Cufí
commit a65b8d40fb
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
scripts/west_commands/sign.py
View file

@ -535,7 +535,8 @@ class RimageSigner(Signer):
sign_base = [tool_path]
# Sub-command arg '-q' takes precedence over west '-v'
# Align rimage verbosity.
# Sub-command arg 'west sign -q' takes precedence over west '-v'
if not args.quiet and args.verbose:
sign_base += ['-v'] * args.verbose
@ -562,8 +563,7 @@ class RimageSigner(Signer):
sign_base += (['-o', out_bin] + sign_config_extra_args +
extra_ri_args + args.tool_args + components)
if not args.quiet:
log.inf(quote_sh_list(sign_base))
command.inf(quote_sh_list(sign_base))
subprocess.check_call(sign_base)
if no_manifest: