michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: CAN: MCP2515: Read INT GPIO pin to check interrupt status

Browse source 
Faster than the 3 byte SPI read operation when no interrupt flags are
expected to be set.

Signed-off-by: Nick Ward <nix.ward@gmail.com>
This commit is contained in:
Nick Ward 2019-07-21 22:41:16 +10:00 • committed by Jukka Rissanen
commit a64f998645
1 changed files with 26 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

32
drivers/can/can_mcp2515.c
View file

@ -533,11 +533,26 @@ static void mcp2515_recover(struct device *dev, s32_t timeout)
static void mcp2515_handle_interrupts(struct device *dev) static void mcp2515_handle_interrupts(struct device *dev)
{ {
const struct mcp2515_config *dev_cfg = DEV_CFG(dev);
struct mcp2515_data *dev_data = DEV_DATA(dev);
u32_t pin;
int ret;
u8_t canintf; u8_t canintf;
mcp2515_cmd_read_reg(dev, MCP2515_ADDR_CANINTF, &canintf, 1); /* Loop until INT pin is high (all interrupt flags handled) */
while (1) {
ret = mcp2515_cmd_read_reg(dev, MCP2515_ADDR_CANINTF,
&canintf, 1);
if (ret != 0) {
LOG_ERR("Couldn't read INTF register %d", ret);
continue;
}
if (canintf == 0) {
/* No interrupt flags set */
break;
}
while (canintf != 0) {
if (canintf & MCP2515_CANINTF_RX0IF) { if (canintf & MCP2515_CANINTF_RX0IF) {
mcp2515_rx(dev, 0); mcp2515_rx(dev, 0);
} }
@ -566,9 +581,14 @@ static void mcp2515_handle_interrupts(struct device *dev)
mcp2515_cmd_bit_modify(dev, MCP2515_ADDR_CANINTF, canintf, mcp2515_cmd_bit_modify(dev, MCP2515_ADDR_CANINTF, canintf,
~canintf); ~canintf);
/* check that no new interrupts happened while clearing known /* Break from loop if INT pin is no longer low */
* ones */ ret = gpio_pin_read(dev_data->int_gpio, dev_cfg->int_pin, &pin);
mcp2515_cmd_read_reg(dev, MCP2515_ADDR_CANINTF, &canintf, 1); if (ret != 0) {
LOG_ERR("Couldn't read INT pin");
} else if (pin != 0) {
/* All interrupt flags handled */
break;
}
} }
} }
@ -610,7 +630,7 @@ static int mcp2515_init(struct device *dev)
struct mcp2515_data *dev_data = DEV_DATA(dev); struct mcp2515_data *dev_data = DEV_DATA(dev);
int ret; int ret;
k_sem_init(&dev_data->int_sem, 0, UINT_MAX); k_sem_init(&dev_data->int_sem, 0, 1);
k_mutex_init(&dev_data->mutex); k_mutex_init(&dev_data->mutex);
k_sem_init(&dev_data->tx_sem, 3, 3); k_sem_init(&dev_data->tx_sem, 3, 3);
k_sem_init(&dev_data->tx_cb[0].sem, 0, 1); k_sem_init(&dev_data->tx_cb[0].sem, 0, 1);