From a3728d71e98c5f1c83a1c1c56425a95fd5a82cf7 Mon Sep 17 00:00:00 2001 From: Josuah Demangeon Date: Tue, 10 Jun 2025 17:38:37 +0000 Subject: [PATCH] drivers: video: common: avoid dead code in functions with retry Avoid k_sleep() never being called when video_write_reg_retry() and video_read_reg_retry() have a number of retry set to zero (default). The default number of retries being controlled by CONFIG_VIDEO_I2C_RETRY_NUM. Signed-off-by: Josuah Demangeon --- drivers/video/video_common.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/video/video_common.c b/drivers/video/video_common.c index 6c02d663ca5..3a30dc7a260 100644 --- a/drivers/video/video_common.c +++ b/drivers/video/video_common.c @@ -204,8 +204,9 @@ static int video_read_reg_retry(const struct i2c_dt_spec *i2c, uint8_t *buf_w, s LOG_HEXDUMP_ERR(buf_w, size_w, "failed to write-read to I2C register"); return ret; } - - k_sleep(K_MSEC(1)); + if (CONFIG_VIDEO_I2C_RETRY_NUM > 0) { + k_sleep(K_MSEC(1)); + } } return 0; @@ -274,8 +275,9 @@ static int video_write_reg_retry(const struct i2c_dt_spec *i2c, uint8_t *buf_w, LOG_HEXDUMP_ERR(buf_w, size, "failed to write to I2C register"); return ret; } - - k_sleep(K_MSEC(1)); + if (CONFIG_VIDEO_I2C_RETRY_NUM > 0) { + k_sleep(K_MSEC(1)); + } } return 0;