michaelh/zephyr
1
0
Fork 0
Code Releases Activity

net: samples: Remove semaphore from sntp_client

Browse source 
Issue found using Coccinelle. Semaphore is not required at all
in this application.

Fixes #11150

Signed-off-by: Ravi kumar Veeramally <ravikumar.veeramally@linux.intel.com>
This commit is contained in:
Ravi kumar Veeramally 2018-11-07 12:41:31 +02:00 • committed by Jukka Rissanen
commit a34d14b03c
1 changed files with 5 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

17
samples/net/sntp_client/src/main.c
View file

@ -10,8 +10,6 @@
#define SNTP_PORT 123
struct k_sem sem;
void resp_callback(struct sntp_ctx *ctx,
int status,
u64_t epoch_time,
@ -20,8 +18,6 @@ void resp_callback(struct sntp_ctx *ctx,
printk("time: %lld\n", epoch_time);
printk("status: %d\n", status);
printk("user_data: %p\n", user_data);
k_sem_give(&sem);
}
void main(void)
@ -29,8 +25,6 @@ void main(void)
struct sntp_ctx ctx;
int rv;
k_sem_init(&sem, 0, 1);
/* ipv4 */
rv = sntp_init(&ctx,
CONFIG_NET_CONFIG_PEER_IPV4_ADDR,
@ -38,16 +32,15 @@ void main(void)
K_FOREVER);
if (rv < 0) {
printk("Failed to init sntp ctx: %d\n", rv);
return;
goto end;
}
rv = sntp_request(&ctx, K_FOREVER, resp_callback, NULL);
if (rv < 0) {
printk("Failed to send sntp request: %d\n", rv);
return;
goto end;
}
k_sem_take(&sem, K_FOREVER);
sntp_close(&ctx);
/* ipv6 */
@ -57,15 +50,15 @@ void main(void)
K_NO_WAIT);
if (rv < 0) {
printk("Failed to initi sntp ctx: %d\n", rv);
return;
goto end;
}
rv = sntp_request(&ctx, K_NO_WAIT, resp_callback, NULL);
if (rv < 0) {
printk("Failed to send sntp request: %d\n", rv);
return;
goto end;
}
k_sem_take(&sem, K_FOREVER);
end:
sntp_close(&ctx);
}