michaelh/zephyr
1
0
Fork 0
Code Releases Activity

driver/sensor: lis2mdl: change order of operations in trigger init

Browse source 
Creation of callback thread is moved before the enabling of
the callback itself.

Signed-off-by: Armando Visconti <armando.visconti@st.com>
This commit is contained in:
Armando Visconti 2019-09-20 16:59:24 +02:00 • committed by Maureen Helm
commit a34a5885b8
1 changed files with 13 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

28
drivers/sensor/lis2mdl/lis2mdl_trigger.c
View file

@ -130,6 +130,18 @@ int lis2mdl_init_interrupt(struct device *dev)
return -EINVAL; return -EINVAL;
} }
#if defined(CONFIG_LIS2MDL_TRIGGER_OWN_THREAD)
k_sem_init(&lis2mdl->gpio_sem, 0, UINT_MAX);
k_thread_create(&lis2mdl->thread, lis2mdl->thread_stack,
CONFIG_LIS2MDL_THREAD_STACK_SIZE,
(k_thread_entry_t)lis2mdl_thread, dev,
0, NULL, K_PRIO_COOP(CONFIG_LIS2MDL_THREAD_PRIORITY),
0, 0);
#elif defined(CONFIG_LIS2MDL_TRIGGER_GLOBAL_THREAD)
lis2mdl->work.handler = lis2mdl_work_cb;
lis2mdl->dev = dev;
#endif
gpio_pin_configure(lis2mdl->gpio, config->gpio_pin, gpio_pin_configure(lis2mdl->gpio, config->gpio_pin,
GPIO_DIR_IN | GPIO_INT | GPIO_INT_EDGE | GPIO_DIR_IN | GPIO_INT | GPIO_INT_EDGE |
GPIO_INT_ACTIVE_HIGH | GPIO_INT_DEBOUNCE); GPIO_INT_ACTIVE_HIGH | GPIO_INT_DEBOUNCE);
@ -143,19 +155,5 @@ int lis2mdl_init_interrupt(struct device *dev)
return -EIO; return -EIO;
} }
#if defined(CONFIG_LIS2MDL_TRIGGER_OWN_THREAD) return gpio_pin_enable_callback(lis2mdl->gpio, config->gpio_pin);
k_sem_init(&lis2mdl->gpio_sem, 0, UINT_MAX);
k_thread_create(&lis2mdl->thread, lis2mdl->thread_stack,
CONFIG_LIS2MDL_THREAD_STACK_SIZE,
(k_thread_entry_t)lis2mdl_thread, dev,
0, NULL, K_PRIO_COOP(CONFIG_LIS2MDL_THREAD_PRIORITY),
0, 0);
#elif defined(CONFIG_LIS2MDL_TRIGGER_GLOBAL_THREAD)
lis2mdl->work.handler = lis2mdl_work_cb;
lis2mdl->dev = dev;
#endif
gpio_pin_enable_callback(lis2mdl->gpio, config->gpio_pin);
return 0;
} }