michaelh/zephyr
1
0
Fork 0
Code Releases Activity

tests posix timer: Fix timer check

Browse source 
The timer check does not work properly for platforms
which have a system tick timer with a period that
does not properly divide the configured time interval.

In those, depending on when the timer is started and
stopped, one signal less may be received.

This is for example the case for nrf5x platforms,
where the system tick timer is driven by a 32.768KHz
clock.

=> Correct the test, to accept receiving 1 signal
too little during the wait.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
This commit is contained in:
Alberto Escolar Piedras 2023-10-23 16:27:47 +02:00 • committed by Chris Friedt
commit a2d1e979ef
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
tests/posix/common/src/timer.c
View file

@ -30,7 +30,7 @@ void test_timer(int sigev_notify)
timer_t timerid;
struct itimerspec value, ovalue;
struct timespec ts, te;
int64_t nsecs_elapsed, secs_elapsed, total_secs_timer;
int64_t nsecs_elapsed, secs_elapsed;
exp_count = 0;
sig.sigev_notify = sigev_notify;
@ -84,15 +84,15 @@ void test_timer(int sigev_notify)
secs_elapsed = (te.tv_sec - ts.tv_sec - 1);
}
total_secs_timer = (value.it_value.tv_sec * NSEC_PER_SEC +
value.it_value.tv_nsec + (uint64_t) exp_count *
(value.it_interval.tv_sec * NSEC_PER_SEC +
value.it_interval.tv_nsec)) / NSEC_PER_SEC;
uint64_t elapsed = secs_elapsed*NSEC_PER_SEC + nsecs_elapsed;
uint64_t first_sig = value.it_value.tv_sec * NSEC_PER_SEC + value.it_value.tv_nsec;
uint64_t sig_interval = value.it_interval.tv_sec * NSEC_PER_SEC + value.it_interval.tv_nsec;
int expected_signal_count = (elapsed - first_sig) / sig_interval + 1;
/*TESTPOINT: Check if POSIX timer test passed*/
zassert_equal(total_secs_timer, secs_elapsed,
"POSIX timer test has failed");
zassert_within(exp_count, expected_signal_count, 1,
"POSIX timer test has failed %i != %i",
exp_count, expected_signal_count);
}
ZTEST(posix_apis, test_timer)