michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: ov2640: fix integer underflow in retry logic

Browse source 
Properly stop retrying instead of underflowing uint8_t
fixes CID-487667 and CID-487767

Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
This commit is contained in:
Benjamin Cabé 2025-01-28 16:10:53 +01:00 • committed by Benjamin Cabé
commit a253fe27c9
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
drivers/video/ov2640.c
View file

@ -490,7 +490,7 @@ static int ov2640_write_reg(const struct i2c_dt_spec *spec, uint8_t reg_addr,
* just to be sure that the connection error is not caused by driver
* itself.
*/
while (tries--) {
while (tries-- > 0) {
if (!i2c_reg_write_byte_dt(spec, reg_addr, value)) {
return 0;
}
@ -513,7 +513,7 @@ static int ov2640_read_reg(const struct i2c_dt_spec *spec, uint8_t reg_addr)
* just to be sure that the connection error is not caused by driver
* itself.
*/
while (tries--) {
while (tries-- > 0) {
if (!i2c_reg_read_byte_dt(spec, reg_addr, &value)) {
return value;
}