michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: sensors: tmp112: Remove extra I2C reads

Browse source 
The original code erroneously used:
uint16_t *val;
sizeof val
instead of:
sizeof *val;
This commit fixes this problem and removes an unnecessary
buffer from the stack

Signed-off-by: Pete Dietl <petedietl@gmail.com>
This commit is contained in:
Pete Dietl 2021-12-08 10:25:12 +01:00 • committed by Maureen Helm
commit a1bf02e519
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
drivers/sensor/tmp112/tmp112.c
View file

@ -21,13 +21,11 @@ LOG_MODULE_REGISTER(TMP112, CONFIG_SENSOR_LOG_LEVEL);
static int tmp112_reg_read(const struct tmp112_config *cfg,
uint8_t reg, uint16_t *val)
{
uint8_t buf[sizeof(val)];
if (i2c_burst_read_dt(&cfg->bus, reg, buf, sizeof(buf)) < 0) {
if (i2c_burst_read_dt(&cfg->bus, reg, (uint8_t *)val, sizeof(*val)) < 0) {
return -EIO;
}
*val = sys_get_be16(buf);
*val = sys_be16_to_cpu(*val);
return 0;
}