michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: lora: sx1276: call DIO handlers in workqueue

Browse source 
DIO handlers defined in loramac-node are quite complex. Additionally
they call read/write operations over SPI with the sx1276 chip. This
cannot work properly in interrupt context, so call DIO handlers in
system workqueue instead.

Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
This commit is contained in:
Marcin Niestroj 2020-04-06 14:25:59 +02:00 • committed by Kumar Gala
commit a150fb6bb7
1 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
drivers/lora/sx1276.c
View file

@ -55,6 +55,7 @@ struct sx1276_data {
struct device *spi;
struct spi_config spi_cfg;
struct device *dio_dev[SX1276_MAX_DIO];
struct k_work dio_work[SX1276_MAX_DIO];
struct k_sem data_sem;
RadioEvents_t sx1276_event;
u8_t *rx_buf;
@ -156,6 +157,13 @@ void DelayMsMcu(uint32_t ms)
k_sleep(ms);
}
static void sx1276_dio_work_handle(struct k_work *work)
{
int dio = work - dev_data.dio_work;
(*DioIrq[dio])(NULL);
}
static void sx1276_irq_callback(struct device *dev,
struct gpio_callback *cb, u32_t pins)
{
@ -166,7 +174,7 @@ static void sx1276_irq_callback(struct device *dev,
for (i = 0; i < SX1276_MAX_DIO; i++) {
if (dev == dev_data.dio_dev[i] &&
pin == sx1276_dios[i].pin) {
(*DioIrq[i])(NULL);
k_work_submit(&dev_data.dio_work[i]);
}
}
}
@ -189,6 +197,8 @@ void SX1276IoIrqInit(DioIrqHandler **irqHandlers)
return;
}
k_work_init(&dev_data.dio_work[i], sx1276_dio_work_handle);
gpio_pin_configure(dev_data.dio_dev[i], sx1276_dios[i].pin,
GPIO_INPUT | GPIO_INT_DEBOUNCE
| sx1276_dios[i].flags);