michaelh/zephyr
1
0
Fork 0
Code Releases Activity

uart_qmsi: fix possible divide-by-zero

Browse source 
The line control value could result in a baud divisor of zero.
Check this condition and return -EINVAL if that is the case.

Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
This commit is contained in:
Andrew Boie 2018-05-07 11:13:32 -07:00 • committed by Anas Nashif
commit a0c3aadde4
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
drivers/serial/uart_qmsi.c
View file

@ -404,6 +404,9 @@ static int uart_qmsi_line_ctrl_set(struct device *dev, u32_t ctrl, u32_t val)
cfg.line_control = QM_UART[instance]->lcr;
cfg.baud_divisor = QM_UART_CFG_BAUD_DL_PACK(DIVISOR_HIGH(val),
DIVISOR_LOW(val), 0);
if (cfg.baud_divisor == 0) {
return -EINVAL;
}
cfg.hw_fc = QM_UART[instance]->mcr & QM_UART_MCR_AFCE;
qm_uart_set_config(instance, &cfg);
break;