michaelh/zephyr
1
0
Fork 0
Code Releases Activity

susbsys: settings: fix coverity issues

Browse source 
API settings_subsys_init call was changed so that it returns
error (so returns int instead of void).
Prototype of storage helper function export_func for
settings_handler::h_export was changed so that it returns error
(so returns int instead of void).
Fixed few other error handling issues by ignoring return
values.

Tests were aligned to above patches.

Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
This commit is contained in:
Andrzej Puzdrowski 2018-04-16 12:48:37 +02:00 • committed by Anas Nashif
commit 9fe30535d7
6 changed files with 31 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

6
include/settings/settings.h
View file

@ -101,7 +101,7 @@ struct settings_handler {
char *(*h_get)(int argc, char **argv, char *val, int val_len_max);
int (*h_set)(int argc, char **argv, char *val);
int (*h_commit)(void);
int (*h_export)(void (*export_func)(char *name, char *val),
int (*h_export)(int (*export_func)(const char *name, char *val),
enum settings_export_tgt tgt);
};
@ -111,8 +111,10 @@ struct settings_handler {
* Can be called at application startup.
* In case the backend is NFFS Remember to call it after FS was mounted.
* For FCB backend it can be called without such a restriction.
*
* @return 0 on success, non-zero on failure.
*/
void settings_subsys_init(void);
int settings_subsys_init(void);
/**
* Register a handler for settings items.