michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: modem: don't clear out cmd handlers if they were not setup

Browse source 
There is no point in clearing out command handlers if they were not
setup properly. Just skip to next instruction.

Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
This commit is contained in:
Marcin Niestroj 2020-11-19 20:08:50 +01:00 • committed by Anas Nashif
commit 9fe279f744
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
drivers/modem/modem_cmd_handler.c
View file

@ -497,7 +497,7 @@ static int _modem_cmd_send(struct modem_iface *iface,
ret = modem_cmd_handler_update_cmds(data, handler_cmds,
handler_cmds_len, true);
if (ret < 0) {
goto exit;
goto unlock_tx_lock;
}
#if defined(CONFIG_MODEM_CONTEXT_VERBOSE_DEBUG)
@ -531,9 +531,10 @@ static int _modem_cmd_send(struct modem_iface *iface,
}
}
exit:
/* unset handlers and ignore any errors */
(void)modem_cmd_handler_update_cmds(data, NULL, 0U, false);
unlock_tx_lock:
if (!no_tx_lock) {
k_sem_give(&data->sem_tx_lock);
}