michaelh/zephyr
1
0
Fork 0
Code Releases Activity

samples: Bluetooth: Broadcast Audio Source: Fix potential memory leak

Browse source 
In error cases, where send_data() returns early, the allocated net_buf
is not free'd, causing a memory leak affecting the net_buf pool.
Fix this by freeing the allocated net_buf before returning early
from send_data().

Signed-off-by: Sean Farrelly <sean.farrelly@outlook.com>
This commit is contained in:
Sean Farrelly 2024-02-14 10:37:58 +04:00 • committed by Henrik Brix Andersen
commit 9e28e9e564
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
samples/bluetooth/broadcast_audio_source/src/main.c
View file

@ -171,6 +171,7 @@ static void send_data(struct broadcast_source_stream *source_stream)
if (source_stream->lc3_encoder == NULL) {
printk("LC3 encoder not setup, cannot encode data.\n");
net_buf_unref(buf);
return;
}
@ -190,6 +191,7 @@ static void send_data(struct broadcast_source_stream *source_stream)
send_pcm_data, 1, octets_per_frame, lc3_encoded_buffer);
if (ret == -1) {
printk("LC3 encoder failed - wrong parameters?: %d", ret);
net_buf_unref(buf);
return;
}