michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: regulator: cleanup device_is_ready and atoi usage

Browse source 
Cleanup regulator shell to use strtol() over atoi(), as strtol features
error detection. Remove device_is_ready() checks, and replace them with
NULL checks as device_get_binding() calls device_is_ready() interally

Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
This commit is contained in:
Daniel DeGrasse 2022-12-02 15:17:03 -06:00 • committed by Carles Cufí
commit 9d1bcc6126
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
drivers/regulator/regulator_shell.c
View file

@ -18,7 +18,7 @@ static int cmd_reg_en(const struct shell *sh, size_t argc, char **argv)
int ret;
reg_dev = device_get_binding(argv[1]);
if (!device_is_ready(reg_dev)) {
if (reg_dev == NULL) {
shell_error(sh, "regulator device %s not available", argv[1]);
return -ENODEV;
}
@ -39,7 +39,7 @@ static int cmd_reg_dis(const struct shell *sh, size_t argc, char **argv)
int ret;
reg_dev = device_get_binding(argv[1]);
if (!device_is_ready(reg_dev)) {
if (reg_dev == NULL) {
shell_error(sh, "regulator device %s not available", argv[1]);
return -ENODEV;
}
@ -59,13 +59,13 @@ static int cmd_set_vol(const struct shell *sh, size_t argc, char **argv)
const struct device *reg_dev;
reg_dev = device_get_binding(argv[1]);
if (!device_is_ready(reg_dev)) {
if (reg_dev == NULL) {
shell_error(sh, "regulator device %s not available", argv[1]);
return -ENODEV;
}
lvol = atoi(argv[2]) * 1000;
uvol = atoi(argv[3]) * 1000;
lvol = strtol(argv[2], NULL, 10) * 1000;
uvol = strtol(argv[3], NULL, 10) * 1000;
shell_print(sh, "Setting range to %d-%d uV", lvol, uvol);
ret = regulator_set_voltage(reg_dev, lvol, uvol);
if (ret < 0) {
@ -87,13 +87,13 @@ static int cmd_set_ilim(const struct shell *sh, size_t argc, char **argv)
const struct device *reg_dev;
reg_dev = device_get_binding(argv[1]);
if (!device_is_ready(reg_dev)) {
if (reg_dev == NULL) {
shell_error(sh, "regulator device %s not available", argv[1]);
return -ENODEV;
}
lcur = atoi(argv[2]) * 1000;
ucur = atoi(argv[3]) * 1000;
lcur = strtol(argv[2], NULL, 10) * 1000;
ucur = strtol(argv[3], NULL, 10) * 1000;
shell_print(sh, "Setting range to %d-%d uA", lcur, ucur);
ret = regulator_set_current_limit(reg_dev, lcur, ucur);
if (ret < 0) {