michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Bluetooth: Mesh: Fix coverity warning of unchecked return

Browse source 
Most places check the return value of bt_mesh_model_send(), so check
for it in all places.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
This commit is contained in:
Johan Hedberg 2017-11-21 21:22:46 +02:00 • committed by Johan Hedberg
commit 9b87e0f2cc
2 changed files with 27 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

28
subsys/bluetooth/host/mesh/cfg_srv.c
View file

@ -947,7 +947,9 @@ static void send_mod_pub_status(struct bt_mesh_model *cfg_mod,
memcpy(net_buf_simple_add(msg, 2), mod_id, 2); memcpy(net_buf_simple_add(msg, 2), mod_id, 2);
} }
bt_mesh_model_send(cfg_mod, ctx, msg, NULL, NULL); if (bt_mesh_model_send(cfg_mod, ctx, msg, NULL, NULL)) {
BT_ERR("Unable to send Model Publication Status");
}
} }
static void mod_pub_get(struct bt_mesh_model *model, static void mod_pub_get(struct bt_mesh_model *model,
@ -1225,7 +1227,9 @@ static void send_mod_sub_status(struct bt_mesh_model *model,
memcpy(net_buf_simple_add(msg, 2), mod_id, 2); memcpy(net_buf_simple_add(msg, 2), mod_id, 2);
} }
bt_mesh_model_send(model, ctx, msg, NULL, NULL); if (bt_mesh_model_send(model, ctx, msg, NULL, NULL)) {
BT_ERR("Unable to send Model Subscription Status");
}
} }
static void mod_sub_add(struct bt_mesh_model *model, static void mod_sub_add(struct bt_mesh_model *model,
@ -1868,7 +1872,9 @@ static void send_net_key_status(struct bt_mesh_model *model,
net_buf_simple_add_u8(msg, status); net_buf_simple_add_u8(msg, status);
net_buf_simple_add_le16(msg, idx); net_buf_simple_add_le16(msg, idx);
bt_mesh_model_send(model, ctx, msg, NULL, NULL); if (bt_mesh_model_send(model, ctx, msg, NULL, NULL)) {
BT_ERR("Unable to send NetKey Status");
}
} }
static void net_key_add(struct bt_mesh_model *model, static void net_key_add(struct bt_mesh_model *model,
@ -2366,7 +2372,9 @@ send_list:
} }
} }
bt_mesh_model_send(model, ctx, msg, NULL, NULL); if (bt_mesh_model_send(model, ctx, msg, NULL, NULL)) {
BT_ERR("Unable to send Model Application List message");
}
} }
static void node_reset(struct bt_mesh_model *model, static void node_reset(struct bt_mesh_model *model,
@ -2522,7 +2530,9 @@ static void send_krp_status(struct bt_mesh_model *model,
net_buf_simple_add_le16(msg, idx); net_buf_simple_add_le16(msg, idx);
net_buf_simple_add_u8(msg, phase); net_buf_simple_add_u8(msg, phase);
bt_mesh_model_send(model, ctx, msg, NULL, NULL); if (bt_mesh_model_send(model, ctx, msg, NULL, NULL)) {
BT_ERR("Unable to send Key Refresh State Status");
}
} }
static void krp_get(struct bt_mesh_model *model, struct bt_mesh_msg_ctx *ctx, static void krp_get(struct bt_mesh_model *model, struct bt_mesh_msg_ctx *ctx,
@ -2673,7 +2683,9 @@ static void hb_pub_send_status(struct bt_mesh_model *model,
net_buf_simple_add_le16(msg, cfg->hb_pub.net_idx); net_buf_simple_add_le16(msg, cfg->hb_pub.net_idx);
send: send:
bt_mesh_model_send(model, ctx, msg, NULL, NULL); if (bt_mesh_model_send(model, ctx, msg, NULL, NULL)) {
BT_ERR("Unable to send Heartbeat Publication Status");
}
} }
static void heartbeat_pub_get(struct bt_mesh_model *model, static void heartbeat_pub_get(struct bt_mesh_model *model,
@ -2799,7 +2811,9 @@ static void hb_sub_send_status(struct bt_mesh_model *model,
net_buf_simple_add_u8(msg, cfg->hb_sub.max_hops); net_buf_simple_add_u8(msg, cfg->hb_sub.max_hops);
} }
bt_mesh_model_send(model, ctx, msg, NULL, NULL); if (bt_mesh_model_send(model, ctx, msg, NULL, NULL)) {
BT_ERR("Unable to send Heartbeat Subscription Status");
}
} }
static void heartbeat_sub_get(struct bt_mesh_model *model, static void heartbeat_sub_get(struct bt_mesh_model *model,

8
subsys/bluetooth/host/mesh/health_srv.c
View file

@ -237,7 +237,9 @@ static void send_attention_status(struct bt_mesh_model *model,
net_buf_simple_add_u8(msg, time); net_buf_simple_add_u8(msg, time);
bt_mesh_model_send(model, ctx, msg, NULL, NULL); if (bt_mesh_model_send(model, ctx, msg, NULL, NULL)) {
BT_ERR("Unable to send Attention Status");
}
} }
static void attention_get(struct bt_mesh_model *model, static void attention_get(struct bt_mesh_model *model,
@ -283,7 +285,9 @@ static void send_health_period_status(struct bt_mesh_model *model,
net_buf_simple_add_u8(msg, model->pub->period_div); net_buf_simple_add_u8(msg, model->pub->period_div);
bt_mesh_model_send(model, ctx, msg, NULL, NULL); if (bt_mesh_model_send(model, ctx, msg, NULL, NULL)) {
BT_ERR("Unable to send Health Period Status");
}
} }
static void health_period_get(struct bt_mesh_model *model, static void health_period_get(struct bt_mesh_model *model,