michaelh/zephyr
1
0
Fork 0
Code Releases Activity

net: Comment false positives reported by Coverity

Browse source 
Coverity reported false positives, add comment about these in
the code.

Jira: ZEP-2344
Jira: ZEP-2345

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
This commit is contained in:
Jukka Rissanen 2017-07-10 12:58:59 +03:00
commit 98fb2bed63
1 changed files with 18 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

18
subsys/net/lib/http/http_client.c
View file

@ -903,8 +903,18 @@ static int https_init(struct http_client_ctx *ctx)
mbedtls_platform_set_printf(printk); mbedtls_platform_set_printf(printk);
/* Coverity tells in CID 170746 that the mbedtls_ssl_init()
* is overwriting the ssl struct. This looks like false positive as
* the struct is initialized with proper size.
*/
mbedtls_ssl_init(&ctx->https.mbedtls.ssl); mbedtls_ssl_init(&ctx->https.mbedtls.ssl);
/* Coverity tells in CID 170745 that the mbedtls_ssl_config_init()
* is overwriting the conf struct. This looks like false positive as
* the struct is initialized with proper size.
*/
mbedtls_ssl_config_init(&ctx->https.mbedtls.conf); mbedtls_ssl_config_init(&ctx->https.mbedtls.conf);
mbedtls_entropy_init(&ctx->https.mbedtls.entropy); mbedtls_entropy_init(&ctx->https.mbedtls.entropy);
mbedtls_ctr_drbg_init(&ctx->https.mbedtls.ctr_drbg); mbedtls_ctr_drbg_init(&ctx->https.mbedtls.ctr_drbg);
@ -1513,6 +1523,10 @@ int http_client_init(struct http_client_ctx *ctx,
{ {
int ret; int ret;
/* Coverity tells in CID 170743 that the next memset() is
* is overwriting the ctx struct. This is false positive as
* the struct is initialized with proper size.
*/
memset(ctx, 0, sizeof(*ctx)); memset(ctx, 0, sizeof(*ctx));
if (server) { if (server) {
@ -1712,5 +1726,9 @@ void http_client_release(struct http_client_ctx *ctx)
/* Let all the pending waiters run */ /* Let all the pending waiters run */
k_yield(); k_yield();
/* Coverity tells in CID 170742 that the next memset() is
* is overwriting the ctx struct. This is false positive as
* the struct is initialized with proper size.
*/
memset(ctx, 0, sizeof(*ctx)); memset(ctx, 0, sizeof(*ctx));
} }