michaelh/zephyr
1
0
Fork 0
Code Releases Activity

sched: create unique function name

Browse source 
In file include/kernel/thread.h in "struct _thread_base" is a member
called "_wait_q_t *pended_on"
At the same time in file kernel/sched.c is function called
"static _wait_q_t *pended_on()"

Coding scanning tool assigns violation (MISRA R5.9) that static
object reused, because thread.h is included in struct.c file.

I think we can rename function to avoid misreading in the future.

Signed-off-by: Maksim Masalski <maksim.masalski@intel.com>
This commit is contained in:
Maksim Masalski 2021-05-25 14:40:14 +08:00 • committed by Anas Nashif
commit 970820e92d
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
kernel/sched.c
View file

@ -573,7 +573,7 @@ static inline void z_vrfy_k_thread_resume(struct k_thread *thread)
#include <syscalls/k_thread_resume_mrsh.c> #include <syscalls/k_thread_resume_mrsh.c>
#endif #endif
static _wait_q_t *pended_on(struct k_thread *thread) static _wait_q_t *pended_on_thread(struct k_thread *thread)
{ {
__ASSERT_NO_MSG(thread->base.pended_on); __ASSERT_NO_MSG(thread->base.pended_on);
@ -632,7 +632,7 @@ void z_pend_thread(struct k_thread *thread, _wait_q_t *wait_q,
static inline void unpend_thread_no_timeout(struct k_thread *thread) static inline void unpend_thread_no_timeout(struct k_thread *thread)
{ {
_priq_wait_remove(&pended_on(thread)->waitq, thread); _priq_wait_remove(&pended_on_thread(thread)->waitq, thread);
z_mark_thread_as_not_pending(thread); z_mark_thread_as_not_pending(thread);
thread->base.pended_on = NULL; thread->base.pended_on = NULL;
} }