michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: regulator: fix reference count underflow

Browse source 
Fixes regulator reference count underflow and adds error code
for attempting to disable an already disabled regulator

Signed-off-by: Vladislav Litvinov <vladislav.litvinov@nordicsemi.no>
This commit is contained in:
Vladislav Litvinov 2024-04-15 15:16:33 +02:00 • committed by Carles Cufí
commit 95622e49b2
1 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
drivers/regulator/regulator_common.c
View file

@ -183,12 +183,14 @@ int regulator_disable(const struct device *dev)
(void)k_mutex_lock(&data->lock, K_FOREVER);
#endif
data->refcnt--;
if (data->refcnt > 0) {
data->refcnt--;
if (data->refcnt == 0) {
ret = api->disable(dev);
if (ret < 0) {
data->refcnt++;
if (data->refcnt == 0) {
ret = api->disable(dev);
if (ret < 0) {
data->refcnt++;
}
}
}