michaelh/zephyr
1
0
Fork 0
Code Releases Activity

usb/cdc_acm : Unsupported functions return error code

Browse source 
Poll functions were not implemented for the cdc_acm
USB uart since the underlying USB device controller
always uses interrupts.
We return -ENOTSUP and 0 rather than leaving unimplemented.

Jira: ZEP-595

Change-Id: I02d9e693694d03296da3c815cdda53f151e06f6d
Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
This commit is contained in:
Jithu Joseph 2016-08-04 14:43:24 -07:00 • committed by Inaky Perez-Gonzalez
commit 93f8009eb6
1 changed files with 27 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

27
usb/class/cdc_acm.c
View file

@ -818,7 +818,34 @@ static int cdc_acm_line_ctrl_get(struct device *dev,
#endif /* CONFIG_UART_LINE_CTRL */ #endif /* CONFIG_UART_LINE_CTRL */
/*
* @brief Poll the device for input.
*
* @return -ENOTSUP Since underlying USB device controller always uses
* interrupts, polled mode UART APIs are not implemented for the UART interface
* exported by CDC ACM driver. Apps should use fifo_read API instead.
*/
static int cdc_acm_poll_in(struct device *dev, unsigned char *c)
{
return -ENOTSUP;
}
/*
* @brief Output a character in polled mode.
*
* @return 0 Since it is not supported. See the comments of
* cdc_acm_poll_in() for details. Apps should use fifo_fill API instead.
*/
static unsigned char cdc_acm_poll_out(struct device *dev,
unsigned char c)
{
return 0;
}
static struct uart_driver_api cdc_acm_driver_api = { static struct uart_driver_api cdc_acm_driver_api = {
.poll_in = cdc_acm_poll_in,
.poll_out = cdc_acm_poll_out,
.fifo_fill = cdc_acm_fifo_fill, .fifo_fill = cdc_acm_fifo_fill,
.fifo_read = cdc_acm_fifo_read, .fifo_read = cdc_acm_fifo_read,
.irq_tx_enable = cdc_acm_irq_tx_enable, .irq_tx_enable = cdc_acm_irq_tx_enable,