michaelh/zephyr
1
0
Fork 0
Code Releases Activity

pm: simplify state change check logic

Browse source 
The device PM control function will only be called if the requested
state is different from the current one. A significant amount of drivers
were checking for state changes, now unnecessary. This patch removes all
this redundant logic.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
This commit is contained in:
Gerard Marull-Paretas 2021-07-02 13:01:05 +02:00 • committed by Anas Nashif
commit 920f30cc0e
22 changed files with 176 additions and 400 deletions
Download patch file Download diff file Expand all files Collapse all files

11
drivers/serial/uart_stm32.c
View file

@ -1423,12 +1423,12 @@ static int uart_stm32_init(const struct device *dev)
#ifdef CONFIG_PM_DEVICE
static int uart_stm32_set_power_state(const struct device *dev,
enum pm_device_state new_state)
enum pm_device_state state)
{
USART_TypeDef *UartInstance = UART_STRUCT(dev);
/* setting a low power mode */
if (new_state != PM_DEVICE_STATE_ACTIVE) {
if (state != PM_DEVICE_STATE_ACTIVE) {
#ifdef USART_ISR_BUSY
/* Make sure that no USART transfer is on-going */
while (LL_USART_IsActiveFlag_BUSY(UartInstance) == 1) {
@ -1462,12 +1462,7 @@ static int uart_stm32_set_power_state(const struct device *dev,
static int uart_stm32_pm_control(const struct device *dev,
enum pm_device_state state)
{
enum pm_device_state curr_state;
(void)pm_device_state_get(dev, &curr_state);
if (state != curr_state) {
uart_stm32_set_power_state(dev, state);
}
uart_stm32_set_power_state(dev, state);
return 0;
}