michaelh/zephyr
1
0
Fork 0
Code Releases Activity

pm: simplify state change check logic

Browse source 
The device PM control function will only be called if the requested
state is different from the current one. A significant amount of drivers
were checking for state changes, now unnecessary. This patch removes all
this redundant logic.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
This commit is contained in:
Gerard Marull-Paretas 2021-07-02 13:01:05 +02:00 • committed by Anas Nashif
commit 920f30cc0e
22 changed files with 176 additions and 400 deletions
Download patch file Download diff file Expand all files Collapse all files

19
drivers/pwm/pwm_nrfx.c
View file

@ -292,13 +292,12 @@ static void pwm_nrfx_uninit(const struct device *dev)
memset(dev->data, 0, sizeof(struct pwm_nrfx_data));
}
static int pwm_nrfx_set_power_state(enum pm_device_state new_state,
enum pm_device_state current_state,
static int pwm_nrfx_set_power_state(enum pm_device_state state,
const struct device *dev)
{
int err = 0;
switch (new_state) {
switch (state) {
case PM_DEVICE_STATE_ACTIVE:
err = pwm_nrfx_init(dev);
break;
@ -306,9 +305,7 @@ static int pwm_nrfx_set_power_state(enum pm_device_state new_state,
case PM_DEVICE_STATE_SUSPEND:
case PM_DEVICE_STATE_FORCE_SUSPEND:
case PM_DEVICE_STATE_OFF:
if (current_state == PM_DEVICE_STATE_ACTIVE) {
pwm_nrfx_uninit(dev);
}
pwm_nrfx_uninit(dev);
break;
default:
__ASSERT_NO_MSG(false);
@ -320,15 +317,7 @@ static int pwm_nrfx_set_power_state(enum pm_device_state new_state,
static int pwm_nrfx_pm_control(const struct device *dev,
enum pm_device_state state)
{
int err = 0;
enum pm_device_state curr_state;
(void)pm_device_state_get(dev, &curr_state);
if (state != current_state) {
err = pwm_nrfx_set_power_state(state, current_state, dev);
}
return err;
return pwm_nrfx_set_power_state(state, dev);
}
#define PWM_NRFX_PM_CONTROL(idx) \