michaelh/zephyr
1
0
Fork 0
Code Releases Activity

kernel: syscall: Explicitly ignoring not used return

Browse source 
Some syscacll return value through parameters and for these functions
the return of _arch_syscall_invoke* are not used.

MISRA requires that all return values be checked.

Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
This commit is contained in:
Flavio Ceolin 2018-09-11 18:05:14 -07:00 • committed by Anas Nashif
commit 91b6123932
2 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
include/syscall.h
View file

@ -249,7 +249,7 @@ static inline u64_t _syscall_ret64_invoke0(u32_t call_id)
{ {
u64_t ret; u64_t ret;
_arch_syscall_invoke1((u32_t)&ret, call_id); (void)_arch_syscall_invoke1((u32_t)&ret, call_id);
return ret; return ret;
} }
@ -257,7 +257,7 @@ static inline u64_t _syscall_ret64_invoke1(u32_t arg1, u32_t call_id)
{ {
u64_t ret; u64_t ret;
_arch_syscall_invoke2(arg1, (u32_t)&ret, call_id); (void)_arch_syscall_invoke2(arg1, (u32_t)&ret, call_id);
return ret; return ret;
} }
@ -266,7 +266,7 @@ static inline u64_t _syscall_ret64_invoke2(u32_t arg1, u32_t arg2,
{ {
u64_t ret; u64_t ret;
_arch_syscall_invoke3(arg1, arg2, (u32_t)&ret, call_id); (void)_arch_syscall_invoke3(arg1, arg2, (u32_t)&ret, call_id);
return ret; return ret;
} }

2
scripts/gen_syscall_header.py
View file

@ -74,6 +74,8 @@ def gen_make_syscall(ret, argc, tabcount):
tabs(tabcount) tabs(tabcount)
if (ret != Retval.VOID): if (ret != Retval.VOID):
sys.stdout.write("return (ret)") sys.stdout.write("return (ret)")
else:
sys.stdout.write("return (void)")
if (argc <= 6 and ret != Retval.U64): if (argc <= 6 and ret != Retval.U64):
sys.stdout.write("_arch") sys.stdout.write("_arch")
sys.stdout.write("_syscall%s_invoke%d(" % sys.stdout.write("_syscall%s_invoke%d(" %