From 8ff96b5a576b4e44d075a524fbc7188f0aefcc4b Mon Sep 17 00:00:00 2001 From: Patrik Flykt Date: Thu, 29 Nov 2018 11:12:22 -0800 Subject: [PATCH] drivers: Add 'U' to unsigned variable assignments Add 'U' to a value when assigning it to an unsigned variable. MISRA-C rule 7.2 Signed-off-by: Patrik Flykt --- drivers/adc/adc_context.h | 2 +- drivers/adc/adc_dw.c | 4 +- drivers/adc/adc_intel_quark_d2000.c | 10 +-- drivers/adc/adc_mcux_adc16.c | 4 +- drivers/adc/adc_nrfx_adc.c | 4 +- drivers/adc/adc_nrfx_saadc.c | 4 +- drivers/adc/adc_sam_afec.c | 6 +- drivers/aio/aio_comparator_qmsi.c | 4 +- drivers/audio/intel_dmic.c | 12 ++-- drivers/bluetooth/hci/h4.c | 4 +- drivers/bluetooth/hci/h5.c | 2 +- drivers/bluetooth/hci/spi.c | 4 +- drivers/can/stm32_can.c | 6 +- drivers/clock_control/beetle_clock_control.c | 8 +-- drivers/clock_control/nrf5_power_clock.c | 12 ++-- drivers/console/ipm_console_receiver.c | 4 +- drivers/console/telnet_console.c | 16 ++--- drivers/console/uart_console.c | 18 +++--- drivers/console/websocket_console.c | 16 ++--- drivers/counter/counter_dtmr_cmsdk_apb.c | 2 +- drivers/counter/counter_tmr_cmsdk_apb.c | 2 +- drivers/counter/timer_dtmr_cmsdk_apb.c | 2 +- drivers/counter/timer_tmr_cmsdk_apb.c | 2 +- drivers/crypto/crypto_ataes132a_priv.h | 2 +- drivers/display/display_ili9340.c | 6 +- drivers/display/grove_lcd_rgb.c | 6 +- drivers/display/mb_display.c | 32 +++++----- drivers/display/ssd1673.c | 10 +-- drivers/dma/dma_cavs.c | 6 +- drivers/dma/dma_qmsi.c | 2 +- drivers/dma/dma_sam_xdmac.c | 6 +- drivers/entropy/entropy_mcux_rnga.c | 2 +- drivers/entropy/entropy_nrf5.c | 6 +- drivers/ethernet/eth_dw.c | 28 ++++---- drivers/ethernet/eth_enc28j60.c | 12 ++-- drivers/ethernet/eth_mcux.c | 8 +-- drivers/ethernet/eth_sam_gmac.c | 34 +++++----- drivers/ethernet/phy_sam_gmac.c | 4 +- drivers/flash/flash_sam0.c | 4 +- drivers/flash/flash_stm32f3x.c | 12 ++-- drivers/flash/soc_flash_nios2_qspi.c | 20 +++--- drivers/flash/soc_flash_nrf.c | 8 +-- drivers/flash/soc_flash_qmsi.c | 4 +- drivers/flash/spi_flash_w25qxxdv.c | 2 +- drivers/gpio/gpio_cc2650.c | 6 +- drivers/gpio/gpio_cc32xx.c | 2 +- drivers/gpio/gpio_gecko.c | 4 +- drivers/gpio/gpio_imx.c | 8 +-- drivers/gpio/gpio_mcux.c | 8 +-- drivers/gpio/gpio_mcux_igpio.c | 4 +- drivers/gpio/gpio_nrfx.c | 8 +-- drivers/gpio/gpio_pcal9535a.c | 6 +- drivers/gpio/gpio_qmsi.c | 2 +- drivers/gpio/gpio_qmsi_ss.c | 2 +- drivers/gpio/gpio_sch.c | 14 ++-- drivers/gpio/gpio_shell.c | 10 +-- drivers/gpio/gpio_sifive.c | 16 ++--- drivers/i2c/i2c_atmel_sam3.c | 20 +++--- drivers/i2c/i2c_bitbang.c | 2 +- drivers/i2c/i2c_cc32xx.c | 4 +- drivers/i2c/i2c_dw.c | 40 ++++++------ drivers/i2c/i2c_esp32.c | 10 +-- drivers/i2c/i2c_gecko.c | 2 +- drivers/i2c/i2c_gpio.c | 2 +- drivers/i2c/i2c_handlers.c | 2 +- drivers/i2c/i2c_imx.c | 6 +- drivers/i2c/i2c_ll_stm32.c | 2 +- drivers/i2c/i2c_ll_stm32_v1.c | 34 +++++----- drivers/i2c/i2c_ll_stm32_v2.c | 56 ++++++++-------- drivers/i2c/i2c_mcux.c | 2 +- drivers/i2c/i2c_qmsi_ss.c | 4 +- drivers/i2c/i2c_sam_twi.c | 6 +- drivers/i2c/i2c_sam_twihs.c | 6 +- drivers/i2s/i2s_cavs.c | 14 ++-- drivers/i2s/i2s_ll_stm32.c | 2 +- drivers/i2s/i2s_sam_ssc.c | 18 +++--- drivers/ieee802154/ieee802154_cc1200.c | 8 +-- drivers/ieee802154/ieee802154_cc2520.c | 16 ++--- drivers/ieee802154/ieee802154_kw41z.c | 24 +++---- drivers/ieee802154/ieee802154_mcr20a.c | 12 ++-- drivers/ieee802154/ieee802154_uart_pipe.c | 6 +- drivers/interrupt_controller/arcv2_irq_unit.c | 4 +- drivers/interrupt_controller/dw_ictl.c | 4 +- drivers/interrupt_controller/ioapic_intr.c | 2 +- drivers/interrupt_controller/plic.c | 6 +- drivers/interrupt_controller/shared_irq.c | 10 +-- drivers/ipm/ipm_quark_se.c | 2 +- drivers/led/lp3943.c | 8 +-- drivers/led/lp5562.c | 12 ++-- drivers/led/pca9633.c | 8 +-- drivers/led_strip/ws2812b_sw.c | 2 +- drivers/modem/wncm14a2a.c | 14 ++-- drivers/net/slip.c | 6 +- drivers/neural_net/intel_gna.c | 2 +- drivers/pci/pci_interface.c | 6 +- drivers/pinmux/pinmux_esp32.c | 2 +- drivers/pwm/pwm_led_esp32.c | 10 +-- drivers/pwm/pwm_nrf5_sw.c | 8 +-- drivers/pwm/pwm_qmsi.c | 4 +- drivers/sensor/adt7420/adt7420.c | 2 +- drivers/sensor/adxl372/adxl372.c | 6 +- drivers/sensor/adxl372/adxl372_trigger.c | 2 +- drivers/sensor/apds9960/apds9960.c | 2 +- drivers/sensor/bma280/bma280.c | 2 +- drivers/sensor/bma280/bma280_trigger.c | 2 +- drivers/sensor/bmc150_magn/bmc150_magn.c | 4 +- .../sensor/bmc150_magn/bmc150_magn_trigger.c | 4 +- drivers/sensor/bme280/bme280.c | 2 +- drivers/sensor/bmg160/bmg160.c | 2 +- drivers/sensor/bmg160/bmg160_trigger.c | 2 +- drivers/sensor/bmi160/bmi160.c | 24 +++---- drivers/sensor/bmi160/bmi160_trigger.c | 4 +- drivers/sensor/bmm150/bmm150.c | 4 +- drivers/sensor/dht/dht.c | 8 +-- drivers/sensor/fxas21002/fxas21002_trigger.c | 4 +- drivers/sensor/fxos8700/fxos8700_trigger.c | 4 +- drivers/sensor/hmc5883l/hmc5883l.c | 4 +- drivers/sensor/hp206c/hp206c.c | 2 +- drivers/sensor/hts221/hts221.c | 2 +- drivers/sensor/isl29035/isl29035.c | 2 +- drivers/sensor/lis2dh/lis2dh.c | 2 +- drivers/sensor/lis2dh/lis2dh_trigger.c | 2 +- drivers/sensor/lis2mdl/lis2mdl.c | 10 +-- drivers/sensor/lis3mdl/lis3mdl.c | 2 +- drivers/sensor/lsm6dsl/lsm6dsl_shub.c | 6 +- .../lsm9ds0_gyro/lsm9ds0_gyro_trigger.c | 4 +- drivers/sensor/lsm9ds0_mfd/lsm9ds0_mfd.c | 8 +-- drivers/sensor/max30101/max30101.c | 4 +- drivers/sensor/max44009/max44009.c | 8 +-- drivers/sensor/mcp9808/mcp9808_trigger.c | 2 +- drivers/sensor/mpu6050/mpu6050.c | 4 +- drivers/sensor/ms5837/ms5837.c | 18 +++--- drivers/sensor/sht3xd/sht3xd_trigger.c | 4 +- drivers/sensor/th02/th02.c | 4 +- drivers/sensor/tmp007/tmp007.c | 2 +- drivers/sensor/tmp112/tmp112.c | 2 +- drivers/sensor/vl53l0x/vl53l0x.c | 2 +- drivers/serial/leuart_gecko.c | 4 +- drivers/serial/uart_cc32xx.c | 6 +- drivers/serial/uart_gecko.c | 4 +- drivers/serial/uart_imx.c | 4 +- drivers/serial/uart_mcux.c | 4 +- drivers/serial/uart_mcux_lpsci.c | 4 +- drivers/serial/uart_mcux_lpuart.c | 4 +- drivers/serial/uart_msp432p4xx.c | 64 +++++++++---------- drivers/serial/uart_nrfx_uart.c | 10 +-- drivers/serial/uart_nrfx_uarte.c | 2 +- drivers/serial/uart_ns16550.c | 4 +- drivers/serial/uart_sifive.c | 2 +- drivers/serial/uart_stellaris.c | 16 ++--- drivers/serial/uart_stm32.c | 4 +- drivers/spi/spi_dw.c | 16 ++--- drivers/spi/spi_intel.c | 6 +- drivers/spi/spi_sam.c | 4 +- drivers/spi/spi_sam0.c | 2 +- drivers/timer/arcv2_timer0.c | 2 +- drivers/timer/cortex_m_systick.c | 2 +- drivers/timer/loapic_timer.c | 8 +-- drivers/timer/pulpino_timer.c | 4 +- drivers/usb/device/usb_dc_dw.c | 42 ++++++------ drivers/usb/device/usb_dc_kinetis.c | 52 +++++++-------- drivers/usb/device/usb_dc_nrfx.c | 18 +++--- drivers/usb/device/usb_dc_sam.c | 2 +- drivers/usb/device/usb_dc_sam0.c | 16 ++--- drivers/usb/device/usb_dc_stm32.c | 14 ++-- drivers/watchdog/iwdg_stm32.c | 8 +-- drivers/watchdog/wdt_esp32.c | 4 +- drivers/watchdog/wdt_qmsi.c | 2 +- drivers/watchdog/wdt_sam.c | 2 +- drivers/wifi/eswifi/eswifi_core.c | 2 +- drivers/wifi/simplelink/simplelink_support.c | 10 +-- drivers/wifi/winc1500/wifi_winc1500.c | 6 +- 172 files changed, 693 insertions(+), 693 deletions(-) diff --git a/drivers/adc/adc_context.h b/drivers/adc/adc_context.h index f7f639b3e43..50fbb6a4a55 100644 --- a/drivers/adc/adc_context.h +++ b/drivers/adc/adc_context.h @@ -185,7 +185,7 @@ static inline void adc_context_start_read(struct adc_context *ctx, ctx->status = 0; if (ctx->sequence->options) { - ctx->sampling_index = 0; + ctx->sampling_index = 0U; if (ctx->sequence->options->interval_us != 0) { atomic_set(&ctx->sampling_requested, 0); diff --git a/drivers/adc/adc_dw.c b/drivers/adc/adc_dw.c index dda51dc0c93..ab7afc37178 100644 --- a/drivers/adc/adc_dw.c +++ b/drivers/adc/adc_dw.c @@ -294,7 +294,7 @@ static int adc_dw_read_request(struct device *dev, if (seq_tbl->options) { info->seq_size = seq_tbl->options->extra_samplings + 1; } else { - info->seq_size = 1; + info->seq_size = 1U; } info->state = ADC_STATE_SAMPLING; @@ -342,7 +342,7 @@ static void adc_dw_start_conversion(struct device *dev) const struct adc_config *config = info->dev->config->config_info; const struct adc_sequence *entry = info->ctx.sequence; u32_t adc_base = config->reg_base; - u32_t ctrl, tmp_val, interval_us = 0; + u32_t ctrl, tmp_val, interval_us = 0U; info->channel_id = find_lsb_set(info->channels) - 1; diff --git a/drivers/adc/adc_intel_quark_d2000.c b/drivers/adc/adc_intel_quark_d2000.c index f1d8c7a5b07..9ab4076831d 100644 --- a/drivers/adc/adc_intel_quark_d2000.c +++ b/drivers/adc/adc_intel_quark_d2000.c @@ -267,7 +267,7 @@ static int adc_quark_d2000_read_request(struct device *dev, if (seq_tbl->options) { info->seq_size = seq_tbl->options->extra_samplings + 1; } else { - info->seq_size = 1; + info->seq_size = 1U; } if (info->seq_size > ADC_FIFO_LEN) { @@ -276,7 +276,7 @@ static int adc_quark_d2000_read_request(struct device *dev, /* check if buffer has enough size */ utmp = info->channels; - num_channels = 0; + num_channels = 0U; while (utmp) { if (utmp & BIT(0)) { num_channels++; @@ -325,8 +325,8 @@ static void adc_quark_d2000_start_conversion(struct device *dev) info->dev->config->config_info; const struct adc_sequence *entry = info->ctx.sequence; volatile adc_reg_t *adc_regs = config->reg_base; - u32_t i, val, interval_us = 0; - u32_t idx = 0, offset = 0; + u32_t i, val, interval_us = 0U; + u32_t idx = 0U, offset = 0U; info->channel_id = find_lsb_set(info->channels) - 1; @@ -338,7 +338,7 @@ static void adc_quark_d2000_start_conversion(struct device *dev) adc_regs->sample = ADC_FIFO_CLEAR; /* setup the sequence table */ - for (i = 0; i < info->seq_size; i++) { + for (i = 0U; i < info->seq_size; i++) { idx = i / 4; offset = (i % 4) * 8; diff --git a/drivers/adc/adc_mcux_adc16.c b/drivers/adc/adc_mcux_adc16.c index 019918b26fe..ed564f3873e 100644 --- a/drivers/adc/adc_mcux_adc16.c +++ b/drivers/adc/adc_mcux_adc16.c @@ -133,7 +133,7 @@ static void mcux_adc16_start_channel(struct device *dev) struct mcux_adc16_data *data = dev->driver_data; adc16_channel_config_t channel_config; - u32_t channel_group = 0; + u32_t channel_group = 0U; data->channel_id = find_lsb_set(data->channels) - 1; @@ -174,7 +174,7 @@ static void mcux_adc16_isr(void *arg) const struct mcux_adc16_config *config = dev->config->config_info; struct mcux_adc16_data *data = dev->driver_data; ADC_Type *base = config->base; - u32_t channel_group = 0; + u32_t channel_group = 0U; u16_t result; result = ADC16_GetChannelConversionValue(base, channel_group); diff --git a/drivers/adc/adc_nrfx_adc.c b/drivers/adc/adc_nrfx_adc.c index 0faadd8fe71..bfe78a2bd20 100644 --- a/drivers/adc/adc_nrfx_adc.c +++ b/drivers/adc/adc_nrfx_adc.c @@ -173,12 +173,12 @@ static int start_read(struct device *dev, const struct adc_sequence *sequence) return -EINVAL; } - active_channels = 0; + active_channels = 0U; nrfx_adc_all_channels_disable(); /* Enable the channels selected for the pointed sequence. */ - channel_id = 0; + channel_id = 0U; while (selected_channels) { if (selected_channels & BIT(0)) { /* The nrfx driver requires setting the resolution diff --git a/drivers/adc/adc_nrfx_saadc.c b/drivers/adc/adc_nrfx_saadc.c index 095ec0ca690..ab2ba8167a6 100644 --- a/drivers/adc/adc_nrfx_saadc.c +++ b/drivers/adc/adc_nrfx_saadc.c @@ -261,12 +261,12 @@ static int start_read(struct device *dev, const struct adc_sequence *sequence) return -EINVAL; } - active_channels = 0; + active_channels = 0U; /* Enable only the channels selected for the pointed sequence. * Disable all the rest. */ - channel_id = 0; + channel_id = 0U; do { if (selected_channels & BIT(channel_id)) { /* Signal an error if a selected channel has not been diff --git a/drivers/adc/adc_sam_afec.c b/drivers/adc/adc_sam_afec.c index 009c1b3fb8c..ac09e3df527 100644 --- a/drivers/adc/adc_sam_afec.c +++ b/drivers/adc/adc_sam_afec.c @@ -187,7 +187,7 @@ static int start_read(struct device *dev, const struct adc_sequence *sequence) int error = 0; u32_t channels = sequence->channels; - data->channels = 0; + data->channels = 0U; /* Signal an error if the channel selection is invalid (no channels or * a non-existing one is selected). @@ -212,8 +212,8 @@ static int start_read(struct device *dev, const struct adc_sequence *sequence) return -EINVAL; } - u8_t num_active_channels = 0; - u8_t channel = 0; + u8_t num_active_channels = 0U; + u8_t channel = 0U; while (channels > 0) { if (channels & 1) { diff --git a/drivers/aio/aio_comparator_qmsi.c b/drivers/aio/aio_comparator_qmsi.c index 690f48afb3a..da0783f8961 100644 --- a/drivers/aio/aio_comparator_qmsi.c +++ b/drivers/aio/aio_comparator_qmsi.c @@ -142,7 +142,7 @@ static int aio_qmsi_cmp_init(struct device *dev) config.cmp_en = QM_SCSS_CMP->cmp_en; /* Clear callback pointers */ - for (i = 0; i < dev_data->num_cmp; i++) { + for (i = 0U; i < dev_data->num_cmp; i++) { dev_data->cb[i].cb = NULL; dev_data->cb[i].param = NULL; } @@ -161,7 +161,7 @@ static void aio_qmsi_cmp_isr(void *data) u32_t int_status = QM_SCSS_CMP->cmp_stat_clr; - for (i = 0; i < dev_data->num_cmp; i++) { + for (i = 0U; i < dev_data->num_cmp; i++) { if (int_status & (1 << i)) { if (dev_data->cb[i].cb != NULL) { dev_data->cb[i].cb(dev_data->cb[i].param); diff --git a/drivers/audio/intel_dmic.c b/drivers/audio/intel_dmic.c index 3a9aabfef21..aae1ff1f35a 100644 --- a/drivers/audio/intel_dmic.c +++ b/drivers/audio/intel_dmic.c @@ -652,14 +652,14 @@ static int source_ipm_helper(struct pdm_chan_cfg *config, u32_t *source_mask, u8_t pdm_ix; u8_t chan_ix; enum pdm_lr lr; - u16_t pdm_lr_mask = 0; + u16_t pdm_lr_mask = 0U; int ipm = 0; /* clear outputs */ - *source_mask = 0; - *stereo_mask = 0; - *swap_mask = 0; - *controller_mask = 0; + *source_mask = 0U; + *stereo_mask = 0U; + *swap_mask = 0U; + *controller_mask = 0U; /* Loop number of PDM controllers in the configuration. If mic A * or B is enabled then a pdm controller is marked as active. Also it @@ -668,7 +668,7 @@ static int source_ipm_helper(struct pdm_chan_cfg *config, u32_t *source_mask, * swapped mono left. The function returns also in array source[] the * indice of enabled pdm controllers to be used for IPM configuration. */ - for (chan_ix = 0; chan_ix < config->req_num_chan; chan_ix++) { + for (chan_ix = 0U; chan_ix < config->req_num_chan; chan_ix++) { dmic_parse_channel_map(config->req_chan_map_lo, config->req_chan_map_hi, diff --git a/drivers/bluetooth/hci/h4.c b/drivers/bluetooth/hci/h4.c index fab419e4dc4..ae68fc6cb0a 100644 --- a/drivers/bluetooth/hci/h4.c +++ b/drivers/bluetooth/hci/h4.c @@ -155,9 +155,9 @@ static inline void copy_hdr(struct net_buf *buf) static void reset_rx(void) { rx.type = H4_NONE; - rx.remaining = 0; + rx.remaining = 0U; rx.have_hdr = false; - rx.hdr_len = 0; + rx.hdr_len = 0U; rx.discardable = false; } diff --git a/drivers/bluetooth/hci/h5.c b/drivers/bluetooth/hci/h5.c index 0630c3dbb47..646f734275a 100644 --- a/drivers/bluetooth/hci/h5.c +++ b/drivers/bluetooth/hci/h5.c @@ -711,7 +711,7 @@ static void h5_init(void) h5.link_state = UNINIT; h5.rx_state = START; - h5.tx_win = 4; + h5.tx_win = 4U; /* TX thread */ k_fifo_init(&h5.tx_queue); diff --git a/drivers/bluetooth/hci/spi.c b/drivers/bluetooth/hci/spi.c index 2db692fcff5..9dba93bf906 100644 --- a/drivers/bluetooth/hci/spi.c +++ b/drivers/bluetooth/hci/spi.c @@ -83,7 +83,7 @@ static inline void spi_dump_message(const u8_t *pre, u8_t *buf, u8_t i, c; printk("%s (%d): ", pre, size); - for (i = 0; i < size; i++) { + for (i = 0U; i < size; i++) { c = buf[i]; printk("%x ", c); if (c >= 31 && c <= 126) { @@ -283,7 +283,7 @@ static void bt_spi_rx_thread(void) u8_t header_master[5] = { SPI_READ, 0x00, 0x00, 0x00, 0x00 }; u8_t header_slave[5]; struct bt_hci_acl_hdr acl_hdr; - u8_t size = 0; + u8_t size = 0U; int ret; (void)memset(&txmsg, 0xFF, SPI_MAX_MSG_LEN); diff --git a/drivers/can/stm32_can.c b/drivers/can/stm32_can.c index d1dae4303ae..51c42df8840 100644 --- a/drivers/can/stm32_can.c +++ b/drivers/can/stm32_can.c @@ -288,7 +288,7 @@ static int can_stm32_init(struct device *dev) data->filter_usage = (1ULL << CAN_MAX_NUMBER_OF_FILTES) - 1ULL; (void)memset(data->rx_response, 0, sizeof(void *) * CONFIG_CAN_MAX_FILTER); - data->response_type = 0; + data->response_type = 0U; clock = device_get_binding(STM32_CLOCK_CONTROL_NAME); __ASSERT_NO_MSG(clock); @@ -595,8 +595,8 @@ static inline int can_stm32_set_filter(const struct can_filter *filter, CAN_TypeDef *can, int *filter_index) { - u32_t mask = 0; - u32_t id = 0; + u32_t mask = 0U; + u32_t id = 0U; int filter_nr = 0; int filter_index_tmp = CAN_NO_FREE_FILTER; int bank_nr; diff --git a/drivers/clock_control/beetle_clock_control.c b/drivers/clock_control/beetle_clock_control.c index 49c8219e824..077d92d5220 100644 --- a/drivers/clock_control/beetle_clock_control.c +++ b/drivers/clock_control/beetle_clock_control.c @@ -84,7 +84,7 @@ static inline int beetle_clock_control_on(struct device *dev, struct arm_clock_control_t *beetle_cc = (struct arm_clock_control_t *)(sub_system); - u8_t bit = 0; + u8_t bit = 0U; switch (beetle_cc->bus) { case CMSDK_AHB: @@ -108,7 +108,7 @@ static inline int beetle_clock_control_off(struct device *dev, struct arm_clock_control_t *beetle_cc = (struct arm_clock_control_t *)(sub_system); - u8_t bit = 0; + u8_t bit = 0U; switch (beetle_cc->bus) { case CMSDK_AHB: @@ -154,7 +154,7 @@ static const struct clock_control_driver_api beetle_clock_control_api = { #ifdef CONFIG_CLOCK_CONTROL_BEETLE_ENABLE_PLL static u32_t beetle_round_freq(u32_t mainclk) { - u32_t nc_mainclk = 0; + u32_t nc_mainclk = 0U; /* * Verify that the frequency is in the supported range otherwise @@ -175,7 +175,7 @@ static u32_t beetle_round_freq(u32_t mainclk) static u32_t beetle_get_prescaler(u32_t mainclk) { - u32_t pre_mainclk = 0; + u32_t pre_mainclk = 0U; /* * Verify that the frequency is in the supported range otherwise diff --git a/drivers/clock_control/nrf5_power_clock.c b/drivers/clock_control/nrf5_power_clock.c index c89de0e0636..24cbfb4ec7c 100644 --- a/drivers/clock_control/nrf5_power_clock.c +++ b/drivers/clock_control/nrf5_power_clock.c @@ -47,7 +47,7 @@ static int _m16src_start(struct device *dev, clock_control_subsys_t sub_system) return -EAGAIN; } - m16src_grd = 1; + m16src_grd = 1U; irq_unlock(imask); @@ -87,7 +87,7 @@ static int _m16src_start(struct device *dev, clock_control_subsys_t sub_system) } /* release resource guard */ - m16src_grd = 0; + m16src_grd = 0U; hf_already_started: /* rollover should not happen as start and stop shall be @@ -130,7 +130,7 @@ static int _m16src_stop(struct device *dev, clock_control_subsys_t sub_system) return -EAGAIN; } - m16src_grd = 1; + m16src_grd = 1U; irq_unlock(imask); @@ -139,7 +139,7 @@ static int _m16src_stop(struct device *dev, clock_control_subsys_t sub_system) nrf_clock_task_trigger(NRF_CLOCK_TASK_HFCLKSTOP); /* release resource guard */ - m16src_grd = 0; + m16src_grd = 0U; return 0; } @@ -172,7 +172,7 @@ static int _k32src_start(struct device *dev, clock_control_subsys_t sub_system) goto lf_already_started; } - k32src_initialized = 1; + k32src_initialized = 1U; irq_unlock(imask); @@ -348,7 +348,7 @@ static void _power_clock_isr(void *arg) /* Start HF Clock if LF RC is used. */ if ((NRF_CLOCK->LFCLKSRCCOPY & CLOCK_LFCLKSRCCOPY_SRC_Msk) == CLOCK_LFCLKSRCCOPY_SRC_RC) { - ctto = 1; + ctto = 1U; } } } diff --git a/drivers/console/ipm_console_receiver.c b/drivers/console/ipm_console_receiver.c index 571da6121ee..e2056b7a127 100644 --- a/drivers/console/ipm_console_receiver.c +++ b/drivers/console/ipm_console_receiver.c @@ -30,7 +30,7 @@ static void ipm_console_thread(void *arg1, void *arg2, void *arg3) driver_data = d->driver_data; config_info = d->config->config_info; ARG_UNUSED(arg2); - size32 = 0; + size32 = 0U; pos = 0; while (1) { @@ -42,7 +42,7 @@ static void ipm_console_thread(void *arg1, void *arg2, void *arg3) if (ret) { /* Shouldn't ever happen... */ printk("ipm console ring buffer error: %d\n", ret); - size32 = 0; + size32 = 0U; continue; } diff --git a/drivers/console/telnet_console.c b/drivers/console/telnet_console.c index fe55307a1a5..6140b2964ae 100644 --- a/drivers/console/telnet_console.c +++ b/drivers/console/telnet_console.c @@ -100,11 +100,11 @@ static void telnet_rb_init(void) { int i; - telnet_rb.line_in = 0; - telnet_rb.line_out = 0; + telnet_rb.line_in = 0U; + telnet_rb.line_out = 0U; for (i = 0; i < TELNET_LINES; i++) { - telnet_rb.l_bufs[i].len = 0; + telnet_rb.l_bufs[i].len = 0U; } } @@ -141,10 +141,10 @@ static void telnet_rb_switch(void) telnet_rb.line_in++; if (telnet_rb.line_in == TELNET_LINES) { - telnet_rb.line_in = 0; + telnet_rb.line_in = 0U; } - telnet_rb.l_bufs[telnet_rb.line_in].len = 0; + telnet_rb.l_bufs[telnet_rb.line_in].len = 0U; /* Unfortunately, we don't have enough line buffer, * so we eat the next to be sent. @@ -152,7 +152,7 @@ static void telnet_rb_switch(void) if (telnet_rb.line_in == telnet_rb.line_out) { telnet_rb.line_out++; if (telnet_rb.line_out == TELNET_LINES) { - telnet_rb.line_out = 0; + telnet_rb.line_out = 0U; } } @@ -166,7 +166,7 @@ static inline struct line_buf *telnet_rb_get_line_out(void) telnet_rb.line_out++; if (telnet_rb.line_out == TELNET_LINES) { - telnet_rb.line_out = 0; + telnet_rb.line_out = 0U; } if (!telnet_rb.l_bufs[out].len) { @@ -240,7 +240,7 @@ static inline bool telnet_send(void) K_FOREVER); /* We reinitialize the line buffer */ - lb->len = 0; + lb->len = 0U; if (net_context_send(out_pkt, telnet_sent_cb, K_NO_WAIT, NULL, NULL) || diff --git a/drivers/console/uart_console.c b/drivers/console/uart_console.c index c056c3f809c..bdc6866b230 100644 --- a/drivers/console/uart_console.c +++ b/drivers/console/uart_console.c @@ -258,13 +258,13 @@ static void handle_ansi(u8_t byte, char *line) { if (atomic_test_and_clear_bit(&esc_state, ESC_ANSI_FIRST)) { if (!isdigit(byte)) { - ansi_val = 1; + ansi_val = 1U; goto ansi_cmd; } atomic_set_bit(&esc_state, ESC_ANSI_VAL); ansi_val = byte - '0'; - ansi_val_2 = 0; + ansi_val_2 = 0U; return; } @@ -317,7 +317,7 @@ ansi_cmd: cursor_backward(cur); end += cur; - cur = 0; + cur = 0U; break; case ANSI_END: if (!end) { @@ -326,7 +326,7 @@ ansi_cmd: cursor_forward(end); cur += end; - end = 0; + end = 0U; break; case ANSI_DEL: if (!end) { @@ -441,8 +441,8 @@ static bool handle_mcumgr(struct console_input *cmd, uint8_t byte) clear_mcumgr(); cmd = NULL; - cur = 0; - end = 0; + cur = 0U; + end = 0U; } return true; @@ -529,8 +529,8 @@ void uart_console_isr(struct device *unused) cmd->line[cur + end] = '\0'; uart_poll_out(uart_console_dev, '\r'); uart_poll_out(uart_console_dev, '\n'); - cur = 0; - end = 0; + cur = 0U; + end = 0U; k_fifo_put(lines_queue, cmd); cmd = NULL; break; @@ -617,7 +617,7 @@ static int uart_console_init(struct device *arg) #if defined(CONFIG_USB_UART_CONSOLE) && defined(CONFIG_USB_UART_DTR_WAIT) while (1) { - u32_t dtr = 0; + u32_t dtr = 0U; uart_line_ctrl_get(uart_console_dev, LINE_CTRL_DTR, &dtr); if (dtr) { diff --git a/drivers/console/websocket_console.c b/drivers/console/websocket_console.c index 34aa307dffb..c4009f34143 100644 --- a/drivers/console/websocket_console.c +++ b/drivers/console/websocket_console.c @@ -101,11 +101,11 @@ static void ws_rb_init(void) { int i; - ws_rb.line_in = 0; - ws_rb.line_out = 0; + ws_rb.line_in = 0U; + ws_rb.line_out = 0U; for (i = 0; i < WS_CONSOLE_LINES; i++) { - ws_rb.l_bufs[i].len = 0; + ws_rb.l_bufs[i].len = 0U; } } @@ -127,10 +127,10 @@ static void ws_rb_switch(void) ws_rb.line_in++; if (ws_rb.line_in == WS_CONSOLE_LINES) { - ws_rb.line_in = 0; + ws_rb.line_in = 0U; } - ws_rb.l_bufs[ws_rb.line_in].len = 0; + ws_rb.l_bufs[ws_rb.line_in].len = 0U; /* Unfortunately, we don't have enough line buffer, * so we eat the next to be sent. @@ -138,7 +138,7 @@ static void ws_rb_switch(void) if (ws_rb.line_in == ws_rb.line_out) { ws_rb.line_out++; if (ws_rb.line_out == WS_CONSOLE_LINES) { - ws_rb.line_out = 0; + ws_rb.line_out = 0U; } } @@ -152,7 +152,7 @@ static inline struct line_buf *ws_rb_get_line_out(void) ws_rb.line_out++; if (ws_rb.line_out == WS_CONSOLE_LINES) { - ws_rb.line_out = 0; + ws_rb.line_out = 0U; } if (!ws_rb.l_bufs[out].len) { @@ -274,7 +274,7 @@ static bool ws_console_send(struct http_ctx *console) NULL, NULL); /* We reinitialize the line buffer */ - lb->len = 0; + lb->len = 0U; } return true; diff --git a/drivers/counter/counter_dtmr_cmsdk_apb.c b/drivers/counter/counter_dtmr_cmsdk_apb.c index 1185c8c9251..045d149a2ab 100644 --- a/drivers/counter/counter_dtmr_cmsdk_apb.c +++ b/drivers/counter/counter_dtmr_cmsdk_apb.c @@ -56,7 +56,7 @@ static u32_t counter_dtmr_cmsdk_apb_read(struct device *dev) dev->config->config_info; /* Return Counter Value */ - u32_t value = 0; + u32_t value = 0U; value = DUALTIMER_MAX_RELOAD - cfg->dtimer->timer1value; diff --git a/drivers/counter/counter_tmr_cmsdk_apb.c b/drivers/counter/counter_tmr_cmsdk_apb.c index 02deaca2e95..12056bc5899 100644 --- a/drivers/counter/counter_tmr_cmsdk_apb.c +++ b/drivers/counter/counter_tmr_cmsdk_apb.c @@ -56,7 +56,7 @@ static u32_t counter_tmr_cmsdk_apb_read(struct device *dev) dev->config->config_info; /* Return Counter Value */ - u32_t value = 0; + u32_t value = 0U; value = TIMER_MAX_RELOAD - cfg->timer->value; diff --git a/drivers/counter/timer_dtmr_cmsdk_apb.c b/drivers/counter/timer_dtmr_cmsdk_apb.c index 310de69c40e..4b3ab52822b 100644 --- a/drivers/counter/timer_dtmr_cmsdk_apb.c +++ b/drivers/counter/timer_dtmr_cmsdk_apb.c @@ -80,7 +80,7 @@ static u32_t timer_dtmr_cmsdk_apb_read(struct device *dev) struct timer_dtmr_cmsdk_apb_dev_data *data = dev->driver_data; /* Return Timer Value */ - u32_t value = 0; + u32_t value = 0U; value = data->load - cfg->dtimer->timer1value; diff --git a/drivers/counter/timer_tmr_cmsdk_apb.c b/drivers/counter/timer_tmr_cmsdk_apb.c index 16cef514877..a7414ea0d04 100644 --- a/drivers/counter/timer_tmr_cmsdk_apb.c +++ b/drivers/counter/timer_tmr_cmsdk_apb.c @@ -80,7 +80,7 @@ static u32_t timer_tmr_cmsdk_apb_read(struct device *dev) struct timer_tmr_cmsdk_apb_dev_data *data = dev->driver_data; /* Return Counter Value */ - u32_t value = 0; + u32_t value = 0U; value = data->load - cfg->timer->value; diff --git a/drivers/crypto/crypto_ataes132a_priv.h b/drivers/crypto/crypto_ataes132a_priv.h index 6f352ca215c..a5cf931fd34 100644 --- a/drivers/crypto/crypto_ataes132a_priv.h +++ b/drivers/crypto/crypto_ataes132a_priv.h @@ -119,7 +119,7 @@ void ataes132a_atmel_crc(u8_t *input, u8_t length, u16_t double_carry; u8_t higher_crc_bit; - for (i = 0, crc = 0; i < length; i++) { + for (i = 0, crc = 0U; i < length; i++) { for (j = 7; j >= 0; j--) { bit = !!(input[i] & BIT(j)); higher_crc_bit = crc >> 15; diff --git a/drivers/display/display_ili9340.c b/drivers/display/display_ili9340.c index 3ba46e27462..ba6e7e9eafd 100644 --- a/drivers/display/display_ili9340.c +++ b/drivers/display/display_ili9340.c @@ -134,11 +134,11 @@ static int ili9340_write(const struct device *dev, const u16_t x, ili9340_set_mem_area(data, x, y, desc->width, desc->height); if (desc->pitch > desc->width) { - write_h = 1; + write_h = 1U; nbr_of_writes = desc->height; } else { write_h = desc->height; - nbr_of_writes = 1; + nbr_of_writes = 1U; } ili9340_transmit(data, ILI9340_CMD_MEM_WRITE, @@ -148,7 +148,7 @@ static int ili9340_write(const struct device *dev, const u16_t x, tx_bufs.count = 1; write_data_start += (3 * desc->pitch); - for (write_cnt = 1; write_cnt < nbr_of_writes; ++write_cnt) { + for (write_cnt = 1U; write_cnt < nbr_of_writes; ++write_cnt) { tx_buf.buf = (void *)write_data_start; tx_buf.len = 3 * desc->width * write_h; spi_write(data->spi_dev, &data->spi_config, &tx_bufs); diff --git a/drivers/display/grove_lcd_rgb.c b/drivers/display/grove_lcd_rgb.c index 6a7a3b822be..bbdcd671dcf 100644 --- a/drivers/display/grove_lcd_rgb.c +++ b/drivers/display/grove_lcd_rgb.c @@ -252,9 +252,9 @@ int glcd_initialize(struct device *port) LOG_DBG("initialize called"); - dev->input_set = 0; - dev->display_switch = 0; - dev->function = 0; + dev->input_set = 0U; + dev->display_switch = 0U; + dev->function = 0U; /* * First set up the device driver... diff --git a/drivers/display/mb_display.c b/drivers/display/mb_display.c index d3a655f6b4b..532eb21c9b0 100644 --- a/drivers/display/mb_display.c +++ b/drivers/display/mb_display.c @@ -146,7 +146,7 @@ static void start_image(struct mb_display *disp, const struct mb_image *img) int row, col; for (row = 0; row < DISPLAY_ROWS; row++) { - disp->row[row] = 0; + disp->row[row] = 0U; for (col = 0; col < DISPLAY_COLS; col++) { if (GET_PIXEL(img, map[row][col].x, map[row][col].y)) { @@ -158,7 +158,7 @@ static void start_image(struct mb_display *disp, const struct mb_image *img) disp->row[row] |= BIT(LED_ROW1_GPIO_PIN + row); } - disp->cur = 0; + disp->cur = 0U; if (disp->duration == K_FOREVER) { disp->expiry = K_FOREVER; @@ -196,9 +196,9 @@ static void reset_display(struct mb_display *disp) k_timer_stop(&disp->timer); disp->str = NULL; - disp->cur_img = 0; + disp->cur_img = 0U; disp->img = NULL; - disp->img_count = 0; + disp->img_count = 0U; disp->scroll = SCROLL_OFF; } @@ -269,7 +269,7 @@ static void update_scroll(struct mb_display *disp) start_image(disp, &img); } else { if (disp->first) { - disp->first = 0; + disp->first = 0U; } else { disp->cur_img++; } @@ -280,8 +280,8 @@ static void update_scroll(struct mb_display *disp) return; } - disp->cur_img = 0; - disp->first = 1; + disp->cur_img = 0U; + disp->first = 1U; } disp->scroll = SCROLL_START; @@ -299,7 +299,7 @@ static void update_image(struct mb_display *disp) return; } - disp->cur_img = 0; + disp->cur_img = 0U; } start_image(disp, current_img(disp)); @@ -343,8 +343,8 @@ static void start_scroll(struct mb_display *disp, s32_t duration) } disp->scroll = SCROLL_START; - disp->first = 1; - disp->cur_img = 0; + disp->first = 1U; + disp->cur_img = 0U; start_image(disp, get_font(' ')); } @@ -366,11 +366,11 @@ void mb_display_image(struct mb_display *disp, u32_t mode, s32_t duration, __ASSERT(img && img_count > 0, "Invalid parameters"); - disp->text = 0; + disp->text = 0U; disp->img_count = img_count; disp->img = img; - disp->img_sep = 0; - disp->cur_img = 0; + disp->img_sep = 0U; + disp->cur_img = 0U; disp->loop = !!(mode & MB_DISPLAY_FLAG_LOOP); switch (mode & MODE_MASK) { @@ -407,9 +407,9 @@ void mb_display_print(struct mb_display *disp, u32_t mode, } disp->str = disp->str_buf; - disp->text = 1; - disp->img_sep = 1; - disp->cur_img = 0; + disp->text = 1U; + disp->img_sep = 1U; + disp->cur_img = 0U; disp->loop = !!(mode & MB_DISPLAY_FLAG_LOOP); switch (mode & MODE_MASK) { diff --git a/drivers/display/ssd1673.c b/drivers/display/ssd1673.c index 8f45e9b9348..b5348277663 100644 --- a/drivers/display/ssd1673.c +++ b/drivers/display/ssd1673.c @@ -88,7 +88,7 @@ static inline int ssd1673_write_cmd(struct ssd1673_data *driver, static inline void ssd1673_busy_wait(struct ssd1673_data *driver) { - u32_t val = 0; + u32_t val = 0U; gpio_pin_read(driver->busy, DT_SSD1673_BUSY_PIN, &val); while (val) { @@ -181,7 +181,7 @@ static int ssd1673_update_display(const struct device *dev, bool initial) } if (initial) { - driver->numof_part_cycles = 0; + driver->numof_part_cycles = 0U; driver->last_lut = SSD1673_LAST_LUT_INITIAL; if (ssd1673_write_cmd(driver, SSD1673_CMD_UPDATE_LUT, ssd1673_lut_initial, @@ -409,7 +409,7 @@ static int ssd1673_controller_init(struct device *dev) ssd1673_busy_wait(driver); tmp[0] = (SSD1673_RAM_YRES - 1); - tmp[1] = 0; + tmp[1] = 0U; if (ssd1673_write_cmd(driver, SSD1673_CMD_GDO_CTRL, tmp, 2)) { return -1; } @@ -441,9 +441,9 @@ static int ssd1673_controller_init(struct device *dev) } ssd1673_set_orientation(driver); - driver->numof_part_cycles = 0; + driver->numof_part_cycles = 0U; driver->last_lut = SSD1673_LAST_LUT_INITIAL; - driver->contrast = 0; + driver->contrast = 0U; return 0; } diff --git a/drivers/dma/dma_cavs.c b/drivers/dma/dma_cavs.c index 96059c376d5..bfcb4820164 100644 --- a/drivers/dma/dma_cavs.c +++ b/drivers/dma/dma_cavs.c @@ -58,9 +58,9 @@ static void dw_dma_isr(void *arg) struct dw_dma_dev_data *const dev_data = DEV_DATA(dev); struct dma_chan_data *chan_data; - u32_t status_tfr = 0; - u32_t status_block = 0; - u32_t status_err = 0; + u32_t status_tfr = 0U; + u32_t status_block = 0U; + u32_t status_err = 0U; u32_t status_intr; u32_t channel; diff --git a/drivers/dma/dma_qmsi.c b/drivers/dma/dma_qmsi.c index 11ccaa638fb..ef1a377c68b 100644 --- a/drivers/dma/dma_qmsi.c +++ b/drivers/dma/dma_qmsi.c @@ -133,7 +133,7 @@ static int dma_qmsi_chan_config(struct device *dev, u32_t channel, struct dma_qmsi_driver_data *data = dev->driver_data; qm_dma_transfer_t qmsi_transfer_cfg = { 0 }; qm_dma_channel_config_t qmsi_cfg = { 0 }; - u32_t temp = 0; + u32_t temp = 0U; int ret = 0; if (config->block_count != 1) { diff --git a/drivers/dma/dma_sam_xdmac.c b/drivers/dma/dma_sam_xdmac.c index a906e4c7f75..d8fa0174093 100644 --- a/drivers/dma/dma_sam_xdmac.c +++ b/drivers/dma/dma_sam_xdmac.c @@ -243,9 +243,9 @@ static int sam_xdmac_config(struct device *dev, u32_t channel, | XDMAC_CC_SIF_AHB_IF1 | XDMAC_CC_DIF_AHB_IF1 | XDMAC_CC_PERID(cfg->dma_slot); - channel_cfg.ds_msp = 0; - channel_cfg.sus = 0; - channel_cfg.dus = 0; + channel_cfg.ds_msp = 0U; + channel_cfg.sus = 0U; + channel_cfg.dus = 0U; channel_cfg.cie = (cfg->complete_callback_en ? XDMAC_CIE_BIE : XDMAC_CIE_LIE) | (cfg->error_callback_en ? XDMAC_INT_ERR : 0); diff --git a/drivers/entropy/entropy_mcux_rnga.c b/drivers/entropy/entropy_mcux_rnga.c index 22038455a80..a9f509a5958 100644 --- a/drivers/entropy/entropy_mcux_rnga.c +++ b/drivers/entropy/entropy_mcux_rnga.c @@ -14,7 +14,7 @@ static u8_t entropy_mcux_rnga_get_uint8(void) { u32_t random; - u8_t output = 0; + u8_t output = 0U; int i; RNGA_SetMode(RNG, kRNGA_ModeNormal); diff --git a/drivers/entropy/entropy_nrf5.c b/drivers/entropy/entropy_nrf5.c index 96d2258a487..ded1452318e 100644 --- a/drivers/entropy/entropy_nrf5.c +++ b/drivers/entropy/entropy_nrf5.c @@ -192,9 +192,9 @@ static int rng_pool_put(struct rng_pool *rngp, u8_t byte) static void rng_pool_init(struct rng_pool *rngp, u16_t size, u8_t threshold) { - rngp->first_alloc = 0; - rngp->first_read = 0; - rngp->last = 0; + rngp->first_alloc = 0U; + rngp->first_read = 0U; + rngp->last = 0U; rngp->mask = size - 1; rngp->threshold = threshold; } diff --git a/drivers/ethernet/eth_dw.c b/drivers/ethernet/eth_dw.c index 3620daee846..3bff1a5df87 100644 --- a/drivers/ethernet/eth_dw.c +++ b/drivers/ethernet/eth_dw.c @@ -106,7 +106,7 @@ static void eth_rx(struct device *dev) release_desc: /* Return ownership of the RX descriptor to the device. */ - context->rx_desc.own = 1; + context->rx_desc.own = 1U; /* Request that the device check for an available RX descriptor, since * ownership of the descriptor was just transferred to the device. @@ -146,7 +146,7 @@ static void eth_tx_data(struct eth_runtime *context, u8_t *data, u16_t len) eth_write(context->base_addr, REG_ADDR_TX_DESC_LIST, (u32_t)&context->tx_desc); - context->tx_desc.own = 1; + context->tx_desc.own = 1U; /* Request that the device check for an available TX descriptor, since * ownership of the descriptor was just transferred to the device. @@ -257,27 +257,27 @@ static int eth_initialize_internal(struct net_if *iface) /* Initialize receive descriptor. */ - context->rx_desc.rdes0 = 0; - context->rx_desc.rdes1 = 0; + context->rx_desc.rdes0 = 0U; + context->rx_desc.rdes1 = 0U; context->rx_desc.buf1_ptr = (u8_t *)context->rx_buf; - context->rx_desc.first_desc = 1; - context->rx_desc.last_desc = 1; - context->rx_desc.own = 1; + context->rx_desc.first_desc = 1U; + context->rx_desc.last_desc = 1U; + context->rx_desc.own = 1U; context->rx_desc.rx_buf1_sz = sizeof(context->rx_buf); - context->rx_desc.rx_end_of_ring = 1; + context->rx_desc.rx_end_of_ring = 1U; /* Install receive descriptor. */ eth_write(base_addr, REG_ADDR_RX_DESC_LIST, (u32_t)&context->rx_desc); /* Initialize transmit descriptor. */ - context->tx_desc.tdes0 = 0; - context->tx_desc.tdes1 = 0; + context->tx_desc.tdes0 = 0U; + context->tx_desc.tdes1 = 0U; context->tx_desc.buf1_ptr = NULL; - context->tx_desc.tx_buf1_sz = 0; - context->tx_desc.first_seg_in_frm = 1; - context->tx_desc.last_seg_in_frm = 1; - context->tx_desc.tx_end_of_ring = 1; + context->tx_desc.tx_buf1_sz = 0U; + context->tx_desc.first_seg_in_frm = 1U; + context->tx_desc.last_seg_in_frm = 1U; + context->tx_desc.tx_end_of_ring = 1U; /* Install transmit descriptor. */ eth_write(context->base_addr, REG_ADDR_TX_DESC_LIST, diff --git a/drivers/ethernet/eth_enc28j60.c b/drivers/ethernet/eth_enc28j60.c index 41a338c42c6..d2637ecffd8 100644 --- a/drivers/ethernet/eth_enc28j60.c +++ b/drivers/ethernet/eth_enc28j60.c @@ -115,10 +115,10 @@ static void eth_enc28j60_read_reg(struct device *dev, u16_t reg_addr, .buffers = &rx_buf, .count = 1 }; - u8_t rx_size = 2; + u8_t rx_size = 2U; if (reg_addr & 0xF000) { - rx_size = 3; + rx_size = 3U; } rx_buf.len = rx_size; @@ -130,7 +130,7 @@ static void eth_enc28j60_read_reg(struct device *dev, u16_t reg_addr, *value = buf[rx_size - 1]; } else { LOG_DBG("Failure while reading register 0x%04x", reg_addr); - *value = 0; + *value = 0U; } } @@ -513,12 +513,12 @@ static int eth_enc28j60_rx(struct device *dev) do { struct net_buf *pkt_buf = NULL; struct net_buf *last_buf = NULL; - u16_t frm_len = 0; + u16_t frm_len = 0U; u8_t info[RSV_SIZE]; struct net_pkt *pkt; u16_t next_packet; - u8_t rdptl = 0; - u8_t rdpth = 0; + u8_t rdptl = 0U; + u8_t rdpth = 0U; /* remove read fifo address to packet header address */ eth_enc28j60_set_bank(dev, ENC28J60_REG_ERXRDPTL); diff --git a/drivers/ethernet/eth_mcux.c b/drivers/ethernet/eth_mcux.c index 4704bb5128b..97dbbe0f306 100644 --- a/drivers/ethernet/eth_mcux.c +++ b/drivers/ethernet/eth_mcux.c @@ -182,7 +182,7 @@ static inline struct net_if *get_iface(struct eth_context *ctx, u16_t vlan_tag) static void eth_mcux_phy_enter_reset(struct eth_context *context) { - const u32_t phy_addr = 0; + const u32_t phy_addr = 0U; /* Reset the PHY. */ ENET_StartSMIWrite(ENET, phy_addr, PHY_BASICCONTROL_REG, @@ -193,7 +193,7 @@ static void eth_mcux_phy_enter_reset(struct eth_context *context) static void eth_mcux_phy_start(struct eth_context *context) { - const u32_t phy_addr = 0; + const u32_t phy_addr = 0U; #ifdef CONFIG_ETH_MCUX_PHY_EXTRA_DEBUG LOG_DBG("phy_state=%s", phy_state_name(context->phy_state)); #endif @@ -259,7 +259,7 @@ static void eth_mcux_phy_event(struct eth_context *context) bool link_up; phy_duplex_t phy_duplex = kPHY_FullDuplex; phy_speed_t phy_speed = kPHY_Speed100M; - const u32_t phy_addr = 0; + const u32_t phy_addr = 0U; #ifdef CONFIG_ETH_MCUX_PHY_EXTRA_DEBUG LOG_DBG("phy_state=%s", phy_state_name(context->phy_state)); @@ -532,7 +532,7 @@ static void eth_rx(struct device *iface) struct net_buf *prev_buf; struct net_pkt *pkt; const u8_t *src; - u32_t frame_length = 0; + u32_t frame_length = 0U; status_t status; unsigned int imask; u16_t vlan_tag = NET_VLAN_TAG_UNSPEC; diff --git a/drivers/ethernet/eth_sam_gmac.c b/drivers/ethernet/eth_sam_gmac.c index 9d4ad8e3821..879cb45a945 100644 --- a/drivers/ethernet/eth_sam_gmac.c +++ b/drivers/ethernet/eth_sam_gmac.c @@ -195,8 +195,8 @@ static inline void gmac_desc_append_w1(struct gmac_desc *desc, u32_t value) */ static void ring_buf_reset(struct ring_buf *rb) { - rb->head = 0; - rb->tail = 0; + rb->head = 0U; + rb->tail = 0U; } /* @@ -270,8 +270,8 @@ static int rx_descriptors_init(Gmac *gmac, struct gmac_queue *queue) __ASSERT_NO_MSG(rx_frag_list->buf); - rx_desc_list->tail = 0; - rx_frag_list->tail = 0; + rx_desc_list->tail = 0U; + rx_frag_list->tail = 0U; for (int i = 0; i < rx_desc_list->len; i++) { rx_buf = net_pkt_get_reserve_rx_data(0, K_NO_WAIT); @@ -308,8 +308,8 @@ static void tx_descriptors_init(Gmac *gmac, struct gmac_queue *queue) { struct gmac_desc_list *tx_desc_list = &queue->tx_desc_list; - tx_desc_list->head = 0; - tx_desc_list->tail = 0; + tx_desc_list->head = 0U; + tx_desc_list->tail = 0U; for (int i = 0; i < tx_desc_list->len; i++) { gmac_desc_set_w0(&tx_desc_list->buf[i], 0); @@ -602,8 +602,8 @@ static void rx_error_handler(Gmac *gmac, struct gmac_queue *queue) /* Stop reception */ gmac->GMAC_NCR &= ~GMAC_NCR_RXEN; - queue->rx_desc_list.tail = 0; - queue->rx_frag_list.tail = 0; + queue->rx_desc_list.tail = 0U; + queue->rx_frag_list.tail = 0U; for (int i = 0; i < queue->rx_desc_list.len; i++) { gmac_desc_set_w1(&queue->rx_desc_list.buf[i], 0); @@ -829,8 +829,8 @@ static void gmac_setup_ptp_clock_divisors(Gmac *gmac) } nit = min_cycles - 1; - cns = 0; - acns = 0; + cns = 0U; + acns = 0U; while ((cns + 2) * nit < min_period) { cns++; @@ -985,9 +985,9 @@ static int nonpriority_queue_init(Gmac *gmac, struct gmac_queue *queue) /* Setup RX/TX completion and error interrupts */ gmac->GMAC_IER = GMAC_INT_EN_FLAGS; - queue->err_rx_frames_dropped = 0; - queue->err_rx_flushed_count = 0; - queue->err_tx_flushed_count = 0; + queue->err_rx_frames_dropped = 0U; + queue->err_rx_flushed_count = 0U; + queue->err_tx_flushed_count = 0U; LOG_INF("Queue %d activated", queue->que_idx); @@ -1035,9 +1035,9 @@ static int priority_queue_init(Gmac *gmac, struct gmac_queue *queue) /* Enable RX/TX completion and error interrupts */ gmac->GMAC_IERPQ[queue_index] = GMAC_INTPQ_EN_FLAGS; - queue->err_rx_frames_dropped = 0; - queue->err_rx_flushed_count = 0; - queue->err_tx_flushed_count = 0; + queue->err_rx_frames_dropped = 0U; + queue->err_rx_flushed_count = 0U; + queue->err_tx_flushed_count = 0U; return 0; } @@ -1096,7 +1096,7 @@ static struct net_pkt *frame_get(struct gmac_queue *queue) struct net_buf *last_frag = NULL; u8_t *frag_data; u32_t frag_len; - u32_t frame_len = 0; + u32_t frame_len = 0U; u16_t tail; u8_t wrap; diff --git a/drivers/ethernet/phy_sam_gmac.c b/drivers/ethernet/phy_sam_gmac.c index e0a7b14ab53..111008a671b 100644 --- a/drivers/ethernet/phy_sam_gmac.c +++ b/drivers/ethernet/phy_sam_gmac.c @@ -39,7 +39,7 @@ static void mdio_bus_disable(Gmac *gmac) /* Wait PHY operation complete. */ static int mdio_bus_wait(Gmac *gmac) { - u32_t retries = 100; /* will wait up to 1 s */ + u32_t retries = 100U; /* will wait up to 1 s */ while (!(gmac->GMAC_NSR & GMAC_NSR_IDLE)) { if (retries-- == 0) { @@ -109,7 +109,7 @@ static int phy_write(const struct phy_sam_gmac_dev *phy, u8_t reg_addr, static int phy_soft_reset(const struct phy_sam_gmac_dev *phy) { u32_t phy_reg; - u32_t retries = 12; + u32_t retries = 12U; int retval; /* Issue a soft reset */ diff --git a/drivers/flash/flash_sam0.c b/drivers/flash/flash_sam0.c index 39b9476a968..c382f9160ff 100644 --- a/drivers/flash/flash_sam0.c +++ b/drivers/flash/flash_sam0.c @@ -145,7 +145,7 @@ static int flash_sam0_write_page(struct device *dev, off_t offset, static int flash_sam0_erase_row(struct device *dev, off_t offset) { - *FLASH_MEM(offset) = 0; + *FLASH_MEM(offset) = 0U; NVMCTRL->CTRLA.reg = NVMCTRL_CTRLA_CMD_ER | NVMCTRL_CTRLA_CMDEX_KEY; return flash_sam0_check_status(offset); @@ -318,7 +318,7 @@ static int flash_sam0_write_protection(struct device *dev, bool enable) for (offset = 0; offset < CONFIG_FLASH_SIZE * 1024; offset += LOCK_REGION_SIZE) { - *FLASH_MEM(offset) = 0; + *FLASH_MEM(offset) = 0U; if (enable) { NVMCTRL->CTRLA.reg = NVMCTRL_CTRLA_CMD_LR | diff --git a/drivers/flash/flash_stm32f3x.c b/drivers/flash/flash_stm32f3x.c index 15a9bbcaea2..54cb556b0d0 100644 --- a/drivers/flash/flash_stm32f3x.c +++ b/drivers/flash/flash_stm32f3x.c @@ -12,10 +12,10 @@ static int flash_stm32_erase(struct device *dev, off_t offset, size_t size) { - u32_t first_page_addr = 0; - u32_t last_page_addr = 0; + u32_t first_page_addr = 0U; + u32_t last_page_addr = 0U; u16_t no_of_pages = size / CONFIG_FLASH_PAGE_SIZE; - u16_t page_index = 0; + u16_t page_index = 0U; /* Check offset and size alignment. */ if (((offset % CONFIG_FLASH_PAGE_SIZE) != 0) || @@ -67,15 +67,15 @@ static int flash_stm32_read(struct device *dev, off_t offset, static int flash_stm32_write(struct device *dev, off_t offset, const void *data, size_t len) { - u16_t halfword = 0; + u16_t halfword = 0U; u32_t address = CONFIG_FLASH_BASE_ADDRESS + offset; - u8_t remainder = 0; + u8_t remainder = 0U; if ((len % 2) != 0) { - remainder = 1; + remainder = 1U; } len = len / 2; diff --git a/drivers/flash/soc_flash_nios2_qspi.c b/drivers/flash/soc_flash_nios2_qspi.c index a6a5e326a84..56213eaa71f 100644 --- a/drivers/flash/soc_flash_nios2_qspi.c +++ b/drivers/flash/soc_flash_nios2_qspi.c @@ -92,9 +92,9 @@ static int flash_nios2_qspi_erase(struct device *dev, off_t offset, size_t len) break; } - block_offset = 0; /* block offset in byte addressing */ - offset_in_block = 0; /* offset into current sector to erase */ - length_to_erase = 0; /* length to erase in current sector */ + block_offset = 0U; /* block offset in byte addressing */ + offset_in_block = 0U; /* offset into current sector to erase */ + length_to_erase = 0U; /* length to erase in current sector */ /* calculate current sector/block offset in byte addressing */ block_offset = erase_offset & ~(qspi_dev->sector_size - 1); @@ -161,7 +161,7 @@ static int flash_nios2_qspi_write_block(struct device *dev, int block_offset, { struct flash_nios2_qspi_config *flash_cfg = dev->driver_data; alt_qspi_controller2_dev *qspi_dev = &flash_cfg->qspi_dev; - u32_t buffer_offset = 0; /* offset into data buffer to get write data */ + u32_t buffer_offset = 0U; /* offset into data buffer to get write data */ u32_t remaining_length = len; /* length left to write */ u32_t write_offset = mem_offset; /* offset into flash to write too */ u32_t word_to_write, padding, bytes_to_copy; @@ -173,7 +173,7 @@ static int flash_nios2_qspi_write_block(struct device *dev, int block_offset, word_to_write = NIOS2_QSPI_BLANK_WORD; /* bytes to pad the next word that is written */ - padding = 0; + padding = 0U; /* number of bytes from source to copy */ bytes_to_copy = NIOS2_WRITE_BLOCK_SIZE; @@ -260,7 +260,7 @@ static int flash_nios2_qspi_write(struct device *dev, off_t offset, alt_qspi_controller2_dev *qspi_dev = &flash_cfg->qspi_dev; u32_t block_offset, offset_in_block, length_to_write; u32_t write_offset = offset; /* address of next byte to write */ - u32_t buffer_offset = 0; /* offset into source buffer */ + u32_t buffer_offset = 0U; /* offset into source buffer */ u32_t remaining_length = len; /* length of data left to be written */ s32_t rc = 0, i; @@ -284,9 +284,9 @@ static int flash_nios2_qspi_write(struct device *dev, off_t offset, break; } - block_offset = 0; /* block offset in byte addressing */ - offset_in_block = 0; /* offset into current sector to write */ - length_to_write = 0; /* length to write to current sector */ + block_offset = 0U; /* block offset in byte addressing */ + offset_in_block = 0U; /* offset into current sector to write */ + length_to_write = 0U; /* length to write to current sector */ /* calculate current sector/block offset in byte addressing */ block_offset = write_offset & ~(qspi_dev->sector_size - 1); @@ -324,7 +324,7 @@ static int flash_nios2_qspi_read(struct device *dev, off_t offset, { struct flash_nios2_qspi_config *flash_cfg = dev->driver_data; alt_qspi_controller2_dev *qspi_dev = &flash_cfg->qspi_dev; - u32_t buffer_offset = 0; /* offset into data buffer to get read data */ + u32_t buffer_offset = 0U; /* offset into data buffer to get read data */ u32_t remaining_length = len; /* length left to read */ u32_t read_offset = offset; /* offset into flash to read from */ u32_t word_to_read, bytes_to_copy; diff --git a/drivers/flash/soc_flash_nrf.c b/drivers/flash/soc_flash_nrf.c index d14da9d2109..38924731266 100644 --- a/drivers/flash/soc_flash_nrf.c +++ b/drivers/flash/soc_flash_nrf.c @@ -407,9 +407,9 @@ static int erase_op(void *context) struct flash_context *e_ctx = context; #if defined(CONFIG_SOC_FLASH_NRF_RADIO_SYNC) - u32_t ticks_begin = 0; + u32_t ticks_begin = 0U; u32_t ticks_diff; - u32_t i = 0; + u32_t i = 0U; if (e_ctx->enable_time_limit) { ticks_begin = ticker_ticks_now_get(); @@ -464,9 +464,9 @@ static int write_op(void *context) u32_t count; #if defined(CONFIG_SOC_FLASH_NRF_RADIO_SYNC) - u32_t ticks_begin = 0; + u32_t ticks_begin = 0U; u32_t ticks_diff; - u32_t i = 1; + u32_t i = 1U; if (w_ctx->enable_time_limit) { ticks_begin = ticker_ticks_now_get(); diff --git a/drivers/flash/soc_flash_qmsi.c b/drivers/flash/soc_flash_qmsi.c index 11b7bdcd729..8c846c802f6 100644 --- a/drivers/flash/soc_flash_qmsi.c +++ b/drivers/flash/soc_flash_qmsi.c @@ -115,7 +115,7 @@ static int flash_qmsi_write(struct device *dev, off_t addr, { qm_flash_t flash = QM_FLASH_0; qm_flash_region_t reg; - u32_t data_word = 0, offset = 0, f_addr = 0; + u32_t data_word = 0U, offset = 0U, f_addr = 0U; if ((!is_aligned_32(len)) || (!is_aligned_32(addr))) { return -EINVAL; @@ -173,7 +173,7 @@ static int flash_qmsi_erase(struct device *dev, off_t addr, size_t size) { qm_flash_t flash = QM_FLASH_0; qm_flash_region_t reg; - u32_t page = 0; + u32_t page = 0U; /* starting address needs to be a 2KB aligned address */ if (addr & QM_FLASH_ADDRESS_MASK) { diff --git a/drivers/flash/spi_flash_w25qxxdv.c b/drivers/flash/spi_flash_w25qxxdv.c index 215f485365a..ede77dcbf2b 100644 --- a/drivers/flash/spi_flash_w25qxxdv.c +++ b/drivers/flash/spi_flash_w25qxxdv.c @@ -184,7 +184,7 @@ static int spi_flash_wb_write(struct device *dev, off_t offset, static int spi_flash_wb_write_protection_set(struct device *dev, bool enable) { struct spi_flash_data *const driver_data = dev->driver_data; - u8_t reg = 0; + u8_t reg = 0U; int ret; SYNC_LOCK(); diff --git a/drivers/gpio/gpio_cc2650.c b/drivers/gpio/gpio_cc2650.c index a0f1536ed37..ddb097b3d49 100644 --- a/drivers/gpio/gpio_cc2650.c +++ b/drivers/gpio/gpio_cc2650.c @@ -227,7 +227,7 @@ static int gpio_cc2650_config(struct device *port, int access_op, return gpio_cc2650_config_pin(pin, flags); } - const u32_t nb_pins = 32; + const u32_t nb_pins = 32U; for (u8_t i = 0; i < nb_pins; ++i) { if (pin & 0x1 && @@ -257,7 +257,7 @@ static int gpio_cc2650_write(struct device *port, int access_op, if (access_op == GPIO_ACCESS_BY_PIN) { gpio_cc2650_write_pin(pin, value); } else { - const u32_t nb_pins = 32; + const u32_t nb_pins = 32U; for (u32_t i = 0; i < nb_pins; ++i) { if (pin & 0x1) { @@ -279,7 +279,7 @@ static int gpio_cc2650_read(struct device *port, int access_op, gpio_cc2650_read_pin(pin, value); *value >>= pin; } else { - const u32_t nb_pins = 32; + const u32_t nb_pins = 32U; for (u32_t i = 0; i < nb_pins; ++i) { if (pin & 0x1) { diff --git a/drivers/gpio/gpio_cc32xx.c b/drivers/gpio/gpio_cc32xx.c index 9aa37d5ab4e..2dd5b3a60f5 100644 --- a/drivers/gpio/gpio_cc32xx.c +++ b/drivers/gpio/gpio_cc32xx.c @@ -158,7 +158,7 @@ static int gpio_cc32xx_disable_callback(struct device *dev, if (access_op == GPIO_ACCESS_BY_PIN) { data->pin_callback_enables &= ~(1 << pin); } else { - data->pin_callback_enables = 0; + data->pin_callback_enables = 0U; } return 0; diff --git a/drivers/gpio/gpio_gecko.c b/drivers/gpio/gpio_gecko.c index 513de73c5e1..473979c91f4 100644 --- a/drivers/gpio/gpio_gecko.c +++ b/drivers/gpio/gpio_gecko.c @@ -74,7 +74,7 @@ static int gpio_gecko_configure(struct device *dev, GPIO_P_TypeDef *gpio_base = config->gpio_base; GPIO_Port_TypeDef gpio_index = config->gpio_index; GPIO_Mode_TypeDef mode; - unsigned int out = 0; + unsigned int out = 0U; /* Check for an invalid pin configuration */ if ((flags & GPIO_INT) && (flags & GPIO_DIR_OUT)) { @@ -94,7 +94,7 @@ static int gpio_gecko_configure(struct device *dev, if ((flags & GPIO_DIR_MASK) == GPIO_DIR_IN) { if ((flags & GPIO_PUD_MASK) == GPIO_PUD_PULL_UP) { mode = gpioModeInputPull; - out = 1; /* pull-up*/ + out = 1U; /* pull-up*/ } else if ((flags & GPIO_PUD_MASK) == GPIO_PUD_PULL_DOWN) { mode = gpioModeInputPull; /* out = 0 means pull-down*/ diff --git a/drivers/gpio/gpio_imx.c b/drivers/gpio/gpio_imx.c index c6e698de91e..ad0359ff1cd 100644 --- a/drivers/gpio/gpio_imx.c +++ b/drivers/gpio/gpio_imx.c @@ -65,7 +65,7 @@ static int imx_gpio_configure(struct device *dev, GPIO_Init(config->base, &pin_config); GPIO_SetIntEdgeSelect(config->base, pin, double_edge); } else { /* GPIO_ACCESS_BY_PORT */ - for (i = 0; i < 32; i++) { + for (i = 0U; i < 32; i++) { pin_config.pin = i; GPIO_Init(config->base, &pin_config); GPIO_SetIntEdgeSelect(config->base, i, double_edge); @@ -126,7 +126,7 @@ static int imx_gpio_enable_callback(struct device *dev, GPIO_SetPinIntMode(config->base, pin, true); } else { data->pin_callback_enables = 0xFFFFFFFF; - for (i = 0; i < 32; i++) { + for (i = 0U; i < 32; i++) { GPIO_SetPinIntMode(config->base, i, true); } } @@ -145,10 +145,10 @@ static int imx_gpio_disable_callback(struct device *dev, GPIO_SetPinIntMode(config->base, pin, false); data->pin_callback_enables &= ~BIT(pin); } else { - for (i = 0; i < 32; i++) { + for (i = 0U; i < 32; i++) { GPIO_SetPinIntMode(config->base, i, false); } - data->pin_callback_enables = 0; + data->pin_callback_enables = 0U; } return 0; diff --git a/drivers/gpio/gpio_mcux.c b/drivers/gpio/gpio_mcux.c index 48b9e990f2c..5a79801e41d 100644 --- a/drivers/gpio/gpio_mcux.c +++ b/drivers/gpio/gpio_mcux.c @@ -34,8 +34,8 @@ static int gpio_mcux_configure(struct device *dev, GPIO_Type *gpio_base = config->gpio_base; PORT_Type *port_base = config->port_base; port_interrupt_t port_interrupt = 0; - u32_t mask = 0; - u32_t pcr = 0; + u32_t mask = 0U; + u32_t pcr = 0U; u8_t i; /* Check for an invalid pin configuration */ @@ -116,7 +116,7 @@ static int gpio_mcux_configure(struct device *dev, if (access_op == GPIO_ACCESS_BY_PIN) { port_base->PCR[pin] = (port_base->PCR[pin] & ~mask) | pcr; } else { /* GPIO_ACCESS_BY_PORT */ - for (i = 0; i < ARRAY_SIZE(port_base->PCR); i++) { + for (i = 0U; i < ARRAY_SIZE(port_base->PCR); i++) { port_base->PCR[i] = (port_base->PCR[pin] & ~mask) | pcr; } } @@ -201,7 +201,7 @@ static int gpio_mcux_disable_callback(struct device *dev, if (access_op == GPIO_ACCESS_BY_PIN) { data->pin_callback_enables &= ~BIT(pin); } else { - data->pin_callback_enables = 0; + data->pin_callback_enables = 0U; } return 0; diff --git a/drivers/gpio/gpio_mcux_igpio.c b/drivers/gpio/gpio_mcux_igpio.c index 4bc37b9a0d5..250d4090d2c 100644 --- a/drivers/gpio/gpio_mcux_igpio.c +++ b/drivers/gpio/gpio_mcux_igpio.c @@ -66,7 +66,7 @@ static int mcux_igpio_configure(struct device *dev, if (access_op == GPIO_ACCESS_BY_PIN) { GPIO_PinInit(config->base, pin, &pin_config); } else { /* GPIO_ACCESS_BY_PORT */ - for (i = 0; i < 32; i++) { + for (i = 0U; i < 32; i++) { GPIO_PinInit(config->base, i, &pin_config); } } @@ -140,7 +140,7 @@ static int mcux_igpio_disable_callback(struct device *dev, data->pin_callback_enables &= ~BIT(pin); } else { GPIO_PortDisableInterrupts(config->base, 0); - data->pin_callback_enables = 0; + data->pin_callback_enables = 0U; } return 0; diff --git a/drivers/gpio/gpio_nrfx.c b/drivers/gpio/gpio_nrfx.c index 1c54604bc28..4a776cba351 100644 --- a/drivers/gpio/gpio_nrfx.c +++ b/drivers/gpio/gpio_nrfx.c @@ -181,8 +181,8 @@ static int gpio_nrfx_config(struct device *port, int access_op, : NRF_GPIO_PIN_INPUT_DISCONNECT; if (access_op == GPIO_ACCESS_BY_PORT) { - from_pin = 0; - to_pin = 31; + from_pin = 0U; + to_pin = 31U; } else { from_pin = pin; to_pin = pin; @@ -270,8 +270,8 @@ static int gpio_nrfx_pin_manage_callback(struct device *port, u8_t to_pin; if (access_op == GPIO_ACCESS_BY_PORT) { - from_pin = 0; - to_pin = 31; + from_pin = 0U; + to_pin = 31U; } else { from_pin = pin; to_pin = pin; diff --git a/drivers/gpio/gpio_pcal9535a.c b/drivers/gpio/gpio_pcal9535a.c index 9e607e73f9f..b655855b297 100644 --- a/drivers/gpio/gpio_pcal9535a.c +++ b/drivers/gpio/gpio_pcal9535a.c @@ -154,7 +154,7 @@ static int _setup_pin_dir(struct device *dev, int access_op, (struct gpio_pcal9535a_drv_data * const)dev->driver_data; union gpio_pcal9535a_port_data *port = &drv_data->reg_cache.dir; u16_t bit_mask; - u16_t new_value = 0; + u16_t new_value = 0U; int ret; switch (access_op) { @@ -206,7 +206,7 @@ static int _setup_pin_pullupdown(struct device *dev, int access_op, (struct gpio_pcal9535a_drv_data * const)dev->driver_data; union gpio_pcal9535a_port_data *port; u16_t bit_mask; - u16_t new_value = 0; + u16_t new_value = 0U; int ret; /* If disabling pull up/down, there is no need to set the selection @@ -299,7 +299,7 @@ static int _setup_pin_polarity(struct device *dev, int access_op, (struct gpio_pcal9535a_drv_data * const)dev->driver_data; union gpio_pcal9535a_port_data *port = &drv_data->reg_cache.pol_inv; u16_t bit_mask; - u16_t new_value = 0; + u16_t new_value = 0U; int ret; switch (access_op) { diff --git a/drivers/gpio/gpio_qmsi.c b/drivers/gpio/gpio_qmsi.c index e9cd333113b..46822c52c4d 100644 --- a/drivers/gpio/gpio_qmsi.c +++ b/drivers/gpio/gpio_qmsi.c @@ -336,7 +336,7 @@ static inline int gpio_qmsi_disable_callback(struct device *port, if (access_op == GPIO_ACCESS_BY_PIN) { context->pin_callbacks &= ~BIT(pin); } else { - context->pin_callbacks = 0; + context->pin_callbacks = 0U; } if (IS_ENABLED(CONFIG_GPIO_QMSI_API_REENTRANCY)) { diff --git a/drivers/gpio/gpio_qmsi_ss.c b/drivers/gpio/gpio_qmsi_ss.c index d912380ac0b..0ce5c5bab17 100644 --- a/drivers/gpio/gpio_qmsi_ss.c +++ b/drivers/gpio/gpio_qmsi_ss.c @@ -329,7 +329,7 @@ static inline int ss_gpio_qmsi_disable_callback(struct device *port, if (access_op == GPIO_ACCESS_BY_PIN) { context->pin_callbacks &= ~BIT(pin); } else { - context->pin_callbacks = 0; + context->pin_callbacks = 0U; } if (IS_ENABLED(CONFIG_GPIO_QMSI_API_REENTRANCY)) { diff --git a/drivers/gpio/gpio_sch.c b/drivers/gpio/gpio_sch.c index 439e900421b..292e8b66224 100644 --- a/drivers/gpio/gpio_sch.c +++ b/drivers/gpio/gpio_sch.c @@ -89,17 +89,17 @@ static void _gpio_pin_config(struct device *dev, u32_t pin, int flags) { const struct gpio_sch_config *info = dev->config->config_info; struct gpio_sch_data *gpio = dev->driver_data; - u8_t active_high = 0; - u8_t active_low = 0; + u8_t active_high = 0U; + u8_t active_low = 0U; _set_bit_gen(info->regs, pin, 1); _set_bit_gio(info->regs, pin, !(flags & GPIO_DIR_MASK)); if (flags & GPIO_INT) { if (flags & GPIO_INT_ACTIVE_HIGH) { - active_high = 1; + active_high = 1U; } else { - active_low = 1; + active_low = 1U; } LOG_DBG("Setting up pin %d to active_high %d and " @@ -217,7 +217,7 @@ static void _gpio_sch_manage_callback(struct device *dev) if (!sys_slist_is_empty(&gpio->callbacks) && gpio->cb_enabled) { if (!gpio->poll) { LOG_DBG("Starting SCH GPIO polling thread"); - gpio->poll = 1; + gpio->poll = 1U; k_thread_create(&gpio->polling_thread, gpio->polling_stack, GPIO_SCH_POLLING_STACK_SIZE, @@ -226,7 +226,7 @@ static void _gpio_sch_manage_callback(struct device *dev) K_PRIO_COOP(1), 0, 0); } } else { - gpio->poll = 0; + gpio->poll = 0U; } } @@ -290,7 +290,7 @@ static int gpio_sch_disable_callback(struct device *dev, _write_gtpe(0, info->regs); _write_gtne(0, info->regs); - gpio->cb_enabled = 0; + gpio->cb_enabled = 0U; } _gpio_sch_manage_callback(dev); diff --git a/drivers/gpio/gpio_shell.c b/drivers/gpio/gpio_shell.c index e3826398b63..3c7ad79a9b8 100644 --- a/drivers/gpio/gpio_shell.c +++ b/drivers/gpio/gpio_shell.c @@ -48,7 +48,7 @@ static const struct args_number args_no = { static int cmd_gpio_conf(const struct shell *shell, size_t argc, char **argv) { - u8_t index = 0; + u8_t index = 0U; int type = GPIO_DIR_OUT; struct device *dev; @@ -85,8 +85,8 @@ static int cmd_gpio_get(const struct shell *shell, size_t argc, char **argv) { struct device *dev; - u8_t index = 0; - u32_t value = 0; + u8_t index = 0U; + u32_t value = 0U; int rc; if (argc == args_no.get && isdigit((unsigned char)argv[args_indx.index][0])) { @@ -120,8 +120,8 @@ static int cmd_gpio_set(const struct shell *shell, size_t argc, char **argv) { struct device *dev; - u8_t index = 0; - u8_t value = 0; + u8_t index = 0U; + u8_t value = 0U; if (argc == args_no.set && isdigit((unsigned char)argv[args_indx.index][0]) && diff --git a/drivers/gpio/gpio_sifive.c b/drivers/gpio/gpio_sifive.c index 21b103f1d58..0afcf32b41f 100644 --- a/drivers/gpio/gpio_sifive.c +++ b/drivers/gpio/gpio_sifive.c @@ -339,14 +339,14 @@ static int gpio_sifive_init(struct device *dev) const struct gpio_sifive_config *cfg = DEV_GPIO_CFG(dev); /* Ensure that all gpio registers are reset to 0 initially */ - gpio->in_en = 0; - gpio->out_en = 0; - gpio->pue = 0; - gpio->rise_ie = 0; - gpio->fall_ie = 0; - gpio->high_ie = 0; - gpio->low_ie = 0; - gpio->invert = 0; + gpio->in_en = 0U; + gpio->out_en = 0U; + gpio->pue = 0U; + gpio->rise_ie = 0U; + gpio->fall_ie = 0U; + gpio->high_ie = 0U; + gpio->low_ie = 0U; + gpio->invert = 0U; /* Setup IRQ handler for each gpio pin */ cfg->gpio_cfg_func(); diff --git a/drivers/i2c/i2c_atmel_sam3.c b/drivers/i2c/i2c_atmel_sam3.c index 251df61e433..eafd1957b97 100644 --- a/drivers/i2c/i2c_atmel_sam3.c +++ b/drivers/i2c/i2c_atmel_sam3.c @@ -131,13 +131,13 @@ static u32_t clk_div_calc(struct device *dev) switch (I2C_SPEED_GET(dev_data->dev_config)) { case I2C_SPEED_STANDARD: i2c_clk = 100000 * 2; - i2c_h_min_time = 4000; - i2c_l_min_time = 4700; + i2c_h_min_time = 4000U; + i2c_l_min_time = 4700U; break; case I2C_SPEED_FAST: i2c_clk = 400000 * 2; - i2c_h_min_time = 600; - i2c_l_min_time = 1300; + i2c_h_min_time = 600U; + i2c_l_min_time = 1300U; break; default: /* Return 0 as error */ @@ -159,7 +159,7 @@ static u32_t clk_div_calc(struct device *dev) cldiv_min = (i2c_l_min_time * mck / 1000) - 4 + 1; chdiv_min = (i2c_h_min_time * mck / 1000) - 4 + 1; - ckdiv = 0; + ckdiv = 0U; while (cldiv > 255) { ckdiv++; @@ -195,7 +195,7 @@ static int i2c_sam3_runtime_configure(struct device *dev, u32_t config) u32_t clk; dev_data->dev_config = config; - reg = 0; + reg = 0U; /* Calculate clock dividers */ clk = clk_div_calc(dev); @@ -288,7 +288,7 @@ static inline void transfer_setup(struct device *dev, u16_t slave_address) /* 7-bit slave addressing */ mmr = TWI_MMR_DADR(slave_address); - iadr = 0; + iadr = 0U; } cfg->regs->TWI_MMR = mmr; @@ -361,7 +361,7 @@ static inline int msg_read(struct device *dev) * reading from slave. If the previous message is also read, * there is no need to set the START bit again. */ - ctrl_reg = 0; + ctrl_reg = 0U; if (dev_data->xfr_flags & I2C_MSG_RESTART) { ctrl_reg = TWI_CR_START; } @@ -390,7 +390,7 @@ static inline int msg_read(struct device *dev) if (dev_data->xfr_len > 1) { last_len = dev_data->xfr_len - 1; } else { - last_len = 1; + last_len = 1U; /* Set STOP bit for last byte. * The extra check here is to prevent setting @@ -453,7 +453,7 @@ static int i2c_sam3_transfer(struct device *dev, struct i2c_sam3_dev_data * const dev_data = dev->driver_data; struct i2c_msg *cur_msg = msgs; u8_t msg_left = num_msgs; - u32_t pflags = 0; + u32_t pflags = 0U; int ret = 0; int xfr_ret; diff --git a/drivers/i2c/i2c_bitbang.c b/drivers/i2c/i2c_bitbang.c index 17ec818db59..553c3d8dbda 100644 --- a/drivers/i2c/i2c_bitbang.c +++ b/drivers/i2c/i2c_bitbang.c @@ -172,7 +172,7 @@ static bool i2c_write_byte(struct i2c_bitbang *context, u8_t byte) static u8_t i2c_read_byte(struct i2c_bitbang *context) { - unsigned int byte = 1; + unsigned int byte = 1U; do { byte <<= 1; diff --git a/drivers/i2c/i2c_cc32xx.c b/drivers/i2c/i2c_cc32xx.c index 38656a8c34a..37c59c45e09 100644 --- a/drivers/i2c/i2c_cc32xx.c +++ b/drivers/i2c/i2c_cc32xx.c @@ -94,10 +94,10 @@ static int i2c_cc32xx_configure(struct device *dev, u32_t dev_config_raw) switch (I2C_SPEED_GET(dev_config_raw)) { case I2C_SPEED_STANDARD: - bitrate_id = 0; + bitrate_id = 0U; break; case I2C_SPEED_FAST: - bitrate_id = 1; + bitrate_id = 1U; break; default: return -EINVAL; diff --git a/drivers/i2c/i2c_dw.c b/drivers/i2c/i2c_dw.c index 51c632e9985..fec17c4fea5 100644 --- a/drivers/i2c/i2c_dw.c +++ b/drivers/i2c/i2c_dw.c @@ -51,7 +51,7 @@ static inline void _i2c_dw_data_ask(struct device *dev) /* No more bytes to request, so command queue is no longer needed */ if (dw->request_bytes == 0) { - regs->ic_intr_mask.bits.tx_empty = 0; + regs->ic_intr_mask.bits.tx_empty = 0U; return; } @@ -126,14 +126,14 @@ static void _i2c_dw_data_read(struct device *dev) static int _i2c_dw_data_send(struct device *dev) { struct i2c_dw_dev_config * const dw = dev->driver_data; - u32_t data = 0; + u32_t data = 0U; volatile struct i2c_dw_registers * const regs = (struct i2c_dw_registers *)dw->base_address; /* Nothing to send anymore, mask the interrupt */ if (dw->xfr_len == 0) { - regs->ic_intr_mask.bits.tx_empty = 0; + regs->ic_intr_mask.bits.tx_empty = 0U; dw->state &= ~I2C_DW_CMD_SEND; @@ -282,13 +282,13 @@ static int _i2c_dw_setup(struct device *dev, u16_t slave_address) volatile struct i2c_dw_registers * const regs = (struct i2c_dw_registers *)dw->base_address; - ic_con.raw = 0; + ic_con.raw = 0U; /* Disable the device controller to be able set TAR */ - regs->ic_enable.bits.enable = 0; + regs->ic_enable.bits.enable = 0U; /* Disable interrupts */ - regs->ic_intr_mask.raw = 0; + regs->ic_intr_mask.raw = 0U; /* Clear interrupts */ value = regs->ic_clr_intr; @@ -300,19 +300,19 @@ static int _i2c_dw_setup(struct device *dev, u16_t slave_address) * to both 0 or both 1 */ LOG_DBG("I2C: host configured as Master Device"); - ic_con.bits.master_mode = 1; - ic_con.bits.slave_disable = 1; + ic_con.bits.master_mode = 1U; + ic_con.bits.slave_disable = 1U; } else { return -EINVAL; } - ic_con.bits.restart_en = 1; + ic_con.bits.restart_en = 1U; /* Set addressing mode - (initialization = 7 bit) */ if (I2C_ADDR_10_BITS & dw->app_config) { LOG_DBG("I2C: using 10-bit address"); - ic_con.bits.addr_master_10bit = 1; - ic_con.bits.addr_slave_10bit = 1; + ic_con.bits.addr_master_10bit = 1U; + ic_con.bits.addr_slave_10bit = 1U; } /* Setup the clock frequency and speed mode */ @@ -361,7 +361,7 @@ static int _i2c_dw_setup(struct device *dev, u16_t slave_address) * * TODO: extend the threshold for multi-byte RX. */ - regs->ic_rx_tl = 0; + regs->ic_rx_tl = 0U; /* Set TX fifo threshold level. * TX_EMPTY interrupt is triggered only when the @@ -371,7 +371,7 @@ static int _i2c_dw_setup(struct device *dev, u16_t slave_address) * cause some pauses during transfers, but this keeps * the device from interrupting often. */ - regs->ic_tx_tl = 0; + regs->ic_tx_tl = 0U; if (regs->ic_con.bits.master_mode) { /* Set address of target slave */ @@ -388,9 +388,9 @@ static int _i2c_dw_setup(struct device *dev, u16_t slave_address) */ if (I2C_MODE_MASTER & dw->app_config) { if (I2C_ADDR_10_BITS & dw->app_config) { - regs->ic_tar.bits.ic_10bitaddr_master = 1; + regs->ic_tar.bits.ic_10bitaddr_master = 1U; } else { - regs->ic_tar.bits.ic_10bitaddr_master = 0; + regs->ic_tar.bits.ic_10bitaddr_master = 0U; } } @@ -429,7 +429,7 @@ static int i2c_dw_transfer(struct device *dev, } /* Enable controller */ - regs->ic_enable.bits.enable = 1; + regs->ic_enable.bits.enable = 1U; /* * While waiting at device_sync_sem, kernel can switch to idle @@ -452,7 +452,7 @@ static int i2c_dw_transfer(struct device *dev, dw->xfr_buf = cur_msg->buf; dw->xfr_len = cur_msg->len; dw->xfr_flags = cur_msg->flags; - dw->rx_pending = 0; + dw->rx_pending = 0U; /* Need to RESTART if changing transfer direction */ if ((pflags & I2C_MSG_RW_MASK) @@ -469,7 +469,7 @@ static int i2c_dw_transfer(struct device *dev, if ((dw->xfr_flags & I2C_MSG_RW_MASK) == I2C_MSG_WRITE) { dw->state |= I2C_DW_CMD_SEND; - dw->request_bytes = 0; + dw->request_bytes = 0U; } else { dw->state |= I2C_DW_CMD_RECV; dw->request_bytes = dw->xfr_len; @@ -513,8 +513,8 @@ static int i2c_dw_transfer(struct device *dev, static int i2c_dw_runtime_configure(struct device *dev, u32_t config) { struct i2c_dw_dev_config * const dw = dev->driver_data; - u32_t value = 0; - u32_t rc = 0; + u32_t value = 0U; + u32_t rc = 0U; volatile struct i2c_dw_registers * const regs = (struct i2c_dw_registers *)dw->base_address; diff --git a/drivers/i2c/i2c_esp32.c b/drivers/i2c/i2c_esp32.c index 3d7bc896002..7b42303346a 100644 --- a/drivers/i2c/i2c_esp32.c +++ b/drivers/i2c/i2c_esp32.c @@ -170,7 +170,7 @@ static int i2c_esp32_configure(struct device *dev, u32_t dev_config) const struct i2c_esp32_config *config = dev->config->config_info; struct i2c_esp32_data *data = dev->driver_data; unsigned int key = irq_lock(); - u32_t v = 0; + u32_t v = 0U; int ret; ret = i2c_esp32_configure_pins(config->pins.scl, @@ -344,7 +344,7 @@ i2c_esp32_write_addr(struct device *dev, { const struct i2c_esp32_config *config = dev->config->config_info; struct i2c_esp32_data *data = dev->driver_data; - u32_t addr_len = 1; + u32_t addr_len = 1U; i2c_esp32_reset_fifo(config); @@ -437,7 +437,7 @@ static int i2c_esp32_read_msg(struct device *dev, u16_t addr, return ret; } - for (i = 0; i < to_read; i++) { + for (i = 0U; i < to_read; i++) { u32_t v = sys_read32(I2C_DATA_APB_REG(config->index)); *msg.buf++ = v & I2C_FIFO_RDATA; @@ -469,7 +469,7 @@ static int i2c_esp32_write_msg(struct device *dev, u16_t addr, int ret; /* Copy data to TX fifo */ - for (i = 0; i < to_send; i++) { + for (i = 0U; i < to_send; i++) { sys_write32(*msg.buf++, I2C_DATA_APB_REG(config->index)); } @@ -514,7 +514,7 @@ static int i2c_esp32_transfer(struct device *dev, struct i2c_msg *msgs, addr &= BIT_MASK(data->dev_config & I2C_ADDR_10_BITS ? 10 : 7); addr <<= 1; - for (i = 0; i < num_msgs; i++) { + for (i = 0U; i < num_msgs; i++) { if ((msgs[i].flags & I2C_MSG_RW_MASK) == I2C_MSG_WRITE) { ret = i2c_esp32_write_msg(dev, addr, msgs[i]); } else { diff --git a/drivers/i2c/i2c_gecko.c b/drivers/i2c/i2c_gecko.c index 3f182bb87e1..d7c21aa03bb 100644 --- a/drivers/i2c/i2c_gecko.c +++ b/drivers/i2c/i2c_gecko.c @@ -95,7 +95,7 @@ static int i2c_gecko_transfer(struct device *dev, struct i2c_msg *msgs, struct i2c_gecko_data *data = DEV_DATA(dev); I2C_TransferSeq_TypeDef seq; I2C_TransferReturn_TypeDef ret = -EIO; - u32_t timeout = 300000; + u32_t timeout = 300000U; if (!num_msgs) { return 0; diff --git a/drivers/i2c/i2c_gpio.c b/drivers/i2c/i2c_gpio.c index 3b41019b4d4..9ae23b763ef 100644 --- a/drivers/i2c/i2c_gpio.c +++ b/drivers/i2c/i2c_gpio.c @@ -58,7 +58,7 @@ static void i2c_gpio_set_sda(void *io_context, int state) static int i2c_gpio_get_sda(void *io_context) { struct i2c_gpio_context *context = io_context; - u32_t state = 1; /* Default high as that would be a NACK */ + u32_t state = 1U; /* Default high as that would be a NACK */ gpio_pin_read(context->gpio, context->sda_pin, &state); return state; diff --git a/drivers/i2c/i2c_handlers.c b/drivers/i2c/i2c_handlers.c index dc0f27740a4..d4316222794 100644 --- a/drivers/i2c/i2c_handlers.c +++ b/drivers/i2c/i2c_handlers.c @@ -29,7 +29,7 @@ static u32_t copy_msgs_and_transfer(struct device *dev, /* Validate the buffers in each message struct. Read options require * that the target buffer be writable */ - for (i = 0; i < num_msgs; i++) { + for (i = 0U; i < num_msgs; i++) { Z_OOPS(Z_SYSCALL_MEMORY(copy[i].buf, copy[i].len, copy[i].flags & I2C_MSG_READ)); } diff --git a/drivers/i2c/i2c_imx.c b/drivers/i2c/i2c_imx.c index ba19ea7276d..2c12951c3de 100644 --- a/drivers/i2c/i2c_imx.c +++ b/drivers/i2c/i2c_imx.c @@ -135,9 +135,9 @@ static int i2c_imx_configure(struct device *dev, u32_t dev_config_raw) /* Initialize I2C state structure content. */ transfer->txBuff = 0; transfer->rxBuff = 0; - transfer->cmdSize = 0; - transfer->txSize = 0; - transfer->rxSize = 0; + transfer->cmdSize = 0U; + transfer->txSize = 0U; + transfer->rxSize = 0U; transfer->isBusy = false; transfer->currentDir = i2cDirectionReceive; transfer->currentMode = i2cModeSlave; diff --git a/drivers/i2c/i2c_ll_stm32.c b/drivers/i2c/i2c_ll_stm32.c index 821260de6b0..7806692635f 100644 --- a/drivers/i2c/i2c_ll_stm32.c +++ b/drivers/i2c/i2c_ll_stm32.c @@ -25,7 +25,7 @@ int i2c_stm32_runtime_configure(struct device *dev, u32_t config) const struct i2c_stm32_config *cfg = DEV_CFG(dev); struct i2c_stm32_data *data = DEV_DATA(dev); I2C_TypeDef *i2c = cfg->i2c; - u32_t clock = 0; + u32_t clock = 0U; #if defined(CONFIG_SOC_SERIES_STM32F3X) || defined(CONFIG_SOC_SERIES_STM32F0X) LL_RCC_ClocksTypeDef rcc_clocks; diff --git a/drivers/i2c/i2c_ll_stm32_v1.c b/drivers/i2c/i2c_ll_stm32_v1.c index 085af54cd9d..b29312e1df7 100644 --- a/drivers/i2c/i2c_ll_stm32_v1.c +++ b/drivers/i2c/i2c_ll_stm32_v1.c @@ -36,10 +36,10 @@ static inline void handle_sb(I2C_TypeDef *i2c, struct i2c_stm32_data *data) u8_t header = slave | HEADER; if (data->current.is_restart == 0) { - data->current.is_restart = 1; + data->current.is_restart = 1U; } else { header |= I2C_REQUEST_READ; - data->current.is_restart = 0; + data->current.is_restart = 0U; } LL_I2C_TransmitData8(i2c, header); @@ -57,7 +57,7 @@ static inline void handle_addr(I2C_TypeDef *i2c, struct i2c_stm32_data *data) { if (I2C_ADDR_10_BITS & data->dev_config) { if (!data->current.is_write && data->current.is_restart) { - data->current.is_restart = 0; + data->current.is_restart = 0U; LL_I2C_ClearFlag_ADDR(i2c); LL_I2C_GenerateStartCondition(i2c); @@ -139,7 +139,7 @@ static inline void handle_btf(I2C_TypeDef *i2c, struct i2c_stm32_data *data) if (data->current.is_write) { handle_txe(i2c, data); } else { - u32_t counter = 0; + u32_t counter = 0U; switch (data->current.len) { case 2: @@ -151,7 +151,7 @@ static inline void handle_btf(I2C_TypeDef *i2c, struct i2c_stm32_data *data) LL_I2C_GenerateStopCondition(i2c); } - for (counter = 2; counter > 0; counter--) { + for (counter = 2U; counter > 0; counter--) { data->current.len--; *data->current.buf = LL_I2C_ReceiveData8(i2c); data->current.buf++; @@ -201,12 +201,12 @@ void stm32_i2c_error_isr(void *arg) if (LL_I2C_IsActiveFlag_AF(i2c)) { LL_I2C_ClearFlag_AF(i2c); LL_I2C_GenerateStopCondition(i2c); - data->current.is_nack = 1; + data->current.is_nack = 1U; k_sem_give(&data->device_sync_sem); return; } - data->current.is_err = 1; + data->current.is_err = 1U; k_sem_give(&data->device_sync_sem); } @@ -223,10 +223,10 @@ s32_t stm32_i2c_msg_write(struct device *dev, struct i2c_msg *msg, data->current.len = msg->len; data->current.buf = msg->buf; data->current.flags = msg->flags; - data->current.is_restart = 0; - data->current.is_write = 1; - data->current.is_nack = 0; - data->current.is_err = 0; + data->current.is_restart = 0U; + data->current.is_write = 1U; + data->current.is_nack = 0U; + data->current.is_err = 0U; data->slave_address = saddr; LL_I2C_EnableIT_EVT(i2c); @@ -249,8 +249,8 @@ s32_t stm32_i2c_msg_write(struct device *dev, struct i2c_msg *msg, LOG_DBG("%s: ERR %d", __func__, data->current.is_err); - data->current.is_nack = 0; - data->current.is_err = 0; + data->current.is_nack = 0U; + data->current.is_err = 0U; ret = -EIO; } @@ -273,9 +273,9 @@ s32_t stm32_i2c_msg_read(struct device *dev, struct i2c_msg *msg, data->current.len = msg->len; data->current.buf = msg->buf; data->current.flags = msg->flags; - data->current.is_restart = 0; - data->current.is_write = 0; - data->current.is_err = 0; + data->current.is_restart = 0U; + data->current.is_write = 0U; + data->current.is_err = 0U; data->slave_address = saddr; LL_I2C_EnableIT_EVT(i2c); @@ -289,7 +289,7 @@ s32_t stm32_i2c_msg_read(struct device *dev, struct i2c_msg *msg, LL_I2C_DisableIT_BUF(i2c); if (data->current.is_err) { LOG_DBG("%s: ERR %d", __func__, data->current.is_err); - data->current.is_err = 0; + data->current.is_err = 0U; ret = -EIO; } diff --git a/drivers/i2c/i2c_ll_stm32_v2.c b/drivers/i2c/i2c_ll_stm32_v2.c index a01acd8b788..50cd13f957a 100644 --- a/drivers/i2c/i2c_ll_stm32_v2.c +++ b/drivers/i2c/i2c_ll_stm32_v2.c @@ -283,7 +283,7 @@ static void stm32_i2c_event(struct device *dev) /* NACK received */ if (LL_I2C_IsActiveFlag_NACK(i2c)) { LL_I2C_ClearFlag_NACK(i2c); - data->current.is_nack = 1; + data->current.is_nack = 1U; goto end; } @@ -326,13 +326,13 @@ static int stm32_i2c_error(struct device *dev) if (LL_I2C_IsActiveFlag_ARLO(i2c)) { LL_I2C_ClearFlag_ARLO(i2c); - data->current.is_arlo = 1; + data->current.is_arlo = 1U; goto end; } if (LL_I2C_IsActiveFlag_BERR(i2c)) { LL_I2C_ClearFlag_BERR(i2c); - data->current.is_err = 1; + data->current.is_err = 1U; goto end; } @@ -378,9 +378,9 @@ int stm32_i2c_msg_write(struct device *dev, struct i2c_msg *msg, data->current.len = msg->len; data->current.buf = msg->buf; - data->current.is_write = 1; - data->current.is_nack = 0; - data->current.is_err = 0; + data->current.is_write = 1U; + data->current.is_nack = 0U; + data->current.is_err = 0U; data->current.msg = msg; msg_init(dev, msg, next_msg_flags, slave, LL_I2C_REQUEST_WRITE); @@ -400,18 +400,18 @@ error: if (data->current.is_arlo) { LOG_DBG("%s: ARLO %d", __func__, data->current.is_arlo); - data->current.is_arlo = 0; + data->current.is_arlo = 0U; } if (data->current.is_nack) { LOG_DBG("%s: NACK", __func__); - data->current.is_nack = 0; + data->current.is_nack = 0U; } if (data->current.is_err) { LOG_DBG("%s: ERR %d", __func__, data->current.is_err); - data->current.is_err = 0; + data->current.is_err = 0U; } return -EIO; @@ -426,10 +426,10 @@ int stm32_i2c_msg_read(struct device *dev, struct i2c_msg *msg, data->current.len = msg->len; data->current.buf = msg->buf; - data->current.is_write = 0; - data->current.is_arlo = 0; - data->current.is_err = 0; - data->current.is_nack = 0; + data->current.is_write = 0U; + data->current.is_arlo = 0U; + data->current.is_err = 0U; + data->current.is_nack = 0U; data->current.msg = msg; msg_init(dev, msg, next_msg_flags, slave, LL_I2C_REQUEST_READ); @@ -449,18 +449,18 @@ error: if (data->current.is_arlo) { LOG_DBG("%s: ARLO %d", __func__, data->current.is_arlo); - data->current.is_arlo = 0; + data->current.is_arlo = 0U; } if (data->current.is_nack) { LOG_DBG("%s: NACK", __func__); - data->current.is_nack = 0; + data->current.is_nack = 0U; } if (data->current.is_err) { LOG_DBG("%s: ERR %d", __func__, data->current.is_err); - data->current.is_err = 0; + data->current.is_err = 0U; } return -EIO; @@ -492,7 +492,7 @@ int stm32_i2c_msg_write(struct device *dev, struct i2c_msg *msg, { const struct i2c_stm32_config *cfg = DEV_CFG(dev); I2C_TypeDef *i2c = cfg->i2c; - unsigned int len = 0; + unsigned int len = 0U; u8_t *buf = msg->buf; msg_init(dev, msg, next_msg_flags, slave, LL_I2C_REQUEST_WRITE); @@ -529,7 +529,7 @@ int stm32_i2c_msg_read(struct device *dev, struct i2c_msg *msg, { const struct i2c_stm32_config *cfg = DEV_CFG(dev); I2C_TypeDef *i2c = cfg->i2c; - unsigned int len = 0; + unsigned int len = 0U; u8_t *buf = msg->buf; msg_init(dev, msg, next_msg_flags, slave, LL_I2C_REQUEST_READ); @@ -558,21 +558,21 @@ int stm32_i2c_configure_timing(struct device *dev, u32_t clock) I2C_TypeDef *i2c = cfg->i2c; u32_t i2c_hold_time_min, i2c_setup_time_min; u32_t i2c_h_min_time, i2c_l_min_time; - u32_t presc = 1; - u32_t timing = 0; + u32_t presc = 1U; + u32_t timing = 0U; switch (I2C_SPEED_GET(data->dev_config)) { case I2C_SPEED_STANDARD: - i2c_h_min_time = 4000; - i2c_l_min_time = 4700; - i2c_hold_time_min = 500; - i2c_setup_time_min = 1250; + i2c_h_min_time = 4000U; + i2c_l_min_time = 4700U; + i2c_hold_time_min = 500U; + i2c_setup_time_min = 1250U; break; case I2C_SPEED_FAST: - i2c_h_min_time = 600; - i2c_l_min_time = 1300; - i2c_hold_time_min = 375; - i2c_setup_time_min = 500; + i2c_h_min_time = 600U; + i2c_l_min_time = 1300U; + i2c_hold_time_min = 375U; + i2c_setup_time_min = 500U; break; default: return -EINVAL; diff --git a/drivers/i2c/i2c_mcux.c b/drivers/i2c/i2c_mcux.c index 766ebc33d4f..3e73db2e9a8 100644 --- a/drivers/i2c/i2c_mcux.c +++ b/drivers/i2c/i2c_mcux.c @@ -83,7 +83,7 @@ static void i2c_mcux_master_transfer_callback(I2C_Type *base, static u32_t i2c_mcux_convert_flags(int msg_flags) { - u32_t flags = 0; + u32_t flags = 0U; if (!(msg_flags & I2C_MSG_STOP)) { flags |= kI2C_TransferNoStopFlag; diff --git a/drivers/i2c/i2c_qmsi_ss.c b/drivers/i2c/i2c_qmsi_ss.c index 1dfa10131c8..6eb0908e113 100644 --- a/drivers/i2c/i2c_qmsi_ss.c +++ b/drivers/i2c/i2c_qmsi_ss.c @@ -127,7 +127,7 @@ DEVICE_DEFINE(i2c_ss_0, DT_I2C_SS_0_NAME, i2c_qmsi_ss_init, static void i2c_qmsi_ss_config_irq_0(void) { - u32_t mask = 0; + u32_t mask = 0U; /* Need to unmask the interrupts in System Control Subsystem (SCSS) * so the interrupt controller can route these interrupts to @@ -184,7 +184,7 @@ DEVICE_DEFINE(i2c_ss_1, DT_I2C_SS_1_NAME, i2c_qmsi_ss_init, static void i2c_qmsi_ss_config_irq_1(void) { - u32_t mask = 0; + u32_t mask = 0U; /* Need to unmask the interrupts in System Control Subsystem (SCSS) * so the interrupt controller can route these interrupts to diff --git a/drivers/i2c/i2c_sam_twi.c b/drivers/i2c/i2c_sam_twi.c index 3f7df012268..f77bc65a451 100644 --- a/drivers/i2c/i2c_sam_twi.c +++ b/drivers/i2c/i2c_sam_twi.c @@ -72,7 +72,7 @@ struct i2c_sam_twi_dev_data { static int i2c_clk_set(Twi *const twi, u32_t speed) { - u32_t ck_div = 0; + u32_t ck_div = 0U; u32_t cl_div; bool div_completed = false; @@ -197,8 +197,8 @@ static int i2c_sam_twi_transfer(struct device *dev, struct i2c_msg *msgs, for (; num_msgs > 0; num_msgs--, msgs++) { dev_data->msg.buf = msgs->buf; dev_data->msg.len = msgs->len; - dev_data->msg.idx = 0; - dev_data->msg.twi_sr = 0; + dev_data->msg.idx = 0U; + dev_data->msg.twi_sr = 0U; dev_data->msg.flags = msgs->flags; /* diff --git a/drivers/i2c/i2c_sam_twihs.c b/drivers/i2c/i2c_sam_twihs.c index e0531aa9920..5388b2bbd67 100644 --- a/drivers/i2c/i2c_sam_twihs.c +++ b/drivers/i2c/i2c_sam_twihs.c @@ -72,7 +72,7 @@ struct i2c_sam_twihs_dev_data { static int i2c_clk_set(Twihs *const twihs, u32_t speed) { - u32_t ck_div = 0; + u32_t ck_div = 0U; u32_t cl_div; bool div_completed = false; @@ -199,8 +199,8 @@ static int i2c_sam_twihs_transfer(struct device *dev, struct i2c_msg *msgs, for (int i = 0; i < num_msgs; i++) { dev_data->msg.buf = msgs[i].buf; dev_data->msg.len = msgs[i].len; - dev_data->msg.idx = 0; - dev_data->msg.twihs_sr = 0; + dev_data->msg.idx = 0U; + dev_data->msg.twihs_sr = 0U; dev_data->msg.flags = msgs[i].flags; if ((msgs[i].flags & I2C_MSG_RW_MASK) == I2C_MSG_READ) { read_msg_start(twihs, &dev_data->msg, addr); diff --git a/drivers/i2s/i2s_cavs.c b/drivers/i2s/i2s_cavs.c index 129b21017bb..59de4ca59e5 100644 --- a/drivers/i2s/i2s_cavs.c +++ b/drivers/i2s/i2s_cavs.c @@ -259,11 +259,11 @@ static int i2s_cavs_configure(struct device *dev, enum i2s_dir dir, u32_t sstsa; u32_t ssrsa; u32_t ssto; - u32_t ssioc = 0; + u32_t ssioc = 0U; u32_t mdiv; - u32_t i2s_m = 0; - u32_t i2s_n = 0; - u32_t frame_len = 0; + u32_t i2s_m = 0U; + u32_t i2s_n = 0U; + u32_t frame_len = 0U; bool inverted_frame = false; if ((dev_data->tx.state != I2S_STATE_NOT_READY) && @@ -308,14 +308,14 @@ static int i2s_cavs_configure(struct device *dev, enum i2s_dir dir, ssc1 = SSCR1_TTE | SSCR1_TTELP | SSCR1_TRAIL | SSCR1_TSRE | SSCR1_RSRE; /* sscr2 dynamic setting is LJDFD */ - ssc2 = 0; + ssc2 = 0U; /* sscr3 dynamic settings are TFT, RFT */ ssc3 = SSCR3_TX(CAVS_I2S_DMA_BURST_SIZE) | SSCR3_RX(CAVS_I2S_DMA_BURST_SIZE); /* sspsp dynamic settings are SCMODE, SFRMP, DMYSTRT, SFRMWDTH */ - sspsp = 0; + sspsp = 0U; /* sspsp2 no dynamic setting */ sspsp2 = 0x0; @@ -384,7 +384,7 @@ static int i2s_cavs_configure(struct device *dev, enum i2s_dir dir, i2s_n = mclk / 100; /* set divider value of 1 which divides the clock by 2 */ - mdiv = 1; + mdiv = 1U; /* Select M/N divider as the clock source */ ssc0 |= SSCR0_ECS; diff --git a/drivers/i2s/i2s_ll_stm32.c b/drivers/i2s/i2s_ll_stm32.c index 7bea88abf9c..a8b6cb7db03 100644 --- a/drivers/i2s/i2s_ll_stm32.c +++ b/drivers/i2s/i2s_ll_stm32.c @@ -775,7 +775,7 @@ static void tx_queue_drop(struct stream *stream) { size_t size; void *mem_block; - unsigned int n = 0; + unsigned int n = 0U; while (queue_get(&stream->mem_block_queue, &mem_block, &size) == 0) { k_mem_slab_free(stream->cfg.mem_slab, &mem_block); diff --git a/drivers/i2s/i2s_sam_ssc.c b/drivers/i2s/i2s_sam_ssc.c index 0f0fce2a8d6..5a6fefd8536 100644 --- a/drivers/i2s/i2s_sam_ssc.c +++ b/drivers/i2s/i2s_sam_ssc.c @@ -310,15 +310,15 @@ static int set_rx_data_format(const struct i2s_sam_dev_cfg *const dev_cfg, const bool pin_rf_en = IS_ENABLED(CONFIG_I2S_SAM_SSC_0_PIN_RF_EN); u8_t word_size_bits = i2s_cfg->word_size; u8_t num_words = i2s_cfg->channels; - u8_t fslen = 0; - u32_t ssc_rcmr = 0; - u32_t ssc_rfmr = 0; + u8_t fslen = 0U; + u32_t ssc_rcmr = 0U; + u32_t ssc_rfmr = 0U; bool frame_clk_master = !(i2s_cfg->options & I2S_OPT_FRAME_CLK_SLAVE); switch (i2s_cfg->format & I2S_FMT_DATA_FORMAT_MASK) { case I2S_FMT_DATA_FORMAT_I2S: - num_words = 2; + num_words = 2U; fslen = word_size_bits - 1; ssc_rcmr = SSC_RCMR_CKI @@ -401,14 +401,14 @@ static int set_tx_data_format(const struct i2s_sam_dev_cfg *const dev_cfg, Ssc *const ssc = dev_cfg->regs; u8_t word_size_bits = i2s_cfg->word_size; u8_t num_words = i2s_cfg->channels; - u8_t fslen = 0; - u32_t ssc_tcmr = 0; - u32_t ssc_tfmr = 0; + u8_t fslen = 0U; + u32_t ssc_tcmr = 0U; + u32_t ssc_tfmr = 0U; switch (i2s_cfg->format & I2S_FMT_DATA_FORMAT_MASK) { case I2S_FMT_DATA_FORMAT_I2S: - num_words = 2; + num_words = 2U; fslen = word_size_bits - 1; ssc_tcmr = SSC_TCMR_START_TF_FALLING @@ -729,7 +729,7 @@ static void tx_queue_drop(struct stream *stream) { size_t size; void *mem_block; - unsigned int n = 0; + unsigned int n = 0U; while (queue_get(&stream->mem_block_queue, &mem_block, &size) == 0) { k_mem_slab_free(stream->cfg.mem_slab, &mem_block); diff --git a/drivers/ieee802154/ieee802154_cc1200.c b/drivers/ieee802154/ieee802154_cc1200.c index e01054a1444..3bdc833f781 100644 --- a/drivers/ieee802154/ieee802154_cc1200.c +++ b/drivers/ieee802154/ieee802154_cc1200.c @@ -99,7 +99,7 @@ bool _cc1200_access_reg(struct cc1200_context *ctx, bool read, u8_t addr, burst ? "burst" : "single"); */ - cmd_buf[0] = 0; + cmd_buf[0] = 0U; if (burst) { cmd_buf[0] |= CC1200_ACCESS_BURST; @@ -276,9 +276,9 @@ static bool write_reg_freq(struct cc1200_context *ctx, u32_t freq) static u32_t rf_evaluate_freq_setting(struct cc1200_context *ctx, u32_t chan) { u32_t xtal = CONFIG_IEEE802154_CC1200_XOSC; - u32_t mult_10 = 100000; - u32_t factor = 1; - u32_t freq = 0; + u32_t mult_10 = 100000U; + u32_t factor = 1U; + u32_t freq = 0U; u32_t rf, lo_div; rf = ctx->rf_settings->chan_center_freq0 + diff --git a/drivers/ieee802154/ieee802154_cc2520.c b/drivers/ieee802154/ieee802154_cc2520.c index 5cc6d47a45a..1a7e58cfc3d 100644 --- a/drivers/ieee802154/ieee802154_cc2520.c +++ b/drivers/ieee802154/ieee802154_cc2520.c @@ -261,7 +261,7 @@ static inline u8_t _cc2520_status(struct cc2520_context *ctx) static bool verify_osc_stabilization(struct cc2520_context *cc2520) { - u8_t timeout = 100; + u8_t timeout = 100U; u8_t status; do { @@ -499,7 +499,7 @@ static inline bool verify_txfifo_status(struct cc2520_context *cc2520, static inline bool verify_tx_done(struct cc2520_context *cc2520) { - u8_t timeout = 10; + u8_t timeout = 10U; u8_t status; do { @@ -575,9 +575,9 @@ static inline void insert_radio_noise_details(struct net_pkt *pkt, u8_t *buf) */ lqi = buf[1] & CC2520_FCS_CORRELATION; if (lqi <= 50) { - lqi = 0; + lqi = 0U; } else if (lqi >= 110) { - lqi = 255; + lqi = 255U; } else { lqi = (lqi - 50) << 2; } @@ -816,7 +816,7 @@ static int cc2520_tx(struct device *dev, u8_t *frame = frag->data - net_pkt_ll_reserve(pkt); u8_t len = net_pkt_ll_reserve(pkt) + frag->len; struct cc2520_context *cc2520 = dev->driver_data; - u8_t retry = 2; + u8_t retry = 2U; bool status; LOG_DBG("%p (%u)", frag, len); @@ -1195,7 +1195,7 @@ static int insert_crypto_parameters(struct cipher_ctx *ctx, u8_t data[128]; u8_t *in_buf; u8_t in_len; - u8_t m = 0; + u8_t m = 0U; if (!apkt->pkt->out_buf || !apkt->pkt->out_buf_max) { LOG_ERR("Out buffer needs to be set"); @@ -1231,7 +1231,7 @@ static int insert_crypto_parameters(struct cipher_ctx *ctx, in_buf = apkt->ad; in_len = apkt->ad_len; - *auth_crypt = 0; + *auth_crypt = 0U; } else { in_buf = data; @@ -1246,7 +1246,7 @@ static int insert_crypto_parameters(struct cipher_ctx *ctx, if (ctx->mode_params.ccm_info.tag_len) { if ((ctx->mode_params.ccm_info.tag_len >> 2) > 3) { - m = 3; + m = 3U; } else { m = ctx->mode_params.ccm_info.tag_len >> 2; } diff --git a/drivers/ieee802154/ieee802154_kw41z.c b/drivers/ieee802154/ieee802154_kw41z.c index 4449f9f59e6..737161b4b93 100644 --- a/drivers/ieee802154/ieee802154_kw41z.c +++ b/drivers/ieee802154/ieee802154_kw41z.c @@ -647,7 +647,7 @@ static void kw41z_isr(int unused) { u32_t irqsts = ZLL->IRQSTS; u8_t state = kw41z_get_seq_state(); - u8_t restart_rx = 1; + u8_t restart_rx = 1U; u32_t rx_len; /* @@ -676,7 +676,7 @@ static void kw41z_isr(int unused) (unsigned int)ZLL->PHY_CTRL, (unsigned int)seq_state, state); - restart_rx = 0; + restart_rx = 0U; } else if ((!(ZLL->PHY_CTRL & ZLL_PHY_CTRL_RX_WMRK_MSK_MASK)) && (irqsts & ZLL_IRQSTS_RXWTRMRKIRQ_MASK)) { @@ -713,7 +713,7 @@ static void kw41z_isr(int unused) rx_len = rx_len * 2 + 12 + 22 + 2; kw41z_tmr3_set_timeout(rx_len); } - restart_rx = 0; + restart_rx = 0U; } /* Sequence done IRQ */ @@ -725,7 +725,7 @@ static void kw41z_isr(int unused) if (irqsts & ZLL_IRQSTS_PLL_UNLOCK_IRQ_MASK) { LOG_ERR("PLL unlock error"); kw41z_isr_seq_cleanup(); - restart_rx = 1; + restart_rx = 1U; } /* * TMR3 timeout, the autosequence has been aborted due to @@ -745,7 +745,7 @@ static void kw41z_isr(int unused) (unsigned int)ZLL->PHY_CTRL, seq_state); kw41z_isr_timeout_cleanup(); - restart_rx = 1; + restart_rx = 1U; if (state == KW41Z_STATE_TXRX) { /* TODO: What is the right error for no ACK? */ @@ -776,7 +776,7 @@ static void kw41z_isr(int unused) rx_len); } } - restart_rx = 1; + restart_rx = 1U; break; case KW41Z_STATE_TXRX: LOG_DBG("TXRX seq done"); @@ -796,7 +796,7 @@ static void kw41z_isr(int unused) } k_sem_give(&kw41z_context_data.seq_sync); - restart_rx = 1; + restart_rx = 1U; break; case KW41Z_STATE_CCA: @@ -807,19 +807,19 @@ static void kw41z_isr(int unused) atomic_set( &kw41z_context_data.seq_retval, -EBUSY); - restart_rx = 1; + restart_rx = 1U; } else { atomic_set( &kw41z_context_data.seq_retval, 0); - restart_rx = 0; + restart_rx = 0U; } k_sem_give(&kw41z_context_data.seq_sync); break; default: LOG_DBG("Unhandled state: %d", state); - restart_rx = 1; + restart_rx = 1U; break; } } @@ -833,10 +833,10 @@ static void kw41z_isr(int unused) irqsts, seq_state, state); kw41z_tmr3_disable(); - restart_rx = 0; + restart_rx = 0U; if (state != KW41Z_STATE_IDLE) { kw41z_isr_timeout_cleanup(); - restart_rx = 1; + restart_rx = 1U; /* If we are not running an automated * sequence then handle event. TMR3 can expire * during Recv/Ack sequence where the transmit diff --git a/drivers/ieee802154/ieee802154_mcr20a.c b/drivers/ieee802154/ieee802154_mcr20a.c index 0af223bf0f5..8e5189666fd 100644 --- a/drivers/ieee802154/ieee802154_mcr20a.c +++ b/drivers/ieee802154/ieee802154_mcr20a.c @@ -278,7 +278,7 @@ static int mcr20a_timer_set(struct mcr20a_context *mcr20a, u8_t cmp_reg, u32_t timeout) { - u32_t now = 0; + u32_t now = 0U; u32_t next; bool retval; @@ -455,7 +455,7 @@ static inline int mcr20a_abort_sequence(struct mcr20a_context *mcr20a, static inline int mcr20a_set_sequence(struct mcr20a_context *mcr20a, u8_t seq) { - u8_t ctrl1 = 0; + u8_t ctrl1 = 0U; seq = set_bits_phy_ctrl1_xcvseq(seq); ctrl1 = read_reg_phy_ctrl1(mcr20a); @@ -720,7 +720,7 @@ static void mcr20a_thread_main(void *arg) struct mcr20a_context *mcr20a = dev->driver_data; u8_t dregs[MCR20A_PHY_CTRL4 + 1]; bool set_new_seq; - u8_t ctrl1 = 0; + u8_t ctrl1 = 0U; while (true) { k_sem_take(&mcr20a->isr_sem, K_FOREVER); @@ -1153,7 +1153,7 @@ error: static int mcr20a_start(struct device *dev) { struct mcr20a_context *mcr20a = dev->driver_data; - u8_t timeout = 6; + u8_t timeout = 6U; u8_t status; k_mutex_lock(&mcr20a->phy_mutex, K_FOREVER); @@ -1275,9 +1275,9 @@ error: static int power_on_and_setup(struct device *dev) { struct mcr20a_context *mcr20a = dev->driver_data; - u8_t timeout = 6; + u8_t timeout = 6U; u32_t status; - u8_t tmp = 0; + u8_t tmp = 0U; if (!PART_OF_KW2XD_SIP) { set_reset(dev, 0); diff --git a/drivers/ieee802154/ieee802154_uart_pipe.c b/drivers/ieee802154/ieee802154_uart_pipe.c index 06ff775a4dc..9258970baa2 100644 --- a/drivers/ieee802154/ieee802154_uart_pipe.c +++ b/drivers/ieee802154/ieee802154_uart_pipe.c @@ -165,8 +165,8 @@ out: net_pkt_unref(pkt); flush: upipe->rx = false; - upipe->rx_len = 0; - upipe->rx_off = 0; + upipe->rx_len = 0U; + upipe->rx_off = 0U; } done: *off = 0; @@ -284,7 +284,7 @@ static int upipe_tx(struct device *dev, data = len; uart_pipe_send(&data, 1); - for (i = 0; i < len; i++) { + for (i = 0U; i < len; i++) { uart_pipe_send(pkt_buf+i, 1); } diff --git a/drivers/interrupt_controller/arcv2_irq_unit.c b/drivers/interrupt_controller/arcv2_irq_unit.c index 2663b9a7df8..1382edee043 100644 --- a/drivers/interrupt_controller/arcv2_irq_unit.c +++ b/drivers/interrupt_controller/arcv2_irq_unit.c @@ -117,7 +117,7 @@ static int _arc_v2_irq_unit_suspend(struct device *dev) * by IRQ auxiliary registers. For that reason we skip those * values in this loop. */ - for (irq = 16; irq < CONFIG_NUM_IRQS; irq++) { + for (irq = 16U; irq < CONFIG_NUM_IRQS; irq++) { _arc_v2_aux_reg_write(_ARC_V2_IRQ_SELECT, irq); ctx.irq_config[irq - 16] = _arc_v2_aux_reg_read(_ARC_V2_IRQ_PRIORITY) << 2; @@ -146,7 +146,7 @@ static int _arc_v2_irq_unit_resume(struct device *dev) * by IRQ auxiliary registers. For that reason we skip those * values in this loop. */ - for (irq = 16; irq < CONFIG_NUM_IRQS; irq++) { + for (irq = 16U; irq < CONFIG_NUM_IRQS; irq++) { _arc_v2_aux_reg_write(_ARC_V2_IRQ_SELECT, irq); #ifdef CONFIG_ARC_HAS_SECURE _arc_v2_aux_reg_write(_ARC_V2_IRQ_PRIORITY, diff --git a/drivers/interrupt_controller/dw_ictl.c b/drivers/interrupt_controller/dw_ictl.c index c714aebb774..4738abc3652 100644 --- a/drivers/interrupt_controller/dw_ictl.c +++ b/drivers/interrupt_controller/dw_ictl.c @@ -39,8 +39,8 @@ static int dw_ictl_initialize(struct device *port) (struct dw_ictl_registers *)dw->base_addr; /* disable all interrupts */ - regs->irq_inten_l = 0; - regs->irq_inten_h = 0; + regs->irq_inten_l = 0U; + regs->irq_inten_h = 0U; return 0; } diff --git a/drivers/interrupt_controller/ioapic_intr.c b/drivers/interrupt_controller/ioapic_intr.c index 5cbd88857ef..8117f4a639f 100644 --- a/drivers/interrupt_controller/ioapic_intr.c +++ b/drivers/interrupt_controller/ioapic_intr.c @@ -176,7 +176,7 @@ void store_flags(unsigned int irq, u32_t flags) u32_t restore_flags(unsigned int irq) { - u32_t flags = 0; + u32_t flags = 0U; if (sys_bitfield_test_bit((mem_addr_t) ioapic_suspend_buf, BIT_POS_FOR_IRQ_OPTION(irq, IOAPIC_BITFIELD_HI_LO))) { diff --git a/drivers/interrupt_controller/plic.c b/drivers/interrupt_controller/plic.c index 7a973b0b487..3a0ee9cbf62 100644 --- a/drivers/interrupt_controller/plic.c +++ b/drivers/interrupt_controller/plic.c @@ -195,18 +195,18 @@ static int plic_init(struct device *dev) /* Ensure that all interrupts are disabled initially */ for (i = 0; i < PLIC_EN_SIZE; i++) { - *en = 0; + *en = 0U; en++; } /* Set priority of each interrupt line to 0 initially */ for (i = 0; i < PLIC_IRQS; i++) { - *prio = 0; + *prio = 0U; prio++; } /* Set threshold priority to 0 */ - regs->threshold_prio = 0; + regs->threshold_prio = 0U; /* Setup IRQ handler for PLIC driver */ IRQ_CONNECT(RISCV_MACHINE_EXT_IRQ, diff --git a/drivers/interrupt_controller/shared_irq.c b/drivers/interrupt_controller/shared_irq.c index f18ba38e3ea..50242a6d063 100644 --- a/drivers/interrupt_controller/shared_irq.c +++ b/drivers/interrupt_controller/shared_irq.c @@ -29,7 +29,7 @@ static int isr_register(struct device *dev, isr_t isr_func, const struct shared_irq_config *config = dev->config->config_info; u32_t i; - for (i = 0; i < config->client_count; i++) { + for (i = 0U; i < config->client_count; i++) { if (!clients->client[i].isr_dev) { clients->client[i].isr_dev = isr_dev; clients->client[i].isr_func = isr_func; @@ -50,7 +50,7 @@ static inline int enable(struct device *dev, struct device *isr_dev) const struct shared_irq_config *config = dev->config->config_info; u32_t i; - for (i = 0; i < config->client_count; i++) { + for (i = 0U; i < config->client_count; i++) { if (clients->client[i].isr_dev == isr_dev) { clients->client[i].enabled = 1; irq_enable(config->irq_num); @@ -64,7 +64,7 @@ static int last_enabled_isr(struct shared_irq_runtime *clients, int count) { u32_t i; - for (i = 0; i < count; i++) { + for (i = 0U; i < count; i++) { if (clients->client[i].enabled) { return 0; } @@ -82,7 +82,7 @@ static inline int disable(struct device *dev, struct device *isr_dev) const struct shared_irq_config *config = dev->config->config_info; u32_t i; - for (i = 0; i < config->client_count; i++) { + for (i = 0U; i < config->client_count; i++) { if (clients->client[i].isr_dev == isr_dev) { clients->client[i].enabled = 0; if (last_enabled_isr(clients, config->client_count)) { @@ -100,7 +100,7 @@ void shared_irq_isr(struct device *dev) const struct shared_irq_config *config = dev->config->config_info; u32_t i; - for (i = 0; i < config->client_count; i++) { + for (i = 0U; i < config->client_count; i++) { if (clients->client[i].isr_dev) { clients->client[i].isr_func(clients->client[i].isr_dev); } diff --git a/drivers/ipm/ipm_quark_se.c b/drivers/ipm/ipm_quark_se.c index 7185206c662..0738ce6ec0a 100644 --- a/drivers/ipm/ipm_quark_se.c +++ b/drivers/ipm/ipm_quark_se.c @@ -203,7 +203,7 @@ int quark_se_ipm_controller_initialize(struct device *d) for (i = 0; i < QUARK_SE_IPM_CHANNELS; ++i) { volatile struct quark_se_ipm *ipm = QUARK_SE_IPM(i); - ipm->sts = 0; + ipm->sts = 0U; } #endif diff --git a/drivers/led/lp3943.c b/drivers/led/lp3943.c index 21965029e88..389bfc59a7e 100644 --- a/drivers/led/lp3943.c +++ b/drivers/led/lp3943.c @@ -241,10 +241,10 @@ static int lp3943_led_init(struct device *dev) } /* Hardware specific limits */ - dev_data->min_period = 0; - dev_data->max_period = 1600; - dev_data->min_brightness = 0; - dev_data->max_brightness = 100; + dev_data->min_period = 0U; + dev_data->max_period = 1600U; + dev_data->min_brightness = 0U; + dev_data->max_brightness = 100U; return 0; } diff --git a/drivers/led/lp5562.c b/drivers/led/lp5562.c index bc95b3fbf0a..0f4d754bf4c 100644 --- a/drivers/led/lp5562.c +++ b/drivers/led/lp5562.c @@ -239,13 +239,13 @@ static int lp5562_get_engine_reg_shift(enum lp5562_led_sources engine, { switch (engine) { case LP5562_SOURCE_ENGINE_1: - *shift = 4; + *shift = 4U; break; case LP5562_SOURCE_ENGINE_2: - *shift = 2; + *shift = 2U; break; case LP5562_SOURCE_ENGINE_3: - *shift = 0; + *shift = 0U; break; default: return -EINVAL; @@ -275,7 +275,7 @@ static void lp5562_ms_to_prescale_and_step(struct led_data *data, u32_t ms, * the step_time value never goes above the allowed 63. */ if (ms < 31) { - *prescale = 0; + *prescale = 0U; *step_time = ms << 1; return; @@ -285,7 +285,7 @@ static void lp5562_ms_to_prescale_and_step(struct led_data *data, u32_t ms, * With a prescaler value set to 1 one step takes 15.6ms. So by dividing * through 16 we get a decent enough result with low effort. */ - *prescale = 1; + *prescale = 1U; *step_time = ms >> 4; return; @@ -750,7 +750,7 @@ static int lp5562_led_blink(struct device *dev, u32_t led, struct led_data *dev_data = &data->dev_data; int ret; enum lp5562_led_sources engine; - u8_t command_index = 0; + u8_t command_index = 0U; ret = lp5562_get_available_engine(dev, &engine); if (ret) { diff --git a/drivers/led/pca9633.c b/drivers/led/pca9633.c index 50590a8f6fa..a255821306b 100644 --- a/drivers/led/pca9633.c +++ b/drivers/led/pca9633.c @@ -184,10 +184,10 @@ static int pca9633_led_init(struct device *dev) } /* Hardware specific limits */ - dev_data->min_period = 41; - dev_data->max_period = 10667; - dev_data->min_brightness = 0; - dev_data->max_brightness = 100; + dev_data->min_period = 41U; + dev_data->max_period = 10667U; + dev_data->min_brightness = 0U; + dev_data->max_brightness = 100U; return 0; } diff --git a/drivers/led_strip/ws2812b_sw.c b/drivers/led_strip/ws2812b_sw.c index f7a13a17a61..11c92fe22ad 100644 --- a/drivers/led_strip/ws2812b_sw.c +++ b/drivers/led_strip/ws2812b_sw.c @@ -30,7 +30,7 @@ static int send_buf(u8_t *buf, size_t len) /* Initilization of i is strictly not needed, but it avoids an * uninitialized warning with the inline assembly. */ - u32_t i = 0; + u32_t i = 0U; clock = device_get_binding(CONFIG_CLOCK_CONTROL_NRF5_M16SRC_DRV_NAME); if (!clock) { diff --git a/drivers/modem/wncm14a2a.c b/drivers/modem/wncm14a2a.c index 471bb59e385..d622682c044 100644 --- a/drivers/modem/wncm14a2a.c +++ b/drivers/modem/wncm14a2a.c @@ -424,13 +424,13 @@ static void net_buf_skipcrlf(struct net_buf **buf) static u16_t net_buf_findcrlf(struct net_buf *buf, struct net_buf **frag, u16_t *offset) { - u16_t len = 0, pos = 0; + u16_t len = 0U, pos = 0U; while (buf && !is_crlf(*(buf->data + pos))) { if (pos + 1 >= buf->len) { len += buf->len; buf = buf->frags; - pos = 0; + pos = 0U; } else { pos++; } @@ -457,7 +457,7 @@ static int net_pkt_setup_ip_data(struct net_pkt *pkt, struct wncm14a2a_socket *sock) { int hdr_len = 0; - u16_t src_port = 0, dst_port = 0; + u16_t src_port = 0U, dst_port = 0U; #if defined(CONFIG_NET_IPV6) if (net_pkt_family(pkt) == AF_INET6) { @@ -767,7 +767,7 @@ static void on_cmd_sockread(struct net_buf **buf, u16_t len) { struct wncm14a2a_socket *sock = NULL; struct net_buf *frag; - u8_t c = 0; + u8_t c = 0U; u16_t pos; int i, actual_length, hdr_len = 0; size_t value_size; @@ -868,7 +868,7 @@ static void on_cmd_sockread(struct net_buf **buf, u16_t len) return; } - c = 0; + c = 0U; } else { c = c << 4; } @@ -1019,7 +1019,7 @@ static void on_cmd_socknotifyev(struct net_buf **buf, u16_t len) static int net_buf_ncmp(struct net_buf *buf, const u8_t *s2, size_t n) { struct net_buf *frag = buf; - u16_t offset = 0; + u16_t offset = 0U; while ((n > 0) && (*(frag->data + offset) == *s2) && (*s2 != '\0')) { if (offset == frag->len) { @@ -1027,7 +1027,7 @@ static int net_buf_ncmp(struct net_buf *buf, const u8_t *s2, size_t n) break; } frag = frag->frags; - offset = 0; + offset = 0U; } else { offset++; } diff --git a/drivers/net/slip.c b/drivers/net/slip.c index 66e00f8c891..820f88481ec 100644 --- a/drivers/net/slip.c +++ b/drivers/net/slip.c @@ -161,7 +161,7 @@ static int slip_send(struct device *dev, struct net_pkt *pkt) /* This writes ethernet header */ if (!send_header_once && ll_reserve) { - for (i = 0; i < ll_reserve; i++) { + for (i = 0U; i < ll_reserve; i++) { slip_writeb_esc(*ptr++); } } @@ -173,7 +173,7 @@ static int slip_send(struct device *dev, struct net_pkt *pkt) * link layer header always. */ send_header_once = true; - ll_reserve = 0; + ll_reserve = 0U; ptr = frag->data; } #else @@ -181,7 +181,7 @@ static int slip_send(struct device *dev, struct net_pkt *pkt) ptr = frag->data; #endif - for (i = 0; i < frag->len; ++i) { + for (i = 0U; i < frag->len; ++i) { c = *ptr++; slip_writeb_esc(c); } diff --git a/drivers/neural_net/intel_gna.c b/drivers/neural_net/intel_gna.c index 8e16eb6e803..c4ea038e082 100644 --- a/drivers/neural_net/intel_gna.c +++ b/drivers/neural_net/intel_gna.c @@ -158,7 +158,7 @@ static int intel_gna_setup_page_table(void *physical, size_t size, return -EINVAL; } - for (page = 0; page < GNA_NUM_PAGES(size); page++) { + for (page = 0U; page < GNA_NUM_PAGES(size); page++) { dir_index = GNA_VA_PG_DIR(virt_addr); table_index = GNA_VA_PG_TABLE(virt_addr); gna_page_table[dir_index].entry[table_index] = diff --git a/drivers/pci/pci_interface.c b/drivers/pci/pci_interface.c index 83d50f5274a..95fe9de4a47 100644 --- a/drivers/pci/pci_interface.c +++ b/drivers/pci/pci_interface.c @@ -257,7 +257,7 @@ void pci_read(u32_t controller, union pci_addr_reg addr, case 4: default: access_size = SYS_PCI_ACCESS_32BIT; - access_offset = 0; + access_offset = 0U; break; } @@ -348,7 +348,7 @@ void pci_write(u32_t controller, union pci_addr_reg addr, case 4: default: access_size = SYS_PCI_ACCESS_32BIT; - access_offset = 0; + access_offset = 0U; break; } @@ -389,7 +389,7 @@ void pci_header_get(u32_t controller, /* fill in the PCI header from the device */ - for (i = 0; i < PCI_HEADER_WORDS; i++) { + for (i = 0U; i < PCI_HEADER_WORDS; i++) { pci_ctrl_addr.field.reg = i; pci_read(controller, pci_ctrl_addr, diff --git a/drivers/pinmux/pinmux_esp32.c b/drivers/pinmux/pinmux_esp32.c index 035f68cdfb2..7ead3602448 100644 --- a/drivers/pinmux/pinmux_esp32.c +++ b/drivers/pinmux/pinmux_esp32.c @@ -163,7 +163,7 @@ static int pinmux_initialize(struct device *device) { u32_t pin; - for (pin = 0; pin < ARRAY_SIZE(pin_mux_off); pin++) { + for (pin = 0U; pin < ARRAY_SIZE(pin_mux_off); pin++) { pinmux_set(NULL, pin, 0); } diff --git a/drivers/pwm/pwm_led_esp32.c b/drivers/pwm/pwm_led_esp32.c index eae82935f81..dae200a17f9 100644 --- a/drivers/pwm/pwm_led_esp32.c +++ b/drivers/pwm/pwm_led_esp32.c @@ -111,7 +111,7 @@ static u8_t pwm_led_esp32_get_gpio_config(u8_t pin, { u8_t i; - for (i = 0; i < 16; i++) { + for (i = 0U; i < 16; i++) { if (ch_cfg[i].gpio == pin) { return i; } @@ -180,10 +180,10 @@ static void pwm_led_esp32_duty_set(int speed_mode, int channel, int duty_val) { union pwm_led_esp32_duty duty; - duty.start = 0; - duty.direction = 1; - duty.cycle = 1; - duty.scale = 0; + duty.start = 0U; + duty.direction = 1U; + duty.cycle = 1U; + duty.scale = 0U; pwm_led_esp32_duty_config(speed_mode, channel, duty_val << 4, duty); } diff --git a/drivers/pwm/pwm_nrf5_sw.c b/drivers/pwm/pwm_nrf5_sw.c index 1d092418898..002fd226e3d 100644 --- a/drivers/pwm/pwm_nrf5_sw.c +++ b/drivers/pwm/pwm_nrf5_sw.c @@ -42,7 +42,7 @@ static u32_t pwm_period_check(struct pwm_data *data, u8_t map_size, } /* fail if requested period does not match already running period */ - for (i = 0; i < map_size; i++) { + for (i = 0U; i < map_size; i++) { if ((data->map[i].pwm != pwm) && (data->map[i].pulse_cycles != 0) && (period_cycles != data->period_cycles)) { @@ -59,7 +59,7 @@ static u8_t pwm_channel_map(struct pwm_data *data, u8_t map_size, u8_t i; /* find pin, if already present */ - for (i = 0; i < map_size; i++) { + for (i = 0U; i < map_size; i++) { if (pwm == data->map[i].pwm) { return i; } @@ -176,11 +176,11 @@ static int pwm_nrf5_sw_pin_set(struct device *dev, u32_t pwm, return 0; pin_set_pwm_off: - data->map[channel].pulse_cycles = 0; + data->map[channel].pulse_cycles = 0U; bool pwm_active = false; /* stop timer if all channels are inactive */ - for (channel = 0; channel < config->map_size; channel++) { + for (channel = 0U; channel < config->map_size; channel++) { if (data->map[channel].pulse_cycles) { pwm_active = true; break; diff --git a/drivers/pwm/pwm_qmsi.c b/drivers/pwm/pwm_qmsi.c index 8f483f5840b..3243b9d41dd 100644 --- a/drivers/pwm/pwm_qmsi.c +++ b/drivers/pwm/pwm_qmsi.c @@ -80,7 +80,7 @@ static int __set_one_port(struct device *dev, qm_pwm_t id, u32_t pwm, * turned off. Let's use the minimum value which is 1 for this case. */ if (off == 0) { - off = 1; + off = 1U; } /* PWM mode, user-defined count mode, timer disabled */ @@ -149,7 +149,7 @@ static int pwm_qmsi_pin_set(struct device *dev, u32_t pwm, */ if (low == 0) { high--; - low = 1; + low = 1U; } return __set_one_port(dev, QM_PWM_0, pwm, high, low); diff --git a/drivers/sensor/adt7420/adt7420.c b/drivers/sensor/adt7420/adt7420.c index 96f018ad136..0fda790c6c6 100644 --- a/drivers/sensor/adt7420/adt7420.c +++ b/drivers/sensor/adt7420/adt7420.c @@ -49,7 +49,7 @@ static int adt7420_attr_set(struct device *dev, { struct adt7420_data *drv_data = dev->driver_data; const struct adt7420_dev_config *cfg = dev->config->config_info; - u8_t val8, reg = 0; + u8_t val8, reg = 0U; u16_t rate; s64_t value; diff --git a/drivers/sensor/adxl372/adxl372.c b/drivers/sensor/adxl372/adxl372.c index f2e08497a4f..73538bb89a1 100644 --- a/drivers/sensor/adxl372/adxl372.c +++ b/drivers/sensor/adxl372/adxl372.c @@ -259,7 +259,7 @@ static int adxl372_set_bandwidth(struct device *dev, enum adxl372_bandwidth bw) if (bw == ADXL372_BW_LPF_DISABLED) { mask = ADXL372_POWER_CTL_LPF_DIS_MSK; } else { - mask = 0; + mask = 0U; } ret = adxl372_reg_write_mask(dev, ADXL372_POWER_CTL, @@ -293,7 +293,7 @@ static int adxl372_set_hpf_corner(struct device *dev, enum adxl372_hpf_corner c) if (c == ADXL372_HPF_DISABLED) { mask = ADXL372_POWER_CTL_HPF_DIS_MSK; } else { - mask = 0; + mask = 0U; } ret = adxl372_reg_write_mask(dev, ADXL372_POWER_CTL, @@ -461,7 +461,7 @@ int adxl372_get_status(struct device *dev, u8_t *status2, u16_t *fifo_entries) { - u8_t buf[4], length = 1; + u8_t buf[4], length = 1U; int ret; if (status2) { diff --git a/drivers/sensor/adxl372/adxl372_trigger.c b/drivers/sensor/adxl372/adxl372_trigger.c index 55b254766cd..10508934a64 100644 --- a/drivers/sensor/adxl372/adxl372_trigger.c +++ b/drivers/sensor/adxl372/adxl372_trigger.c @@ -121,7 +121,7 @@ int adxl372_trigger_set(struct device *dev, if (handler) { int_en = int_mask; } else { - int_en = 0; + int_en = 0U; } ret = adxl372_reg_write_mask(dev, ADXL372_INT1_MAP, int_mask, int_en); diff --git a/drivers/sensor/apds9960/apds9960.c b/drivers/sensor/apds9960/apds9960.c index 60005fa7c61..b80d1d7cfed 100644 --- a/drivers/sensor/apds9960/apds9960.c +++ b/drivers/sensor/apds9960/apds9960.c @@ -429,7 +429,7 @@ static int apds9960_init(struct device *dev) } (void)memset(data->sample_crgb, 0, sizeof(data->sample_crgb)); - data->pdata = 0; + data->pdata = 0U; apds9960_sensor_setup(dev); diff --git a/drivers/sensor/bma280/bma280.c b/drivers/sensor/bma280/bma280.c index 3f66126c078..fc861e93aa1 100644 --- a/drivers/sensor/bma280/bma280.c +++ b/drivers/sensor/bma280/bma280.c @@ -115,7 +115,7 @@ static const struct sensor_driver_api bma280_driver_api = { int bma280_init(struct device *dev) { struct bma280_data *drv_data = dev->driver_data; - u8_t id = 0; + u8_t id = 0U; drv_data->i2c = device_get_binding(CONFIG_BMA280_I2C_MASTER_DEV_NAME); if (drv_data->i2c == NULL) { diff --git a/drivers/sensor/bma280/bma280_trigger.c b/drivers/sensor/bma280/bma280_trigger.c index f9283efd27f..202b820d526 100644 --- a/drivers/sensor/bma280/bma280_trigger.c +++ b/drivers/sensor/bma280/bma280_trigger.c @@ -75,7 +75,7 @@ static void bma280_thread_cb(void *arg) { struct device *dev = arg; struct bma280_data *drv_data = dev->driver_data; - u8_t status = 0; + u8_t status = 0U; int err = 0; /* check for data ready */ diff --git a/drivers/sensor/bmc150_magn/bmc150_magn.c b/drivers/sensor/bmc150_magn/bmc150_magn.c index bc7f81af1d5..31dde7411fb 100644 --- a/drivers/sensor/bmc150_magn/bmc150_magn.c +++ b/drivers/sensor/bmc150_magn/bmc150_magn.c @@ -93,7 +93,7 @@ static int bmc150_magn_set_odr(struct device *dev, u8_t val) const struct bmc150_magn_config *config = dev->config->config_info; u8_t i; - for (i = 0; i < ARRAY_SIZE(bmc150_magn_samp_freq_table); ++i) { + for (i = 0U; i < ARRAY_SIZE(bmc150_magn_samp_freq_table); ++i) { if (val <= bmc150_magn_samp_freq_table[i].freq) { return i2c_reg_update_byte(data->i2c_master, config->i2c_slave_addr, @@ -184,7 +184,7 @@ static int bmc150_magn_read_odr(struct device *dev) odr_val = (reg_val & BMC150_MAGN_MASK_ODR) >> BMC150_MAGN_SHIFT_ODR; - for (i = 0; i < ARRAY_SIZE(bmc150_magn_samp_freq_table); ++i) { + for (i = 0U; i < ARRAY_SIZE(bmc150_magn_samp_freq_table); ++i) { if (bmc150_magn_samp_freq_table[i].reg_val == odr_val) { data->odr = bmc150_magn_samp_freq_table[i].freq; return 0; diff --git a/drivers/sensor/bmc150_magn/bmc150_magn_trigger.c b/drivers/sensor/bmc150_magn/bmc150_magn_trigger.c index bc910e39fa8..74140ebe59c 100644 --- a/drivers/sensor/bmc150_magn/bmc150_magn_trigger.c +++ b/drivers/sensor/bmc150_magn/bmc150_magn_trigger.c @@ -30,9 +30,9 @@ int bmc150_magn_trigger_set(struct device *dev, gpio_pin_disable_callback(data->gpio_drdy, config->gpio_drdy_int_pin); - state = 0; + state = 0U; if (handler) { - state = 1; + state = 1U; } data->handler_drdy = handler; diff --git a/drivers/sensor/bme280/bme280.c b/drivers/sensor/bme280/bme280.c index b00bcabc765..41ea25b7f69 100644 --- a/drivers/sensor/bme280/bme280.c +++ b/drivers/sensor/bme280/bme280.c @@ -129,7 +129,7 @@ static void bme280_compensate_press(struct bme280_data *data, s32_t adc_press) /* Avoid exception caused by division by zero. */ if (var1 == 0) { - data->comp_press = 0; + data->comp_press = 0U; return; } diff --git a/drivers/sensor/bmg160/bmg160.c b/drivers/sensor/bmg160/bmg160.c index 7295d8bf835..caa4cff2768 100644 --- a/drivers/sensor/bmg160/bmg160.c +++ b/drivers/sensor/bmg160/bmg160.c @@ -274,7 +274,7 @@ int bmg160_init(struct device *dev) { const struct bmg160_device_config *cfg = dev->config->config_info; struct bmg160_device_data *bmg160 = dev->driver_data; - u8_t chip_id = 0; + u8_t chip_id = 0U; u16_t range_dps; bmg160->i2c = device_get_binding((char *)cfg->i2c_port); diff --git a/drivers/sensor/bmg160/bmg160_trigger.c b/drivers/sensor/bmg160/bmg160_trigger.c index 6c2f5cb948f..2554c0aa4cb 100644 --- a/drivers/sensor/bmg160/bmg160_trigger.c +++ b/drivers/sensor/bmg160/bmg160_trigger.c @@ -39,7 +39,7 @@ static int bmg160_anymotion_set(struct device *dev, sensor_trigger_handler_t handler) { struct bmg160_device_data *bmg160 = dev->driver_data; - u8_t anymotion_en = 0; + u8_t anymotion_en = 0U; if (handler) { anymotion_en = BMG160_ANY_EN_X | diff --git a/drivers/sensor/bmi160/bmi160.c b/drivers/sensor/bmi160/bmi160.c index 885041de8cf..e15bbaceb8a 100644 --- a/drivers/sensor/bmi160/bmi160.c +++ b/drivers/sensor/bmi160/bmi160.c @@ -366,7 +366,7 @@ static int bmi160_acc_calibrate(struct device *dev, enum sensor_channel chan, BMI160_FOC_ACC_Z_POS, }; int i; - u8_t reg_val = 0; + u8_t reg_val = 0U; /* Calibration has to be done in normal mode. */ if (bmi160->pmu_sts.acc != BMI160_PMU_NORMAL) { @@ -386,13 +386,13 @@ static int bmi160_acc_calibrate(struct device *dev, enum sensor_channel chan, accel_g = sensor_ms2_to_g(xyz_calib_value); if (accel_g == 0) { - accel_val = 3; + accel_val = 3U; } else if (accel_g == 1) { - accel_val = 1; + accel_val = 1U; } else if (accel_g == -1) { - accel_val = 2; + accel_val = 2U; } else { - accel_val = 0; + accel_val = 0U; } reg_val |= (accel_val << foc_pos[i]); } @@ -631,7 +631,7 @@ static int bmi160_sample_fetch(struct device *dev, enum sensor_channel chan) __ASSERT_NO_MSG(chan == SENSOR_CHAN_ALL); - bmi160->sample.raw[0] = 0; + bmi160->sample.raw[0] = 0U; while ((bmi160->sample.raw[0] & BMI160_DATA_READY_BIT_MASK) == 0) { if (bmi160_transceive(dev, BMI160_REG_STATUS | (1 << 7), false, @@ -683,18 +683,18 @@ static void bmi160_channel_convert(enum sensor_channel chan, switch (chan) { case SENSOR_CHAN_ACCEL_X: case SENSOR_CHAN_GYRO_X: - ofs_start = ofs_stop = 0; + ofs_start = ofs_stop = 0U; break; case SENSOR_CHAN_ACCEL_Y: case SENSOR_CHAN_GYRO_Y: - ofs_start = ofs_stop = 1; + ofs_start = ofs_stop = 1U; break; case SENSOR_CHAN_ACCEL_Z: case SENSOR_CHAN_GYRO_Z: - ofs_start = ofs_stop = 2; + ofs_start = ofs_stop = 2U; break; default: - ofs_start = 0; ofs_stop = 2; + ofs_start = 0U; ofs_stop = 2U; break; } @@ -729,7 +729,7 @@ static inline void bmi160_acc_channel_get(struct device *dev, static int bmi160_temp_channel_get(struct device *dev, struct sensor_value *val) { - u16_t temp_raw = 0; + u16_t temp_raw = 0U; s32_t temp_micro = 0; struct bmi160_device_data *bmi160 = dev->driver_data; @@ -793,7 +793,7 @@ static const struct sensor_driver_api bmi160_api = { int bmi160_init(struct device *dev) { struct bmi160_device_data *bmi160 = dev->driver_data; - u8_t val = 0; + u8_t val = 0U; s32_t acc_range, gyr_range; bmi160->spi = device_get_binding(DT_BMI160_SPI_PORT_NAME); diff --git a/drivers/sensor/bmi160/bmi160_trigger.c b/drivers/sensor/bmi160/bmi160_trigger.c index 91111be4e62..f7d3e49d78c 100644 --- a/drivers/sensor/bmi160/bmi160_trigger.c +++ b/drivers/sensor/bmi160/bmi160_trigger.c @@ -131,7 +131,7 @@ static int bmi160_trigger_drdy_set(struct device *dev, sensor_trigger_handler_t handler) { struct bmi160_device_data *bmi160 = dev->driver_data; - u8_t drdy_en = 0; + u8_t drdy_en = 0U; #if !defined(CONFIG_BMI160_ACCEL_PMU_SUSPEND) if (chan == SENSOR_CHAN_ACCEL_XYZ) { @@ -166,7 +166,7 @@ static int bmi160_trigger_anym_set(struct device *dev, sensor_trigger_handler_t handler) { struct bmi160_device_data *bmi160 = dev->driver_data; - u8_t anym_en = 0; + u8_t anym_en = 0U; bmi160->handler_anymotion = handler; diff --git a/drivers/sensor/bmm150/bmm150.c b/drivers/sensor/bmm150/bmm150.c index cad1b2075b9..c330f2f11ec 100644 --- a/drivers/sensor/bmm150/bmm150.c +++ b/drivers/sensor/bmm150/bmm150.c @@ -82,7 +82,7 @@ static int bmm150_set_odr(struct device *dev, u8_t val) const struct bmm150_config *config = dev->config->config_info; u8_t i; - for (i = 0; i < ARRAY_SIZE(bmm150_samp_freq_table); ++i) { + for (i = 0U; i < ARRAY_SIZE(bmm150_samp_freq_table); ++i) { if (val <= bmm150_samp_freq_table[i].freq) { return i2c_reg_update_byte(data->i2c, config->i2c_slave_addr, @@ -173,7 +173,7 @@ static int bmm150_read_odr(struct device *dev) odr_val = (reg_val & BMM150_MASK_ODR) >> BMM150_SHIFT_ODR; - for (i = 0; i < ARRAY_SIZE(bmm150_samp_freq_table); ++i) { + for (i = 0U; i < ARRAY_SIZE(bmm150_samp_freq_table); ++i) { if (bmm150_samp_freq_table[i].reg_val == odr_val) { data->odr = bmm150_samp_freq_table[i].freq; return 0; diff --git a/drivers/sensor/dht/dht.c b/drivers/sensor/dht/dht.c index a9eb73c8917..d5ce37e3e66 100644 --- a/drivers/sensor/dht/dht.c +++ b/drivers/sensor/dht/dht.c @@ -94,7 +94,7 @@ static int dht_sample_fetch(struct device *dev, enum sensor_channel chan) } /* read sensor data */ - for (i = 0; i < DHT_DATA_BITS_NUM; i++) { + for (i = 0U; i < DHT_DATA_BITS_NUM; i++) { /* LOW signal to indicate a new bit */ if (dht_measure_signal_duration(drv_data, 0) == -1) { ret = -EIO; @@ -118,7 +118,7 @@ static int dht_sample_fetch(struct device *dev, enum sensor_channel chan) */ min_duration = signal_duration[0]; max_duration = signal_duration[0]; - for (i = 1; i < DHT_DATA_BITS_NUM; i++) { + for (i = 1U; i < DHT_DATA_BITS_NUM; i++) { if (min_duration > signal_duration[i]) { min_duration = signal_duration[i]; } @@ -129,9 +129,9 @@ static int dht_sample_fetch(struct device *dev, enum sensor_channel chan) avg_duration = ((s16_t)min_duration + (s16_t)max_duration) / 2; /* store bits in buf */ - j = 0; + j = 0U; (void)memset(buf, 0, sizeof(buf)); - for (i = 0; i < DHT_DATA_BITS_NUM; i++) { + for (i = 0U; i < DHT_DATA_BITS_NUM; i++) { if (signal_duration[i] >= avg_duration) { buf[j] = (buf[j] << 1) | 1; } else { diff --git a/drivers/sensor/fxas21002/fxas21002_trigger.c b/drivers/sensor/fxas21002/fxas21002_trigger.c index 896c3ab40b6..209a4cd8c90 100644 --- a/drivers/sensor/fxas21002/fxas21002_trigger.c +++ b/drivers/sensor/fxas21002/fxas21002_trigger.c @@ -61,7 +61,7 @@ static void fxas21002_handle_int(void *arg) FXAS21002_REG_INT_SOURCE, &int_source)) { LOG_ERR("Could not read interrupt source"); - int_source = 0; + int_source = 0U; } k_sem_give(&data->sem); @@ -187,7 +187,7 @@ int fxas21002_trigger_init(struct device *dev) #endif /* Route the interrupts to INT1/INT2 pins */ - ctrl_reg2 = 0; + ctrl_reg2 = 0U; #if CONFIG_FXAS21002_DRDY_INT1 ctrl_reg2 |= FXAS21002_CTRLREG2_CFG_DRDY_MASK; #endif diff --git a/drivers/sensor/fxos8700/fxos8700_trigger.c b/drivers/sensor/fxos8700/fxos8700_trigger.c index 2955441ee31..20fddbc6e69 100644 --- a/drivers/sensor/fxos8700/fxos8700_trigger.c +++ b/drivers/sensor/fxos8700/fxos8700_trigger.c @@ -129,7 +129,7 @@ static void fxos8700_handle_int(void *arg) FXOS8700_REG_INT_SOURCE, &int_source)) { LOG_ERR("Could not read interrupt source"); - int_source = 0; + int_source = 0U; } k_sem_give(&data->sem); @@ -348,7 +348,7 @@ int fxos8700_trigger_init(struct device *dev) #endif /* Route the interrupts to INT1/INT2 pins */ - ctrl_reg5 = 0; + ctrl_reg5 = 0U; #if CONFIG_FXOS8700_DRDY_INT1 ctrl_reg5 |= FXOS8700_DRDY_MASK; #endif diff --git a/drivers/sensor/hmc5883l/hmc5883l.c b/drivers/sensor/hmc5883l/hmc5883l.c index 47c1f801bd1..6d2ea8149af 100644 --- a/drivers/sensor/hmc5883l/hmc5883l.c +++ b/drivers/sensor/hmc5883l/hmc5883l.c @@ -107,7 +107,7 @@ int hmc5883l_init(struct device *dev) } /* check if CONFIG_HMC5883L_FS is valid */ - for (idx = 0; idx < ARRAY_SIZE(hmc5883l_fs_strings); idx++) { + for (idx = 0U; idx < ARRAY_SIZE(hmc5883l_fs_strings); idx++) { if (!strcmp(hmc5883l_fs_strings[idx], CONFIG_HMC5883L_FS)) { break; } @@ -121,7 +121,7 @@ int hmc5883l_init(struct device *dev) drv_data->gain_idx = idx; /* check if CONFIG_HMC5883L_ODR is valid */ - for (idx = 0; idx < ARRAY_SIZE(hmc5883l_odr_strings); idx++) { + for (idx = 0U; idx < ARRAY_SIZE(hmc5883l_odr_strings); idx++) { if (!strcmp(hmc5883l_odr_strings[idx], CONFIG_HMC5883L_ODR)) { break; } diff --git a/drivers/sensor/hp206c/hp206c.c b/drivers/sensor/hp206c/hp206c.c index 8067d368a1b..f4f8f76ab4e 100644 --- a/drivers/sensor/hp206c/hp206c.c +++ b/drivers/sensor/hp206c/hp206c.c @@ -110,7 +110,7 @@ static int hp206c_osr_set(struct device *dev, u16_t osr) u8_t i; /* the following code translates OSR values to an index */ - for (i = 0; i < 6 && BIT(12 - i) != osr; i++) { + for (i = 0U; i < 6 && BIT(12 - i) != osr; i++) { ; } diff --git a/drivers/sensor/hts221/hts221.c b/drivers/sensor/hts221/hts221.c index 73b3792bf75..ea98da30dcb 100644 --- a/drivers/sensor/hts221/hts221.c +++ b/drivers/sensor/hts221/hts221.c @@ -131,7 +131,7 @@ int hts221_init(struct device *dev) } /* check if CONFIG_HTS221_ODR is valid */ - for (idx = 0; idx < ARRAY_SIZE(hts221_odr_strings); idx++) { + for (idx = 0U; idx < ARRAY_SIZE(hts221_odr_strings); idx++) { if (!strcmp(hts221_odr_strings[idx], CONFIG_HTS221_ODR)) { break; } diff --git a/drivers/sensor/isl29035/isl29035.c b/drivers/sensor/isl29035/isl29035.c index 48d274da5e0..80402a219cd 100644 --- a/drivers/sensor/isl29035/isl29035.c +++ b/drivers/sensor/isl29035/isl29035.c @@ -81,7 +81,7 @@ static int isl29035_init(struct device *dev) return -EINVAL; } - drv_data->data_sample = 0; + drv_data->data_sample = 0U; /* clear blownout status bit */ if (i2c_reg_update_byte(drv_data->i2c, ISL29035_I2C_ADDRESS, diff --git a/drivers/sensor/lis2dh/lis2dh.c b/drivers/sensor/lis2dh/lis2dh.c index a6506968a4f..1861b838790 100644 --- a/drivers/sensor/lis2dh/lis2dh.c +++ b/drivers/sensor/lis2dh/lis2dh.c @@ -54,7 +54,7 @@ int lis2dh_reg_field_update(struct device *dev, u8_t reg_addr, u8_t old_val; /* just to remove gcc warning */ - old_val = 0; + old_val = 0U; status = lis2dh_reg_read_byte(dev, reg_addr, &old_val); if (status < 0) { diff --git a/drivers/sensor/lis2dh/lis2dh_trigger.c b/drivers/sensor/lis2dh/lis2dh_trigger.c index d4e153ddd63..e7f081d3871 100644 --- a/drivers/sensor/lis2dh/lis2dh_trigger.c +++ b/drivers/sensor/lis2dh/lis2dh_trigger.c @@ -57,7 +57,7 @@ static int lis2dh_start_trigger_int1(struct device *dev) struct lis2dh_data *lis2dh = dev->driver_data; int status; u8_t raw[LIS2DH_BUF_SZ]; - u8_t ctrl1 = 0; + u8_t ctrl1 = 0U; /* power down temporarly to align interrupt & data output sampling */ status = lis2dh_reg_read_byte(dev, LIS2DH_REG_CTRL1, &ctrl1); diff --git a/drivers/sensor/lis2mdl/lis2mdl.c b/drivers/sensor/lis2mdl/lis2mdl.c index 3d8835f8c24..9f60ddce459 100644 --- a/drivers/sensor/lis2mdl/lis2mdl.c +++ b/drivers/sensor/lis2mdl/lis2mdl.c @@ -93,7 +93,7 @@ static int lis2mdl_set_hard_iron(struct device *dev, enum sensor_channel chan, s16_t offs; int ret; - for (i = 0; i < LIS2MDL_NUM_AXIS; i++) { + for (i = 0U; i < LIS2MDL_NUM_AXIS; i++) { offs = sys_cpu_to_le16(val->val1); ret = i2c_burst_write(lis2mdl->i2c, lis2mdl->i2c_addr, regs, (u8_t *)&offs, sizeof(offs)); @@ -120,16 +120,16 @@ static void lis2mdl_channel_get_mag(struct device *dev, switch (chan) { case SENSOR_CHAN_MAGN_X: - ofs_start = ofs_stop = 0; + ofs_start = ofs_stop = 0U; break; case SENSOR_CHAN_MAGN_Y: - ofs_start = ofs_stop = 1; + ofs_start = ofs_stop = 1U; break; case SENSOR_CHAN_MAGN_Z: - ofs_start = ofs_stop = 2; + ofs_start = ofs_stop = 2U; break; default: - ofs_start = 0; ofs_stop = 2; + ofs_start = 0U; ofs_stop = 2U; break; } diff --git a/drivers/sensor/lis3mdl/lis3mdl.c b/drivers/sensor/lis3mdl/lis3mdl.c index 677952d4685..80954eb30ea 100644 --- a/drivers/sensor/lis3mdl/lis3mdl.c +++ b/drivers/sensor/lis3mdl/lis3mdl.c @@ -126,7 +126,7 @@ int lis3mdl_init(struct device *dev) } /* check if CONFIG_LIS3MDL_ODR is valid */ - for (idx = 0; idx < ARRAY_SIZE(lis3mdl_odr_strings); idx++) { + for (idx = 0U; idx < ARRAY_SIZE(lis3mdl_odr_strings); idx++) { if (!strcmp(lis3mdl_odr_strings[idx], CONFIG_LIS3MDL_ODR)) { break; } diff --git a/drivers/sensor/lsm6dsl/lsm6dsl_shub.c b/drivers/sensor/lsm6dsl/lsm6dsl_shub.c index e9a9ccad291..6368aba4bc2 100644 --- a/drivers/sensor/lsm6dsl/lsm6dsl_shub.c +++ b/drivers/sensor/lsm6dsl/lsm6dsl_shub.c @@ -278,7 +278,7 @@ static int lsm6dsl_shub_write_slave_reg(struct lsm6dsl_data *data, u8_t *value, u16_t len) { u8_t slv_cfg[3]; - u8_t cnt = 0; + u8_t cnt = 0U; while (cnt < len) { slv_cfg[0] = (slv_addr << 1) & ~LSM6DSL_EMBEDDED_SLVX_READ; @@ -375,7 +375,7 @@ int lsm6dsl_shub_init_external_chip(struct device *dev) { struct lsm6dsl_data *data = dev->driver_data; u8_t i; - u8_t chip_id = 0; + u8_t chip_id = 0U; u8_t slv_i2c_addr; u8_t slv_wai_addr = lsm6dsl_shub_sens_list[0].wai_addr; @@ -384,7 +384,7 @@ int lsm6dsl_shub_init_external_chip(struct device *dev) * So, try them one by one until we read the correct * chip ID. */ - for (i = 0; i < ARRAY_SIZE(lsm6dsl_shub_sens_list[0].i2c_addr); i++) { + for (i = 0U; i < ARRAY_SIZE(lsm6dsl_shub_sens_list[0].i2c_addr); i++) { slv_i2c_addr = lsm6dsl_shub_sens_list[0].i2c_addr[i]; if (slv_i2c_addr == 0) { diff --git a/drivers/sensor/lsm9ds0_gyro/lsm9ds0_gyro_trigger.c b/drivers/sensor/lsm9ds0_gyro/lsm9ds0_gyro_trigger.c index 7d451e916c6..ffe27b164e3 100644 --- a/drivers/sensor/lsm9ds0_gyro/lsm9ds0_gyro_trigger.c +++ b/drivers/sensor/lsm9ds0_gyro/lsm9ds0_gyro_trigger.c @@ -35,9 +35,9 @@ int lsm9ds0_gyro_trigger_set(struct device *dev, gpio_pin_disable_callback(data->gpio_drdy, config->gpio_drdy_int_pin); - state = 0; + state = 0U; if (handler) { - state = 1; + state = 1U; } data->handler_drdy = handler; diff --git a/drivers/sensor/lsm9ds0_mfd/lsm9ds0_mfd.c b/drivers/sensor/lsm9ds0_mfd/lsm9ds0_mfd.c index a92b050158e..f79c7c6e045 100644 --- a/drivers/sensor/lsm9ds0_mfd/lsm9ds0_mfd.c +++ b/drivers/sensor/lsm9ds0_mfd/lsm9ds0_mfd.c @@ -73,7 +73,7 @@ static int lsm9ds0_mfd_accel_set_odr(struct device *dev, { u8_t i; - for (i = 0; i < ARRAY_SIZE(lsm9ds0_mfd_accel_odr_map); ++i) { + for (i = 0U; i < ARRAY_SIZE(lsm9ds0_mfd_accel_odr_map); ++i) { if (val->val1 < lsm9ds0_mfd_accel_odr_map[i].freq_int || (val->val1 == lsm9ds0_mfd_accel_odr_map[i].freq_int && val->val2 <= lsm9ds0_mfd_accel_odr_map[i].freq_micro)) { @@ -118,7 +118,7 @@ static int lsm9ds0_mfd_accel_set_fs(struct device *dev, int val) { u8_t i; - for (i = 0; i < ARRAY_SIZE(lsm9ds0_mfd_accel_fs_map); ++i) { + for (i = 0U; i < ARRAY_SIZE(lsm9ds0_mfd_accel_fs_map); ++i) { if (val <= lsm9ds0_mfd_accel_fs_map[i].fs) { return lsm9ds0_mfd_accel_set_fs_raw(dev, i); } @@ -158,7 +158,7 @@ static int lsm9ds0_mfd_magn_set_odr(struct device *dev, { u8_t i; - for (i = 0; i < ARRAY_SIZE(lsm9ds0_mfd_accel_odr_map); ++i) { + for (i = 0U; i < ARRAY_SIZE(lsm9ds0_mfd_accel_odr_map); ++i) { if (val->val1 < lsm9ds0_mfd_accel_odr_map[i].freq_int || (val->val1 == lsm9ds0_mfd_accel_odr_map[i].freq_int && val->val2 <= lsm9ds0_mfd_accel_odr_map[i].freq_micro)) { @@ -203,7 +203,7 @@ static int lsm9ds0_mfd_magn_set_fs(struct device *dev, { u8_t i; - for (i = 0; i < ARRAY_SIZE(lsm9ds0_mfd_magn_fs_map); ++i) { + for (i = 0U; i < ARRAY_SIZE(lsm9ds0_mfd_magn_fs_map); ++i) { if (val->val1 <= lsm9ds0_mfd_magn_fs_map[i].fs) { return lsm9ds0_mfd_magn_set_fs_raw(dev, i); } diff --git a/drivers/sensor/max30101/max30101.c b/drivers/sensor/max30101/max30101.c index 0d9df1909db..133bde4a9a4 100644 --- a/drivers/sensor/max30101/max30101.c +++ b/drivers/sensor/max30101/max30101.c @@ -183,8 +183,8 @@ static int max30101_init(struct device *dev) #endif /* Initialize the channel map and active channel count */ - data->num_channels = 0; - for (led_chan = 0; led_chan < MAX30101_MAX_NUM_CHANNELS; led_chan++) { + data->num_channels = 0U; + for (led_chan = 0U; led_chan < MAX30101_MAX_NUM_CHANNELS; led_chan++) { data->map[led_chan] = MAX30101_MAX_NUM_CHANNELS; } diff --git a/drivers/sensor/max44009/max44009.c b/drivers/sensor/max44009/max44009.c index a2e8a81f0d7..ea1a8b710d7 100644 --- a/drivers/sensor/max44009/max44009.c +++ b/drivers/sensor/max44009/max44009.c @@ -55,8 +55,8 @@ static int max44009_reg_write(struct max44009_data *drv_data, u8_t reg, static int max44009_reg_update(struct max44009_data *drv_data, u8_t reg, u8_t mask, u8_t val) { - u8_t old_val = 0; - u8_t new_val = 0; + u8_t old_val = 0U; + u8_t new_val = 0U; if (max44009_reg_read(drv_data, reg, &old_val, true) != 0) { return -EIO; @@ -88,7 +88,7 @@ static int max44009_attr_set(struct device *dev, enum sensor_channel chan, /* the sensor supports 1.25Hz or continuous conversion */ switch (cr) { case 1250: - value = 0; + value = 0U; break; default: value = MAX44009_CONTINUOUS_SAMPLING; @@ -117,7 +117,7 @@ static int max44009_sample_fetch(struct device *dev, enum sensor_channel chan) __ASSERT_NO_MSG(chan == SENSOR_CHAN_ALL || chan == SENSOR_CHAN_LIGHT); - drv_data->sample = 0; + drv_data->sample = 0U; if (max44009_reg_read(drv_data, MAX44009_REG_LUX_HIGH_BYTE, &val_h, false) != 0) { diff --git a/drivers/sensor/mcp9808/mcp9808_trigger.c b/drivers/sensor/mcp9808/mcp9808_trigger.c index 4fb78e9b414..98034271ff5 100644 --- a/drivers/sensor/mcp9808/mcp9808_trigger.c +++ b/drivers/sensor/mcp9808/mcp9808_trigger.c @@ -62,7 +62,7 @@ int mcp9808_attr_set(struct device *dev, enum sensor_channel chan, const struct sensor_value *val) { struct mcp9808_data *data = dev->driver_data; - u16_t reg_val = 0; + u16_t reg_val = 0U; u8_t reg_addr; s32_t val2; diff --git a/drivers/sensor/mpu6050/mpu6050.c b/drivers/sensor/mpu6050/mpu6050.c index 035792ef1fb..5795de7c437 100644 --- a/drivers/sensor/mpu6050/mpu6050.c +++ b/drivers/sensor/mpu6050/mpu6050.c @@ -171,7 +171,7 @@ int mpu6050_init(struct device *dev) } /* set accelerometer full-scale range */ - for (i = 0; i < 4; i++) { + for (i = 0U; i < 4; i++) { if (BIT(i+1) == CONFIG_MPU6050_ACCEL_FS) { break; } @@ -192,7 +192,7 @@ int mpu6050_init(struct device *dev) drv_data->accel_sensitivity_shift = 14 - i; /* set gyroscope full-scale range */ - for (i = 0; i < 4; i++) { + for (i = 0U; i < 4; i++) { if (BIT(i) * 250 == CONFIG_MPU6050_GYRO_FS) { break; } diff --git a/drivers/sensor/ms5837/ms5837.c b/drivers/sensor/ms5837/ms5837.c index 48f07cb6ea6..b64a4419a5f 100644 --- a/drivers/sensor/ms5837/ms5837.c +++ b/drivers/sensor/ms5837/ms5837.c @@ -24,7 +24,7 @@ static int ms5837_get_measurement(struct device *i2c_master, u8_t adc_read_cmd = MS5837_CMD_CONV_READ_ADC; int err; - *val = 0; + *val = 0U; err = i2c_write(i2c_master, &cmd, 1, i2c_address); if (err < 0) { @@ -163,32 +163,32 @@ static int ms5837_attr_set(struct device *dev, enum sensor_channel chan, case 8192: p_conv_cmd = MS5837_CMD_CONV_P_8192; t_conv_cmd = MS5837_CMD_CONV_T_8192; - conv_delay = 19; + conv_delay = 19U; break; case 4096: p_conv_cmd = MS5837_CMD_CONV_P_4096; t_conv_cmd = MS5837_CMD_CONV_T_4096; - conv_delay = 10; + conv_delay = 10U; break; case 2048: p_conv_cmd = MS5837_CMD_CONV_P_2048; t_conv_cmd = MS5837_CMD_CONV_T_2048; - conv_delay = 5; + conv_delay = 5U; break; case 1024: p_conv_cmd = MS5837_CMD_CONV_P_1024; t_conv_cmd = MS5837_CMD_CONV_T_1024; - conv_delay = 3; + conv_delay = 3U; break; case 512: p_conv_cmd = MS5837_CMD_CONV_P_512; t_conv_cmd = MS5837_CMD_CONV_T_512; - conv_delay = 2; + conv_delay = 2U; break; case 256: p_conv_cmd = MS5837_CMD_CONV_P_256; t_conv_cmd = MS5837_CMD_CONV_T_256; - conv_delay = 1; + conv_delay = 1U; break; default: LOG_ERR("invalid oversampling rate %d", val->val1); @@ -253,9 +253,9 @@ static int ms5837_init(struct device *dev) data->temperature = 0; data->presure_conv_cmd = MS5837_CMD_CONV_P_256; - data->presure_conv_delay = 1; + data->presure_conv_delay = 1U; data->temperature_conv_cmd = MS5837_CMD_CONV_T_256; - data->temperature_conv_delay = 1; + data->temperature_conv_delay = 1U; data->i2c_master = device_get_binding(cfg->i2c_name); if (data->i2c_master == NULL) { diff --git a/drivers/sensor/sht3xd/sht3xd_trigger.c b/drivers/sensor/sht3xd/sht3xd_trigger.c index 77cf40ba519..2c47f4e49ba 100644 --- a/drivers/sensor/sht3xd/sht3xd_trigger.c +++ b/drivers/sensor/sht3xd/sht3xd_trigger.c @@ -158,8 +158,8 @@ int sht3xd_init_interrupt(struct device *dev) { struct sht3xd_data *drv_data = dev->driver_data; - drv_data->t_low = 0; - drv_data->rh_low = 0; + drv_data->t_low = 0U; + drv_data->rh_low = 0U; drv_data->t_high = 0xFFFF; drv_data->rh_high = 0xFFFF; diff --git a/drivers/sensor/th02/th02.c b/drivers/sensor/th02/th02.c index 5c2196dc3ee..158c34e03ea 100644 --- a/drivers/sensor/th02/th02.c +++ b/drivers/sensor/th02/th02.c @@ -47,7 +47,7 @@ static int is_ready(struct device *dev) static u16_t get_humi(struct device *dev) { - u16_t humidity = 0; + u16_t humidity = 0U; if (i2c_reg_write_byte(dev, TH02_I2C_DEV_ID, TH02_REG_CONFIG, TH02_CMD_MEASURE_HUMI) < 0) { @@ -67,7 +67,7 @@ static u16_t get_humi(struct device *dev) u16_t get_temp(struct device *dev) { - u16_t temperature = 0; + u16_t temperature = 0U; if (i2c_reg_write_byte(dev, TH02_I2C_DEV_ID, TH02_REG_CONFIG, TH02_CMD_MEASURE_TEMP) < 0) { diff --git a/drivers/sensor/tmp007/tmp007.c b/drivers/sensor/tmp007/tmp007.c index 26001283e3e..7019fb4fd1c 100644 --- a/drivers/sensor/tmp007/tmp007.c +++ b/drivers/sensor/tmp007/tmp007.c @@ -54,7 +54,7 @@ int tmp007_reg_write(struct tmp007_data *drv_data, u8_t reg, u16_t val) int tmp007_reg_update(struct tmp007_data *drv_data, u8_t reg, u16_t mask, u16_t val) { - u16_t old_val = 0; + u16_t old_val = 0U; u16_t new_val; if (tmp007_reg_read(drv_data, reg, &old_val) < 0) { diff --git a/drivers/sensor/tmp112/tmp112.c b/drivers/sensor/tmp112/tmp112.c index 61c390b82fa..a38342fe114 100644 --- a/drivers/sensor/tmp112/tmp112.c +++ b/drivers/sensor/tmp112/tmp112.c @@ -59,7 +59,7 @@ static int tmp112_reg_write(struct tmp112_data *drv_data, static int tmp112_reg_update(struct tmp112_data *drv_data, u8_t reg, u16_t mask, u16_t val) { - u16_t old_val = 0; + u16_t old_val = 0U; u16_t new_val; if (tmp112_reg_read(drv_data, reg, &old_val) < 0) { diff --git a/drivers/sensor/vl53l0x/vl53l0x.c b/drivers/sensor/vl53l0x/vl53l0x.c index c265915530e..e26326be0e4 100644 --- a/drivers/sensor/vl53l0x/vl53l0x.c +++ b/drivers/sensor/vl53l0x/vl53l0x.c @@ -198,7 +198,7 @@ static int vl53l0x_init(struct device *dev) { struct vl53l0x_data *drv_data = dev->driver_data; VL53L0X_Error ret; - u16_t vl53l0x_id = 0; + u16_t vl53l0x_id = 0U; VL53L0X_DeviceInfo_t vl53l0x_dev_info; LOG_DBG("enter in %s", __func__); diff --git a/drivers/serial/leuart_gecko.c b/drivers/serial/leuart_gecko.c index a3f90ba5240..a667ace38ef 100644 --- a/drivers/serial/leuart_gecko.c +++ b/drivers/serial/leuart_gecko.c @@ -90,7 +90,7 @@ static int leuart_gecko_fifo_fill(struct device *dev, const u8_t *tx_data, int len) { LEUART_TypeDef *base = DEV_BASE(dev); - u8_t num_tx = 0; + u8_t num_tx = 0U; while ((len - num_tx > 0) && (base->STATUS & LEUART_STATUS_TXBL)) { @@ -105,7 +105,7 @@ static int leuart_gecko_fifo_read(struct device *dev, u8_t *rx_data, const int len) { LEUART_TypeDef *base = DEV_BASE(dev); - u8_t num_rx = 0; + u8_t num_rx = 0U; while ((len - num_rx > 0) && (base->STATUS & LEUART_STATUS_RXDATAV)) { diff --git a/drivers/serial/uart_cc32xx.c b/drivers/serial/uart_cc32xx.c index a7179db757f..54a6cf342e0 100644 --- a/drivers/serial/uart_cc32xx.c +++ b/drivers/serial/uart_cc32xx.c @@ -113,7 +113,7 @@ static int uart_cc32xx_err_check(struct device *dev) { const struct uart_device_config *config = DEV_CFG(dev); unsigned long cc32xx_errs = 0L; - unsigned int z_err = 0; + unsigned int z_err = 0U; cc32xx_errs = MAP_UARTRxErrorGet((unsigned long)config->base); @@ -135,7 +135,7 @@ static int uart_cc32xx_fifo_fill(struct device *dev, const u8_t *tx_data, int size) { const struct uart_device_config *config = DEV_CFG(dev); - unsigned int num_tx = 0; + unsigned int num_tx = 0U; while ((size - num_tx) > 0) { /* Send a character */ @@ -154,7 +154,7 @@ static int uart_cc32xx_fifo_read(struct device *dev, u8_t *rx_data, const int size) { const struct uart_device_config *config = DEV_CFG(dev); - unsigned int num_rx = 0; + unsigned int num_rx = 0U; while (((size - num_rx) > 0) && MAP_UARTCharsAvail((unsigned long)config->base)) { diff --git a/drivers/serial/uart_gecko.c b/drivers/serial/uart_gecko.c index 4b30c6e6c05..6eb6cd44207 100644 --- a/drivers/serial/uart_gecko.c +++ b/drivers/serial/uart_gecko.c @@ -80,7 +80,7 @@ static int uart_gecko_fifo_fill(struct device *dev, const u8_t *tx_data, int len) { const struct uart_gecko_config *config = dev->config->config_info; - u8_t num_tx = 0; + u8_t num_tx = 0U; while ((len - num_tx > 0) && (config->base->STATUS & USART_STATUS_TXBL)) { @@ -95,7 +95,7 @@ static int uart_gecko_fifo_read(struct device *dev, u8_t *rx_data, const int len) { const struct uart_gecko_config *config = dev->config->config_info; - u8_t num_rx = 0; + u8_t num_rx = 0U; while ((len - num_rx > 0) && (config->base->STATUS & USART_STATUS_RXDATAV)) { diff --git a/drivers/serial/uart_imx.c b/drivers/serial/uart_imx.c index 93da96daacb..b7e1664221a 100644 --- a/drivers/serial/uart_imx.c +++ b/drivers/serial/uart_imx.c @@ -124,7 +124,7 @@ static int uart_imx_fifo_fill(struct device *dev, const u8_t *tx_data, int size) { UART_Type *uart = UART_STRUCT(dev); - unsigned int num_tx = 0; + unsigned int num_tx = 0U; while (((size - num_tx) > 0) && UART_GetStatusFlag(uart, uartStatusTxReady)) { @@ -140,7 +140,7 @@ static int uart_imx_fifo_read(struct device *dev, u8_t *rx_data, const int size) { UART_Type *uart = UART_STRUCT(dev); - unsigned int num_rx = 0; + unsigned int num_rx = 0U; while (((size - num_rx) > 0) && UART_GetStatusFlag(uart, uartStatusRxReady)) { diff --git a/drivers/serial/uart_mcux.c b/drivers/serial/uart_mcux.c index 60b757a6878..f1604198481 100644 --- a/drivers/serial/uart_mcux.c +++ b/drivers/serial/uart_mcux.c @@ -82,7 +82,7 @@ static int uart_mcux_fifo_fill(struct device *dev, const u8_t *tx_data, int len) { const struct uart_mcux_config *config = dev->config->config_info; - u8_t num_tx = 0; + u8_t num_tx = 0U; while ((len - num_tx > 0) && (UART_GetStatusFlags(config->base) & kUART_TxDataRegEmptyFlag)) { @@ -97,7 +97,7 @@ static int uart_mcux_fifo_read(struct device *dev, u8_t *rx_data, const int len) { const struct uart_mcux_config *config = dev->config->config_info; - u8_t num_rx = 0; + u8_t num_rx = 0U; while ((len - num_rx > 0) && (UART_GetStatusFlags(config->base) & kUART_RxDataRegFullFlag)) { diff --git a/drivers/serial/uart_mcux_lpsci.c b/drivers/serial/uart_mcux_lpsci.c index c1a2af9e42b..9148e6bc0d8 100644 --- a/drivers/serial/uart_mcux_lpsci.c +++ b/drivers/serial/uart_mcux_lpsci.c @@ -83,7 +83,7 @@ static int mcux_lpsci_fifo_fill(struct device *dev, const u8_t *tx_data, int len) { const struct mcux_lpsci_config *config = dev->config->config_info; - u8_t num_tx = 0; + u8_t num_tx = 0U; while ((len - num_tx > 0) && (LPSCI_GetStatusFlags(config->base) @@ -99,7 +99,7 @@ static int mcux_lpsci_fifo_read(struct device *dev, u8_t *rx_data, const int len) { const struct mcux_lpsci_config *config = dev->config->config_info; - u8_t num_rx = 0; + u8_t num_rx = 0U; while ((len - num_rx > 0) && (LPSCI_GetStatusFlags(config->base) diff --git a/drivers/serial/uart_mcux_lpuart.c b/drivers/serial/uart_mcux_lpuart.c index b1ba5517f76..cabcd913920 100644 --- a/drivers/serial/uart_mcux_lpuart.c +++ b/drivers/serial/uart_mcux_lpuart.c @@ -83,7 +83,7 @@ static int mcux_lpuart_fifo_fill(struct device *dev, const u8_t *tx_data, int len) { const struct mcux_lpuart_config *config = dev->config->config_info; - u8_t num_tx = 0; + u8_t num_tx = 0U; while ((len - num_tx > 0) && (LPUART_GetStatusFlags(config->base) @@ -99,7 +99,7 @@ static int mcux_lpuart_fifo_read(struct device *dev, u8_t *rx_data, const int len) { const struct mcux_lpuart_config *config = dev->config->config_info; - u8_t num_rx = 0; + u8_t num_rx = 0U; while ((len - num_rx > 0) && (LPUART_GetStatusFlags(config->base) diff --git a/drivers/serial/uart_msp432p4xx.c b/drivers/serial/uart_msp432p4xx.c index 8ae828f9c3e..9d53db579f1 100644 --- a/drivers/serial/uart_msp432p4xx.c +++ b/drivers/serial/uart_msp432p4xx.c @@ -55,54 +55,54 @@ static int baudrate_set(eUSCI_UART_Config *config, uint32_t baudrate) switch (baudrate) { case 1200: - prescalar = 2500; - first_mod_reg = 0; - second_mod_reg = 0; + prescalar = 2500U; + first_mod_reg = 0U; + second_mod_reg = 0U; break; case 2400: - prescalar = 1250; - first_mod_reg = 0; - second_mod_reg = 0; + prescalar = 1250U; + first_mod_reg = 0U; + second_mod_reg = 0U; break; case 4800: - prescalar = 625; - first_mod_reg = 0; - second_mod_reg = 0; + prescalar = 625U; + first_mod_reg = 0U; + second_mod_reg = 0U; break; case 9600: - prescalar = 312; - first_mod_reg = 8; - second_mod_reg = 0; + prescalar = 312U; + first_mod_reg = 8U; + second_mod_reg = 0U; break; case 19200: - prescalar = 156; - first_mod_reg = 4; - second_mod_reg = 0; + prescalar = 156U; + first_mod_reg = 4U; + second_mod_reg = 0U; break; case 38400: - prescalar = 78; - first_mod_reg = 2; - second_mod_reg = 0; + prescalar = 78U; + first_mod_reg = 2U; + second_mod_reg = 0U; break; case 57600: - prescalar = 52; - first_mod_reg = 1; - second_mod_reg = 37; + prescalar = 52U; + first_mod_reg = 1U; + second_mod_reg = 37U; break; case 115200: - prescalar = 26; - first_mod_reg = 0; - second_mod_reg = 111; + prescalar = 26U; + first_mod_reg = 0U; + second_mod_reg = 111U; break; case 230400: - prescalar = 13; - first_mod_reg = 0; - second_mod_reg = 37; + prescalar = 13U; + first_mod_reg = 0U; + second_mod_reg = 37U; break; case 460800: - prescalar = 6; - first_mod_reg = 8; - second_mod_reg = 32; + prescalar = 6U; + first_mod_reg = 8U; + second_mod_reg = 32U; break; default: return -EINVAL; @@ -176,7 +176,7 @@ static int uart_msp432p4xx_fifo_fill(struct device *dev, const u8_t *tx_data, int size) { const struct uart_device_config *config = DEV_CFG(dev); - unsigned int num_tx = 0; + unsigned int num_tx = 0U; while ((size - num_tx) > 0) { MAP_UART_transmitData((unsigned long)config->base, @@ -196,7 +196,7 @@ static int uart_msp432p4xx_fifo_read(struct device *dev, u8_t *rx_data, const int size) { const struct uart_device_config *config = DEV_CFG(dev); - unsigned int num_rx = 0; + unsigned int num_rx = 0U; while (((size - num_rx) > 0) && MAP_UART_getInterruptStatus((unsigned long)config->base, diff --git a/drivers/serial/uart_nrfx_uart.c b/drivers/serial/uart_nrfx_uart.c index ba25322d7e0..fb8dbbdfd86 100644 --- a/drivers/serial/uart_nrfx_uart.c +++ b/drivers/serial/uart_nrfx_uart.c @@ -66,7 +66,7 @@ static void event_txdrdy_clear(void) { nrf_uart_event_clear(uart0_addr, NRF_UART_EVENT_TXDRDY); #ifdef CONFIG_UART_0_INTERRUPT_DRIVEN - uart_sw_event_txdrdy = 0; + uart_sw_event_txdrdy = 0U; #endif } @@ -224,7 +224,7 @@ static void uart_nrfx_poll_out(struct device *dev, /** Console I/O function */ static int uart_nrfx_err_check(struct device *dev) { - u32_t error = 0; + u32_t error = 0U; if (nrf_uart_event_check(uart0_addr, NRF_UART_EVENT_ERROR)) { /* register bitfields maps to the defines in uart.h */ @@ -298,7 +298,7 @@ static int uart_nrfx_fifo_fill(struct device *dev, const u8_t *tx_data, int len) { - u8_t num_tx = 0; + u8_t num_tx = 0U; while ((len - num_tx > 0) && event_txdrdy_check()) { @@ -318,7 +318,7 @@ static int uart_nrfx_fifo_read(struct device *dev, u8_t *rx_data, const int size) { - u8_t num_rx = 0; + u8_t num_rx = 0U; while ((size - num_rx > 0) && nrf_uart_event_check(uart0_addr, NRF_UART_EVENT_RXDRDY)) { @@ -524,7 +524,7 @@ static int uart_nrfx_init(struct device *dev) /* Simulate that the TXDRDY event is set, so that the transmitter status * is indicated correctly. */ - uart_sw_event_txdrdy = 1; + uart_sw_event_txdrdy = 1U; IRQ_CONNECT(DT_NORDIC_NRF_UART_UART_0_IRQ, DT_NORDIC_NRF_UART_UART_0_IRQ_PRIORITY, diff --git a/drivers/serial/uart_nrfx_uarte.c b/drivers/serial/uart_nrfx_uarte.c index 170b3ffca69..9f908df6201 100644 --- a/drivers/serial/uart_nrfx_uarte.c +++ b/drivers/serial/uart_nrfx_uarte.c @@ -320,7 +320,7 @@ static void uarte_nrfx_poll_out(struct device *dev, static int uarte_nrfx_err_check(struct device *dev) { - u32_t error = 0; + u32_t error = 0U; NRF_UARTE_Type *uarte = get_uarte_instance(dev); if (nrf_uarte_event_check(uarte, NRF_UARTE_EVENT_ERROR)) { diff --git a/drivers/serial/uart_ns16550.c b/drivers/serial/uart_ns16550.c index b66f342998c..c5dac0eef41 100644 --- a/drivers/serial/uart_ns16550.c +++ b/drivers/serial/uart_ns16550.c @@ -310,7 +310,7 @@ static int uart_ns16550_init(struct device *dev) struct uart_ns16550_dev_data_t * const dev_data = DEV_DATA(dev); unsigned int old_level; /* old interrupt lock level */ - u8_t mdc = 0; + u8_t mdc = 0U; if (!ns16550_pci_uart_scan(dev)) { dev->driver_api = NULL; @@ -318,7 +318,7 @@ static int uart_ns16550_init(struct device *dev) } #ifdef CONFIG_UART_INTERRUPT_DRIVEN - dev_data->iir_cache = 0; + dev_data->iir_cache = 0U; #endif old_level = irq_lock(); diff --git a/drivers/serial/uart_sifive.c b/drivers/serial/uart_sifive.c index 0b8bfb46d7e..ebe8143e059 100644 --- a/drivers/serial/uart_sifive.c +++ b/drivers/serial/uart_sifive.c @@ -340,7 +340,7 @@ static int uart_sifive_init(struct device *dev) #ifdef CONFIG_UART_INTERRUPT_DRIVEN /* Ensure that uart IRQ is disabled initially */ - uart->ie = 0; + uart->ie = 0U; /* Setup IRQ handler */ cfg->cfg_func(); diff --git a/drivers/serial/uart_stellaris.c b/drivers/serial/uart_stellaris.c index d33d4b54310..10eeaaab0db 100644 --- a/drivers/serial/uart_stellaris.c +++ b/drivers/serial/uart_stellaris.c @@ -349,7 +349,7 @@ static int uart_stellaris_fifo_fill(struct device *dev, const u8_t *tx_data, int len) { volatile struct _uart *uart = UART_STRUCT(dev); - u8_t num_tx = 0; + u8_t num_tx = 0U; while ((len - num_tx > 0) && ((uart->fr & UARTFR_TXFF) == 0)) { uart->dr = (u32_t)tx_data[num_tx++]; @@ -371,7 +371,7 @@ static int uart_stellaris_fifo_read(struct device *dev, u8_t *rx_data, const int size) { volatile struct _uart *uart = UART_STRUCT(dev); - u8_t num_rx = 0; + u8_t num_rx = 0U; while ((size - num_rx > 0) && ((uart->fr & UARTFR_RXFE) == 0)) { rx_data[num_rx++] = (u8_t)uart->dr; @@ -390,7 +390,7 @@ static int uart_stellaris_fifo_read(struct device *dev, u8_t *rx_data, static void uart_stellaris_irq_tx_enable(struct device *dev) { static u8_t first_time = - 1; /* used to allow the first transmission */ + 1U; /* used to allow the first transmission */ u32_t saved_ctl; /* saved UARTCTL (control) register */ u32_t saved_ibrd; /* saved UARTIBRD (integer baud rate) register */ u32_t saved_fbrd; /* saved UARTFBRD (fractional baud rate) register @@ -405,7 +405,7 @@ static void uart_stellaris_irq_tx_enable(struct device *dev) * work, * so send one via loopback mode. */ - first_time = 0; + first_time = 0U; /* save current control and baud rate settings */ saved_ctl = uart->ctl; @@ -414,11 +414,11 @@ static void uart_stellaris_irq_tx_enable(struct device *dev) /* send a character with default settings via loopback */ disable(dev); - uart->fbrd = 0; - uart->ibrd = 1; - uart->lcrh = 0; + uart->fbrd = 0U; + uart->ibrd = 1U; + uart->lcrh = 0U; uart->ctl = (UARTCTL_UARTEN | UARTCTL_TXEN | UARTCTL_LBE); - uart->dr = 0; + uart->dr = 0U; while (uart->fr & UARTFR_BUSY) ; diff --git a/drivers/serial/uart_stm32.c b/drivers/serial/uart_stm32.c index 6cf43ef1a00..e29aec20019 100644 --- a/drivers/serial/uart_stm32.c +++ b/drivers/serial/uart_stm32.c @@ -81,7 +81,7 @@ static int uart_stm32_fifo_fill(struct device *dev, const u8_t *tx_data, int size) { USART_TypeDef *UartInstance = UART_STRUCT(dev); - u8_t num_tx = 0; + u8_t num_tx = 0U; while ((size - num_tx > 0) && LL_USART_IsActiveFlag_TXE(UartInstance)) { @@ -98,7 +98,7 @@ static int uart_stm32_fifo_read(struct device *dev, u8_t *rx_data, const int size) { USART_TypeDef *UartInstance = UART_STRUCT(dev); - u8_t num_rx = 0; + u8_t num_rx = 0U; while ((size - num_rx > 0) && LL_USART_IsActiveFlag_RXNE(UartInstance)) { diff --git a/drivers/spi/spi_dw.c b/drivers/spi/spi_dw.c index 1cecade00cb..a6d9c9191f2 100644 --- a/drivers/spi/spi_dw.c +++ b/drivers/spi/spi_dw.c @@ -87,7 +87,7 @@ static void push_data(struct device *dev) { const struct spi_dw_config *info = dev->config->config_info; struct spi_dw_data *spi = dev->driver_data; - u32_t data = 0; + u32_t data = 0U; u32_t f_tx; DBG_COUNTER_INIT(); @@ -96,7 +96,7 @@ static void push_data(struct device *dev) f_tx = DW_SPI_FIFO_DEPTH - read_txflr(info->regs) - read_rxflr(info->regs); if ((int)f_tx < 0) { - f_tx = 0; /* if rx-fifo is full, hold off tx */ + f_tx = 0U; /* if rx-fifo is full, hold off tx */ } } else { f_tx = DW_SPI_FIFO_DEPTH - read_txflr(info->regs); @@ -126,9 +126,9 @@ static void push_data(struct device *dev) break; } - data = 0; + data = 0U; } else if (spi_context_tx_on(&spi->ctx)) { - data = 0; + data = 0U; } else { /* Nothing to push anymore */ break; @@ -197,7 +197,7 @@ static int spi_dw_configure(const struct spi_dw_config *info, struct spi_dw_data *spi, const struct spi_config *config) { - u32_t ctrlr0 = 0; + u32_t ctrlr0 = 0U; LOG_DBG("%p (prev %p)", config, spi->ctx.config); @@ -290,7 +290,7 @@ static int spi_dw_configure(const struct spi_dw_config *info, static uint32_t spi_dw_compute_ndf(const struct spi_buf *rx_bufs, size_t rx_count, u8_t dfs) { - u32_t len = 0; + u32_t len = 0U; for (; rx_count; rx_bufs++, rx_count--) { if (len > (UINT16_MAX - rx_bufs->len)) { @@ -314,7 +314,7 @@ static void spi_dw_update_txftlr(const struct spi_dw_config *info, if (spi_dw_is_slave(spi)) { if (!spi->ctx.tx_len) { - reg_data = 0; + reg_data = 0U; } else if (spi->ctx.tx_len < DW_SPI_TXFTLR_DFLT) { reg_data = spi->ctx.tx_len - 1; } @@ -388,7 +388,7 @@ static int transceive(struct device *dev, /* Set buffers info */ spi_context_buffers_setup(&spi->ctx, tx_bufs, rx_bufs, spi->dfs); - spi->fifo_diff = 0; + spi->fifo_diff = 0U; /* Tx Threshold */ spi_dw_update_txftlr(info, spi); diff --git a/drivers/spi/spi_intel.c b/drivers/spi/spi_intel.c index c1610fd0080..77eb74f0a03 100644 --- a/drivers/spi/spi_intel.c +++ b/drivers/spi/spi_intel.c @@ -85,7 +85,7 @@ static void push_data(struct device *dev) u32_t status; while ((status = read_sssr(spi->regs)) & INTEL_SPI_SSSR_TNF) { - u32_t data = 0; + u32_t data = 0U; if (status & INTEL_SPI_SSSR_RFS) { break; @@ -255,7 +255,7 @@ static int spi_intel_release(struct device *dev, void spi_intel_isr(struct device *dev) { struct spi_intel_data *spi = dev->driver_data; - u32_t error = 0; + u32_t error = 0U; u32_t status; LOG_DBG("%p", dev); @@ -264,7 +264,7 @@ void spi_intel_isr(struct device *dev) if (status & INTEL_SPI_SSSR_ROR) { /* Unrecoverable error, ack it */ clear_bit_sssr_ror(spi->regs); - error = 1; + error = 1U; goto out; } diff --git a/drivers/spi/spi_sam.c b/drivers/spi/spi_sam.c index c481f3e7ea2..70bbefcab3a 100644 --- a/drivers/spi/spi_sam.c +++ b/drivers/spi/spi_sam.c @@ -52,7 +52,7 @@ static int spi_sam_configure(struct device *dev, const struct spi_sam_config *cfg = dev->config->config_info; struct spi_sam_data *data = dev->driver_data; Spi *regs = cfg->regs; - u32_t spi_mr = 0, spi_csr = 0; + u32_t spi_mr = 0U, spi_csr = 0U; int div; if (spi_context_configured(&data->ctx, config)) { @@ -120,7 +120,7 @@ static void spi_sam_shift_master(Spi *regs, struct spi_sam_data *data) if (spi_context_tx_buf_on(&data->ctx)) { tx = *(u8_t *)(data->ctx.tx_buf); } else { - tx = 0; + tx = 0U; } while ((regs->SPI_SR & SPI_SR_TDRE) == 0) { diff --git a/drivers/spi/spi_sam0.c b/drivers/spi/spi_sam0.c index 043b27467d1..6a148a92e68 100644 --- a/drivers/spi/spi_sam0.c +++ b/drivers/spi/spi_sam0.c @@ -131,7 +131,7 @@ static void spi_sam0_shift_master(SercomSpi *regs, struct spi_sam0_data *data) if (spi_context_tx_buf_on(&data->ctx)) { tx = *(u8_t *)(data->ctx.tx_buf); } else { - tx = 0; + tx = 0U; } while (!regs->INTFLAG.bit.DRE) { diff --git a/drivers/timer/arcv2_timer0.c b/drivers/timer/arcv2_timer0.c index 609e8d21499..5c720d840f8 100644 --- a/drivers/timer/arcv2_timer0.c +++ b/drivers/timer/arcv2_timer0.c @@ -277,7 +277,7 @@ u32_t _get_elapsed_program_time(void) void _set_time(u32_t time) { if (!time) { - programmed_ticks = 0; + programmed_ticks = 0U; return; } diff --git a/drivers/timer/cortex_m_systick.c b/drivers/timer/cortex_m_systick.c index c19e886c7d8..81fb95037e9 100644 --- a/drivers/timer/cortex_m_systick.c +++ b/drivers/timer/cortex_m_systick.c @@ -58,7 +58,7 @@ void _timer_int_handler(void *arg) announced_cycles += dticks * CYC_PER_TICK; ctrl_cache = SysTick->CTRL; /* Reset overflow flag */ - ctrl_cache = 0; + ctrl_cache = 0U; z_clock_announce(TICKLESS ? dticks : 1); _ExcExit(); diff --git a/drivers/timer/loapic_timer.c b/drivers/timer/loapic_timer.c index 5507fe81d2d..5203be46564 100644 --- a/drivers/timer/loapic_timer.c +++ b/drivers/timer/loapic_timer.c @@ -315,7 +315,7 @@ void _timer_int_handler(void *unused /* parameter is not used */ * that recursive calls to _update_elapsed_time() will not * announce already consumed elapsed time */ - programmed_full_ticks = 0; + programmed_full_ticks = 0U; z_clock_announce(_sys_idle_elapsed_ticks); @@ -407,7 +407,7 @@ u32_t _get_elapsed_program_time(void) void _set_time(u32_t time) { if (!time) { - programmed_full_ticks = 0; + programmed_full_ticks = 0U; return; } @@ -489,8 +489,8 @@ void _timer_idle_enter(s32_t ticks /* system ticks */ _set_time(ticks); } } else { - programmed_full_ticks = 0; - programmed_cycles = 0; + programmed_full_ticks = 0U; + programmed_cycles = 0U; initial_count_register_set(0); /* 0 disables timer */ } #else diff --git a/drivers/timer/pulpino_timer.c b/drivers/timer/pulpino_timer.c index dec242c6a74..7a5d03e28b6 100644 --- a/drivers/timer/pulpino_timer.c +++ b/drivers/timer/pulpino_timer.c @@ -28,7 +28,7 @@ static void pulpino_timer_irq_handler(void *unused) ARG_UNUSED(unused); /* Reset counter */ - timer->val = 0; + timer->val = 0U; accumulated_cycle_count += sys_clock_hw_cycles_per_tick(); @@ -51,7 +51,7 @@ int z_clock_driver_init(struct device *device) * Reset counter and set timer to generate interrupt * every sys_clock_hw_cycles_per_tick() */ - timer->val = 0; + timer->val = 0U; timer->cmp = sys_clock_hw_cycles_per_tick(); timer->ctrl = TIMER_CTRL_EN; diff --git a/drivers/usb/device/usb_dc_dw.c b/drivers/usb/device/usb_dc_dw.c index bab3128986c..6918cac52fc 100644 --- a/drivers/usb/device/usb_dc_dw.c +++ b/drivers/usb/device/usb_dc_dw.c @@ -88,7 +88,7 @@ static void usb_dw_reg_dump(void) LOG_DBG(" GHWCFG3 : 0x%x GHWCFG4 : 0x%x", USB_DW->ghwcfg3, USB_DW->ghwcfg4); - for (i = 0; i < USB_DW_OUT_EP_NUM; i++) { + for (i = 0U; i < USB_DW_OUT_EP_NUM; i++) { LOG_DBG("\n EP %d registers: DIEPCTL : 0x%x DIEPINT : " "0x%x", i, USB_DW->in_ep_reg[i].diepctl, USB_DW->in_ep_reg[i].diepint); @@ -142,7 +142,7 @@ static inline void usb_dw_udelay(u32_t us) static int usb_dw_reset(void) { - u32_t cnt = 0; + u32_t cnt = 0U; /* Wait for AHB master idle state. */ while (!(USB_DW->grstctl & USB_DW_GRSTCTL_AHB_IDLE)) { @@ -155,7 +155,7 @@ static int usb_dw_reset(void) } /* Core Soft Reset */ - cnt = 0; + cnt = 0U; USB_DW->grstctl |= USB_DW_GRSTCTL_C_SFT_RST; do { if (++cnt > USB_DW_CORE_RST_TIMEOUT_US) { @@ -458,7 +458,7 @@ static int usb_dw_tx(u8_t ep, const u8_t *const data, } } else { /* Zero length packet */ - pkt_cnt = 1; + pkt_cnt = 1U; } /* Set number of packets and transfer size */ @@ -478,7 +478,7 @@ static int usb_dw_tx(u8_t ep, const u8_t *const data, * to access a FIFO, the application must complete the transaction * before accessing the register." */ - for (i = 0; i < data_len; i += 4) { + for (i = 0U; i < data_len; i += 4) { u32_t val = data[i]; if (i + 1 < data_len) { @@ -522,7 +522,7 @@ static int usb_dw_init(void) #endif /* Set NAK for all OUT EPs */ - for (ep = 0; ep < USB_DW_OUT_EP_NUM; ep++) { + for (ep = 0U; ep < USB_DW_OUT_EP_NUM; ep++) { USB_DW->out_ep_reg[ep].doepctl = USB_DW_DEPCTL_SNAK; } @@ -558,7 +558,7 @@ static void usb_dw_handle_reset(void) USB_DW->dcfg &= ~USB_DW_DCFG_DEV_ADDR_MASK; /* enable global EP interrupts */ - USB_DW->doepmsk = 0; + USB_DW->doepmsk = 0U; USB_DW->gintmsk |= USB_DW_GINTSTS_RX_FLVL; USB_DW->diepmsk |= USB_DW_DIEPINT_XFER_COMPL; } @@ -666,7 +666,7 @@ static void usb_dw_isr_handler(void) if (int_status & USB_DW_GINTSTS_IEP_INT) { /* IN EP interrupt */ - for (ep_idx = 0; ep_idx < USB_DW_IN_EP_NUM; ep_idx++) { + for (ep_idx = 0U; ep_idx < USB_DW_IN_EP_NUM; ep_idx++) { if (USB_DW->daint & USB_DW_DAINT_IN_EP_INT(ep_idx)) { /* Read IN EP interrupt status */ @@ -706,7 +706,7 @@ static void usb_dw_isr_handler(void) /* No OUT interrupt expected in FIFO mode, * just clear interruot */ - for (ep_idx = 0; ep_idx < USB_DW_OUT_EP_NUM; ep_idx++) { + for (ep_idx = 0U; ep_idx < USB_DW_OUT_EP_NUM; ep_idx++) { if (USB_DW->daint & USB_DW_DAINT_OUT_EP_INT(ep_idx)) { /* Read OUT EP interrupt status */ @@ -754,7 +754,7 @@ int usb_dc_attach(void) _usb_dw_int_unmask(); - usb_dw_ctrl.attached = 1; + usb_dw_ctrl.attached = 1U; return 0; } @@ -772,7 +772,7 @@ int usb_dc_detach(void) /* Enable soft disconnect */ USB_DW->dctl |= USB_DW_DCTL_SFT_DISCON; - usb_dw_ctrl.attached = 0; + usb_dw_ctrl.attached = 0U; return 0; } @@ -926,14 +926,14 @@ int usb_dc_ep_is_stalled(const u8_t ep, u8_t *const stalled) return -EINVAL; } - *stalled = 0; + *stalled = 0U; if (USB_DW_EP_ADDR2DIR(ep) == USB_EP_DIR_OUT) { if (USB_DW->out_ep_reg[ep_idx].doepctl & USB_DW_DEPCTL_STALL) { - *stalled = 1; + *stalled = 1U; } } else { if (USB_DW->in_ep_reg[ep_idx].diepctl & USB_DW_DEPCTL_STALL) { - *stalled = 1; + *stalled = 1U; } } @@ -958,10 +958,10 @@ int usb_dc_ep_enable(const u8_t ep) /* Activate Ep */ if (USB_DW_EP_ADDR2DIR(ep) == USB_EP_DIR_OUT) { USB_DW->out_ep_reg[ep_idx].doepctl |= USB_DW_DEPCTL_USB_ACT_EP; - usb_dw_ctrl.out_ep_ctrl[ep_idx].ep_ena = 1; + usb_dw_ctrl.out_ep_ctrl[ep_idx].ep_ena = 1U; } else { USB_DW->in_ep_reg[ep_idx].diepctl |= USB_DW_DEPCTL_USB_ACT_EP; - usb_dw_ctrl.in_ep_ctrl[ep_idx].ep_ena = 1; + usb_dw_ctrl.in_ep_ctrl[ep_idx].ep_ena = 1U; } if (USB_DW_EP_ADDR2DIR(ep) == USB_EP_DIR_OUT && @@ -993,13 +993,13 @@ int usb_dc_ep_disable(const u8_t ep) ~(USB_DW_DEPCTL_USB_ACT_EP | USB_DW_DEPCTL_EP_ENA | USB_DW_DEPCTL_SNAK); - usb_dw_ctrl.out_ep_ctrl[ep_idx].ep_ena = 0; + usb_dw_ctrl.out_ep_ctrl[ep_idx].ep_ena = 0U; } else { USB_DW->in_ep_reg[ep_idx].diepctl &= ~(USB_DW_DEPCTL_USB_ACT_EP | USB_DW_DEPCTL_EP_ENA | USB_DW_DEPCTL_SNAK); - usb_dw_ctrl.in_ep_ctrl[ep_idx].ep_ena = 0; + usb_dw_ctrl.in_ep_ctrl[ep_idx].ep_ena = 0U; } return 0; @@ -1023,7 +1023,7 @@ int usb_dc_ep_flush(const u8_t ep) USB_DW->grstctl |= ep_idx << USB_DW_GRSTCTL_TX_FNUM_OFFSET; USB_DW->grstctl |= USB_DW_GRSTCTL_TX_FFLSH; - cnt = 0; + cnt = 0U; do { if (++cnt > USB_DW_CORE_RST_TIMEOUT_US) { LOG_ERR("USB TX FIFO flush HANG!"); @@ -1119,14 +1119,14 @@ int usb_dc_ep_read_wait(u8_t ep, u8_t *data, u32_t max_data_len, bytes_to_copy); /* Data in the FIFOs is always stored per 32-bit words */ - for (i = 0; i < (bytes_to_copy & ~0x3); i += 4) { + for (i = 0U; i < (bytes_to_copy & ~0x3); i += 4) { *(u32_t *)(data + i) = USB_DW_EP_FIFO(ep_idx); } if (bytes_to_copy & 0x3) { /* Not multiple of 4 */ u32_t last_dw = USB_DW_EP_FIFO(ep_idx); - for (j = 0; j < (bytes_to_copy & 0x3); j++) { + for (j = 0U; j < (bytes_to_copy & 0x3); j++) { *(data + i + j) = (sys_cpu_to_le32(last_dw) >> (8 * j)) & 0xFF; } diff --git a/drivers/usb/device/usb_dc_kinetis.c b/drivers/usb/device/usb_dc_kinetis.c index c43e5959075..a87c833f154 100644 --- a/drivers/usb/device/usb_dc_kinetis.c +++ b/drivers/usb/device/usb_dc_kinetis.c @@ -193,8 +193,8 @@ int usb_dc_reset(void) USB0->ENDPOINT[i].ENDPT = 0; } (void)memset(bdt, 0, sizeof(bdt)); - dev_data.bd_active = 0; - dev_data.address = 0; + dev_data.bd_active = 0U; + dev_data.address = 0U; USB0->CTL |= USB_CTL_ODDRST_MASK; USB0->CTL &= ~USB_CTL_ODDRST_MASK; @@ -399,11 +399,11 @@ int usb_dc_ep_set_stall(const u8_t ep) LOG_DBG("ep %x, idx %d", ep, ep_idx); if (EP_ADDR2DIR(ep) == USB_EP_DIR_OUT) { - dev_data.ep_ctrl[ep_idx].status.out_stalled = 1; + dev_data.ep_ctrl[ep_idx].status.out_stalled = 1U; bd_idx = get_bdt_idx(ep, ~dev_data.ep_ctrl[ep_idx].status.out_odd); } else { - dev_data.ep_ctrl[ep_idx].status.in_stalled = 1; + dev_data.ep_ctrl[ep_idx].status.in_stalled = 1U; bd_idx = get_bdt_idx(ep, dev_data.ep_ctrl[ep_idx].status.in_odd); } @@ -427,18 +427,18 @@ int usb_dc_ep_clear_stall(const u8_t ep) USB0->ENDPOINT[ep_idx].ENDPT &= ~USB_ENDPT_EPSTALL_MASK; if (EP_ADDR2DIR(ep) == USB_EP_DIR_OUT) { - dev_data.ep_ctrl[ep_idx].status.out_stalled = 0; + dev_data.ep_ctrl[ep_idx].status.out_stalled = 0U; dev_data.ep_ctrl[ep_idx].status.out_data1 = false; bd_idx = get_bdt_idx(ep, ~dev_data.ep_ctrl[ep_idx].status.out_odd); - bdt[bd_idx].set.bd_ctrl = 0; + bdt[bd_idx].set.bd_ctrl = 0U; bdt[bd_idx].set.bd_ctrl = BD_DTS_MASK | BD_OWN_MASK; } else { - dev_data.ep_ctrl[ep_idx].status.in_stalled = 0; + dev_data.ep_ctrl[ep_idx].status.in_stalled = 0U; dev_data.ep_ctrl[ep_idx].status.in_data1 = false; bd_idx = get_bdt_idx(ep, dev_data.ep_ctrl[ep_idx].status.in_odd); - bdt[bd_idx].set.bd_ctrl = 0; + bdt[bd_idx].set.bd_ctrl = 0U; } /* Resume TX token processing, see USBx_CTL field descriptions */ @@ -463,7 +463,7 @@ int usb_dc_ep_is_stalled(const u8_t ep, u8_t *const stalled) return -EINVAL; } - *stalled = 0; + *stalled = 0U; if (EP_ADDR2DIR(ep) == USB_EP_DIR_OUT) { *stalled = dev_data.ep_ctrl[ep_idx].status.out_stalled; } else { @@ -504,16 +504,16 @@ int usb_dc_ep_enable(const u8_t ep) if (EP_ADDR2DIR(ep) == USB_EP_DIR_OUT) { bdt[idx_even].set.bd_ctrl = BD_DTS_MASK | BD_OWN_MASK; - bdt[idx_odd].set.bd_ctrl = 0; - dev_data.ep_ctrl[ep_idx].status.out_odd = 0; - dev_data.ep_ctrl[ep_idx].status.out_stalled = 0; + bdt[idx_odd].set.bd_ctrl = 0U; + dev_data.ep_ctrl[ep_idx].status.out_odd = 0U; + dev_data.ep_ctrl[ep_idx].status.out_stalled = 0U; dev_data.ep_ctrl[ep_idx].status.out_data1 = false; dev_data.ep_ctrl[ep_idx].status.out_enabled = true; } else { - bdt[idx_even].bd_fields = 0; - bdt[idx_odd].bd_fields = 0; - dev_data.ep_ctrl[ep_idx].status.in_odd = 0; - dev_data.ep_ctrl[ep_idx].status.in_stalled = 0; + bdt[idx_even].bd_fields = 0U; + bdt[idx_odd].bd_fields = 0U; + dev_data.ep_ctrl[ep_idx].status.in_odd = 0U; + dev_data.ep_ctrl[ep_idx].status.in_stalled = 0U; dev_data.ep_ctrl[ep_idx].status.in_data1 = false; dev_data.ep_ctrl[ep_idx].status.in_enabled = true; } @@ -536,8 +536,8 @@ int usb_dc_ep_disable(const u8_t ep) LOG_INF("ep %x, idx %d", ep_idx, ep); - bdt[idx_even].bd_fields = 0; - bdt[idx_odd].bd_fields = 0; + bdt[idx_even].bd_fields = 0U; + bdt[idx_odd].bd_fields = 0U; if (EP_ADDR2DIR(ep) == USB_EP_DIR_OUT) { dev_data.ep_ctrl[ep_idx].status.out_enabled = false; } else { @@ -821,7 +821,7 @@ static void usb_kinetis_isr_handler(void) if (istatus & USB_ISTAT_USBRST_MASK) { - dev_data.address = 0; + dev_data.address = 0U; USB0->ADDR = (u8_t)0; /* * Device reset is not possible because the stack does not @@ -832,7 +832,7 @@ static void usb_kinetis_isr_handler(void) USB0->CTL |= USB_CTL_ODDRST_MASK; USB0->CTL &= ~USB_CTL_ODDRST_MASK; reenable_all_endpoints(); - msg.ep = 0; + msg.ep = 0U; msg.type = USB_DC_CB_TYPE_MGMT; msg.cb = USB_DC_RESET; k_msgq_put(&usb_dc_msgq, &msg, K_NO_WAIT); @@ -840,7 +840,7 @@ static void usb_kinetis_isr_handler(void) if (istatus == USB_ISTAT_ERROR_MASK) { USB0->ERRSTAT = 0xFF; - msg.ep = 0; + msg.ep = 0U; msg.type = USB_DC_CB_TYPE_MGMT; msg.cb = USB_DC_ERROR; k_msgq_put(&usb_dc_msgq, &msg, K_NO_WAIT); @@ -870,8 +870,8 @@ static void usb_kinetis_isr_handler(void) case KINETIS_SETUP_TOKEN: dev_data.ep_ctrl[ep_idx].status.out_odd = odd; /* clear tx entries */ - bdt[BD_IDX_EP0TX_EVEN].bd_fields = 0; - bdt[BD_IDX_EP0TX_ODD].bd_fields = 0; + bdt[BD_IDX_EP0TX_EVEN].bd_fields = 0U; + bdt[BD_IDX_EP0TX_ODD].bd_fields = 0U; /* * Set/Reset here the toggle bits for control endpoint * because the device stack does not care about it. @@ -893,7 +893,7 @@ static void usb_kinetis_isr_handler(void) /* SET ADDRESS workaround */ if (dev_data.address & 0x80) { USB0->ADDR = dev_data.address & 0x7f; - dev_data.address = 0; + dev_data.address = 0U; } msg.cb = USB_DC_EP_DATA_IN; @@ -907,7 +907,7 @@ static void usb_kinetis_isr_handler(void) if (istatus & USB_ISTAT_SLEEP_MASK) { /* Enable resume interrupt */ USB0->INTEN |= USB_INTEN_RESUMEEN_MASK; - msg.ep = 0; + msg.ep = 0U; msg.type = USB_DC_CB_TYPE_MGMT; msg.cb = USB_DC_SUSPEND; k_msgq_put(&usb_dc_msgq, &msg, K_NO_WAIT); @@ -916,7 +916,7 @@ static void usb_kinetis_isr_handler(void) if (istatus & USB_ISTAT_RESUME_MASK) { /* Disable resume interrupt */ USB0->INTEN &= ~USB_INTEN_RESUMEEN_MASK; - msg.ep = 0; + msg.ep = 0U; msg.type = USB_DC_CB_TYPE_MGMT; msg.cb = USB_DC_RESUME; k_msgq_put(&usb_dc_msgq, &msg, K_NO_WAIT); diff --git a/drivers/usb/device/usb_dc_nrfx.c b/drivers/usb/device/usb_dc_nrfx.c index 8a4a1678206..4dbcfe2125b 100644 --- a/drivers/usb/device/usb_dc_nrfx.c +++ b/drivers/usb/device/usb_dc_nrfx.c @@ -388,7 +388,7 @@ static inline struct usbd_ep_event *usbd_evt_alloc(void) ev = (struct usbd_ep_event *)block.data; ev->block = block; - ev->misc_u.flags = 0; + ev->misc_u.flags = 0U; return ev; } @@ -535,7 +535,7 @@ static void ep_ctx_reset(struct nrf_usbd_ep_ctx *ep_ctx) { ep_ctx->buf.data = ep_ctx->buf.block.data; ep_ctx->buf.curr = ep_ctx->buf.data; - ep_ctx->buf.len = 0; + ep_ctx->buf.len = 0U; ep_ctx->read_complete = true; ep_ctx->read_pending = false; @@ -555,7 +555,7 @@ static int eps_ctx_init(void) int err; u32_t i; - for (i = 0; i < CFG_EPIN_CNT; i++) { + for (i = 0U; i < CFG_EPIN_CNT; i++) { ep_ctx = in_endpoint_ctx(i); __ASSERT_NO_MSG(ep_ctx); @@ -571,7 +571,7 @@ static int eps_ctx_init(void) ep_ctx_reset(ep_ctx); } - for (i = 0; i < CFG_EPOUT_CNT; i++) { + for (i = 0U; i < CFG_EPOUT_CNT; i++) { ep_ctx = out_endpoint_ctx(i); __ASSERT_NO_MSG(ep_ctx); @@ -627,14 +627,14 @@ static void eps_ctx_uninit(void) struct nrf_usbd_ep_ctx *ep_ctx; u32_t i; - for (i = 0; i < CFG_EPIN_CNT; i++) { + for (i = 0U; i < CFG_EPIN_CNT; i++) { ep_ctx = in_endpoint_ctx(i); __ASSERT_NO_MSG(ep_ctx); k_mem_pool_free(&ep_ctx->buf.block); memset(ep_ctx, 0, sizeof(*ep_ctx)); } - for (i = 0; i < CFG_EPOUT_CNT; i++) { + for (i = 0U; i < CFG_EPOUT_CNT; i++) { ep_ctx = out_endpoint_ctx(i); __ASSERT_NO_MSG(ep_ctx); k_mem_pool_free(&ep_ctx->buf.block); @@ -1121,7 +1121,7 @@ int usb_dc_detach(void) k_mutex_lock(&ctx->drv_lock, K_FOREVER); - ctx->flags = 0; + ctx->flags = 0U; ctx->state = USBD_DETACHED; ctx->status_code = USB_DC_UNKNOWN; @@ -1279,7 +1279,7 @@ int usb_dc_ep_set_stall(const u8_t ep) return -EINVAL; } - ep_ctx->buf.len = 0; + ep_ctx->buf.len = 0U; ep_ctx->buf.curr = ep_ctx->buf.data; LOG_DBG("STALL on EP %d.", ep); @@ -1397,7 +1397,7 @@ int usb_dc_ep_flush(const u8_t ep) return -EINVAL; } - ep_ctx->buf.len = 0; + ep_ctx->buf.len = 0U; ep_ctx->buf.curr = ep_ctx->buf.data; nrfx_usbd_transfer_out_drop(ep_addr_to_nrfx(ep)); diff --git a/drivers/usb/device/usb_dc_sam.c b/drivers/usb/device/usb_dc_sam.c index 5ca69b5a605..0eeeab9a7b4 100644 --- a/drivers/usb/device/usb_dc_sam.c +++ b/drivers/usb/device/usb_dc_sam.c @@ -422,7 +422,7 @@ int usb_dc_ep_configure(const struct usb_dc_ep_cfg_data *const cfg) u8_t ep_idx = EP_ADDR2IDX(cfg->ep_addr); bool ep_configured[DT_USBHS_NUM_BIDIR_EP]; bool ep_enabled[DT_USBHS_NUM_BIDIR_EP]; - u32_t regval = 0; + u32_t regval = 0U; int log2ceil_mps; if (usb_dc_ep_check_cap(cfg) != 0) { diff --git a/drivers/usb/device/usb_dc_sam0.c b/drivers/usb/device/usb_dc_sam0.c index 20708bf1883..813e2505ca0 100644 --- a/drivers/usb/device/usb_dc_sam0.c +++ b/drivers/usb/device/usb_dc_sam0.c @@ -75,7 +75,7 @@ static void usb_sam0_ep_isr(u8_t ep) * completes else the ack will get dropped. */ regs->DADD.reg = data->addr; - data->addr = 0; + data->addr = 0U; } } } @@ -106,7 +106,7 @@ static void usb_sam0_isr(void) } /* Dispatch the endpoint interrupts */ - for (ep = 0; epint != 0; epint >>= 1) { + for (ep = 0U; epint != 0; epint >>= 1) { /* Scan bit-by-bit as the Cortex-M0 doesn't have ffs */ if ((epint & 1) != 0) { usb_sam0_ep_isr(ep); @@ -138,7 +138,7 @@ static void usb_sam0_load_padcal(void) ((1 << NVM_USB_PAD_TRANSN_SIZE) - 1); if (pad_transn == 0x1F) { - pad_transn = 5; + pad_transn = 5U; } regs->PADCAL.bit.TRANSN = pad_transn; @@ -149,7 +149,7 @@ static void usb_sam0_load_padcal(void) ((1 << NVM_USB_PAD_TRANSP_SIZE) - 1); if (pad_transp == 0x1F) { - pad_transp = 29; + pad_transp = 29U; } regs->PADCAL.bit.TRANSP = pad_transp; @@ -160,7 +160,7 @@ static void usb_sam0_load_padcal(void) ((1 << NVM_USB_PAD_TRIM_SIZE) - 1); if (pad_trim == 0x7) { - pad_trim = 3; + pad_trim = 3U; } regs->PADCAL.bit.TRIM = pad_trim; @@ -480,7 +480,7 @@ int usb_dc_ep_read_ex(u8_t ep, u8_t *buf, u32_t max_data_len, * also marks the OUT buffer as freed. */ if (buf == NULL) { - data->out_at = 0; + data->out_at = 0U; if (read_bytes != NULL) { *read_bytes = bytes; @@ -500,7 +500,7 @@ int usb_dc_ep_read_ex(u8_t ep, u8_t *buf, u32_t max_data_len, if (take == remain) { if (!wait) { endpoint->EPSTATUSCLR.bit.BK0RDY = 1; - data->out_at = 0; + data->out_at = 0U; } } else { data->out_at += take; @@ -528,7 +528,7 @@ int usb_dc_ep_read_continue(u8_t ep) UsbDeviceEndpoint *endpoint = ®s->DeviceEndpoint[ep_num]; endpoint->EPSTATUSCLR.bit.BK0RDY = 1; - data->out_at = 0; + data->out_at = 0U; return 0; } diff --git a/drivers/usb/device/usb_dc_stm32.c b/drivers/usb/device/usb_dc_stm32.c index 314026b4bc3..e641ada2230 100644 --- a/drivers/usb/device/usb_dc_stm32.c +++ b/drivers/usb/device/usb_dc_stm32.c @@ -365,13 +365,13 @@ static int usb_dc_stm32_init(void) /* Start PMA configuration for the endpoints after the BTABLE. */ usb_dc_stm32_state.pma_offset = USB_BTABLE_SIZE; - for (i = 0; i < DT_USB_NUM_BIDIR_ENDPOINTS; i++) { + for (i = 0U; i < DT_USB_NUM_BIDIR_ENDPOINTS; i++) { k_sem_init(&usb_dc_stm32_state.in_ep_state[i].write_sem, 1, 1); } #else /* USB_OTG_FS */ /* TODO: make this dynamic (depending usage) */ HAL_PCDEx_SetRxFiFo(&usb_dc_stm32_state.pcd, FIFO_EP_WORDS); - for (i = 0; i < DT_USB_NUM_BIDIR_ENDPOINTS; i++) { + for (i = 0U; i < DT_USB_NUM_BIDIR_ENDPOINTS; i++) { HAL_PCDEx_SetTxFiFo(&usb_dc_stm32_state.pcd, i, FIFO_EP_WORDS); k_sem_init(&usb_dc_stm32_state.in_ep_state[i].write_sem, 1, 1); @@ -595,7 +595,7 @@ int usb_dc_ep_set_stall(const u8_t ep) return -EIO; } - ep_state->ep_stalled = 1; + ep_state->ep_stalled = 1U; return 0; } @@ -618,8 +618,8 @@ int usb_dc_ep_clear_stall(const u8_t ep) return -EIO; } - ep_state->ep_stalled = 0; - ep_state->read_count = 0; + ep_state->ep_stalled = 0U; + ep_state->read_count = 0U; return 0; } @@ -884,7 +884,7 @@ void HAL_PCD_SetupStageCallback(PCD_HandleTypeDef *hpcd) ep_state = usb_dc_stm32_get_ep_state(EP0_OUT); /* can't fail for ep0 */ ep_state->read_count = SETUP_SIZE; - ep_state->read_offset = 0; + ep_state->read_offset = 0U; memcpy(&usb_dc_stm32_state.ep_buf[EP0_IDX], usb_dc_stm32_state.pcd.Setup, ep_state->read_count); @@ -914,7 +914,7 @@ void HAL_PCD_DataOutStageCallback(PCD_HandleTypeDef *hpcd, u8_t epnum) * for the upper stack (usb_dc_ep_read to retrieve). */ usb_dc_ep_get_read_count(ep, &ep_state->read_count); - ep_state->read_offset = 0; + ep_state->read_offset = 0U; if (ep_state->cb) { ep_state->cb(ep, USB_DC_EP_DATA_OUT); diff --git a/drivers/watchdog/iwdg_stm32.c b/drivers/watchdog/iwdg_stm32.c index c143ac07f8d..77da9f47e0d 100644 --- a/drivers/watchdog/iwdg_stm32.c +++ b/drivers/watchdog/iwdg_stm32.c @@ -42,8 +42,8 @@ static void iwdg_stm32_convert_timeout(u32_t timeout, { assert(IS_IWDG_TIMEOUT(timeout)); - u16_t divider = 0; - u8_t shift = 0; + u16_t divider = 0U; + u8_t shift = 0U; /* Convert timeout to seconds. */ float m_timeout = (float)timeout / 1000000 * LSI_VALUE; @@ -81,8 +81,8 @@ static int iwdg_stm32_set_config(struct device *dev, { IWDG_TypeDef *iwdg = IWDG_STM32_STRUCT(dev); u32_t timeout = config->timeout; - u32_t prescaler = 0; - u32_t reload = 0; + u32_t prescaler = 0U; + u32_t reload = 0U; u32_t tickstart; assert(IS_IWDG_TIMEOUT(timeout)); diff --git a/drivers/watchdog/wdt_esp32.c b/drivers/watchdog/wdt_esp32.c index 0b5026f5fb4..8873fc2ded4 100644 --- a/drivers/watchdog/wdt_esp32.c +++ b/drivers/watchdog/wdt_esp32.c @@ -30,7 +30,7 @@ static inline void wdt_esp32_seal(void) { volatile u32_t *reg = (u32_t *)TIMG_WDTWPROTECT_REG(1); - *reg = 0; + *reg = 0U; } static inline void wdt_esp32_unseal(void) @@ -71,7 +71,7 @@ static void adjust_timeout(u32_t timeout) /* MWDT ticks every 12.5ns. Set the prescaler to 40000, so the * counter for each watchdog stage is decremented every 0.5ms. */ - *reg = 40000; + *reg = 40000U; reg = (u32_t *)TIMG_WDTCONFIG2_REG(1); *reg = ticks; diff --git a/drivers/watchdog/wdt_qmsi.c b/drivers/watchdog/wdt_qmsi.c index 5a9a5374492..46a3a2100f6 100644 --- a/drivers/watchdog/wdt_qmsi.c +++ b/drivers/watchdog/wdt_qmsi.c @@ -87,7 +87,7 @@ static __attribute__((noinline)) u32_t next_pow2(u32_t x) static u32_t get_timeout(u32_t timeout) { u32_t val = timeout / 2; - u32_t count = 0; + u32_t count = 0U; if (val & (val - 1)) val = next_pow2(val); diff --git a/drivers/watchdog/wdt_sam.c b/drivers/watchdog/wdt_sam.c index 12a8fade110..1c6878da15d 100644 --- a/drivers/watchdog/wdt_sam.c +++ b/drivers/watchdog/wdt_sam.c @@ -140,7 +140,7 @@ static int wdt_sam_setup(struct device *dev, u8_t options) static int wdt_sam_install_timeout(struct device *dev, const struct wdt_timeout_cfg *cfg) { - u32_t wdt_mode = 0; + u32_t wdt_mode = 0U; int timeout_value; struct wdt_sam_dev_data *data = dev->driver_data; diff --git a/drivers/wifi/eswifi/eswifi_core.c b/drivers/wifi/eswifi/eswifi_core.c index 9c9c89d9e82..a4fb0ea9aec 100644 --- a/drivers/wifi/eswifi/eswifi_core.c +++ b/drivers/wifi/eswifi/eswifi_core.c @@ -135,7 +135,7 @@ static int __parse_ipv4_address(char *str, char *ssid, u8_t ip[4]) while (*str) { if (byte == -1) { if (!strncmp(str, ssid, strlen(ssid))) { - byte = 0; + byte = 0U; str += strlen(ssid); } str++; diff --git a/drivers/wifi/simplelink/simplelink_support.c b/drivers/wifi/simplelink/simplelink_support.c index f0c878cab8b..1340eb531b9 100644 --- a/drivers/wifi/simplelink/simplelink_support.c +++ b/drivers/wifi/simplelink/simplelink_support.c @@ -71,7 +71,7 @@ static s32_t configure_simplelink(void) s32_t retval = -1; s32_t mode = -1; #if !defined(CONFIG_NET_IPV6) - u32_t if_bitmap = 0; + u32_t if_bitmap = 0U; #endif SlWlanScanParamCommand_t scan_default = { 0 }; SlWlanRxFilterOperationCommandBuff_t rx_filterid_mask = { { 0 } }; @@ -145,7 +145,7 @@ static s32_t configure_simplelink(void) ASSERT_ON_ERROR(retval, WLAN_ERROR); /* Set TX power lvl to max */ - power = 0; + power = 0U; retval = sl_WlanSet(SL_WLAN_CFG_GENERAL_PARAM_ID, SL_WLAN_GENERAL_PARAM_OPT_STA_TX_POWER, 1, (u8_t *)&power); @@ -345,7 +345,7 @@ void SimpleLinkNetAppEventHandler(SlNetAppEvent_t *netapp_event) case SL_DEVICE_EVENT_DROPPED_NETAPP_IPACQUIRED_V6: SET_STATUS_BIT(nwp.status, STATUS_BIT_IPV6_ACQUIRED); - for (i = 0; i < 4; i++) { + for (i = 0U; i < 4; i++) { sl_conn.ipv6_addr[i] = netapp_event->Data.IpAcquiredV6.Ip[i]; } @@ -536,7 +536,7 @@ int _simplelink_start_scan(void) void _simplelink_get_mac(unsigned char *mac) { u16_t mac_len = SL_MAC_ADDR_LEN; - u16_t config_opt = 0; + u16_t config_opt = 0U; sl_NetCfgGet(SL_NETCFG_MAC_ADDRESS_GET, &config_opt, &mac_len, (u8_t *)mac); @@ -585,7 +585,7 @@ int _simplelink_init(simplelink_wifi_cb_t wifi_cb) CC3220SF_LAUNCHXL_init(); /* Configure SimpleLink NWP: */ - nwp.status = 0; + nwp.status = 0U; nwp.role = ROLE_RESERVED; nwp.cb = wifi_cb; diff --git a/drivers/wifi/winc1500/wifi_winc1500.c b/drivers/wifi/winc1500/wifi_winc1500.c index 9f7c63dfb2e..ce7abdafea7 100644 --- a/drivers/wifi/winc1500/wifi_winc1500.c +++ b/drivers/wifi/winc1500/wifi_winc1500.c @@ -663,7 +663,7 @@ static void handle_wifi_dhcp_conf(void *pvMsg) /* TODO at this point the standby mode should be enable * status = WiFi connected IP assigned */ - for (i = 0; i < 4; i++) { + for (i = 0U; i < 4; i++) { addr.s4_addr[i] = pu8IPAddress[i]; } @@ -675,7 +675,7 @@ static void handle_wifi_dhcp_conf(void *pvMsg) static void reset_scan_data(void) { w1500_data.scan_cb = NULL; - w1500_data.scan_result = 0; + w1500_data.scan_result = 0U; } static void handle_scan_result(void *pvMsg) @@ -734,7 +734,7 @@ static void handle_scan_done(void *pvMsg) return; } - w1500_data.scan_result = 0; + w1500_data.scan_result = 0U; if (pstrInfo->u8NumofCh >= 1) { LOG_DBG("Requesting results (%u)",