michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Bluetooth: Host: Explicitly ignore return value of auth latch

Browse source 
Fixes a coverity-reported issue by explicitly ignoring the return value
of the cas-operation. The return value is the old value, but we are not
interested in it in the situation when we just want to initialize a
value if it is in the uninitialized state.

Fixes: https://github.com/zephyrproject-rtos/zephyr/issues/60474

Signed-off-by: Aleksander Wasaznik <aleksander.wasaznik@nordicsemi.no>
This commit is contained in:
Aleksander Wasaznik 2023-08-08 14:38:50 +02:00 • committed by Fabio Baltieri
commit 8e5fd3990f
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
subsys/bluetooth/host/smp.c
View file

@ -313,14 +313,15 @@ static bool le_sc_supported(void)
static const struct bt_conn_auth_cb *latch_auth_cb(struct bt_smp *smp)
{
atomic_ptr_cas(&smp->auth_cb, BT_SMP_AUTH_CB_UNINITIALIZED, (atomic_ptr_val_t)bt_auth);
(void)atomic_ptr_cas(&smp->auth_cb, BT_SMP_AUTH_CB_UNINITIALIZED,
(atomic_ptr_val_t)bt_auth);
return atomic_ptr_get(&smp->auth_cb);
}
static bool latch_bondable(struct bt_smp *smp)
{
atomic_cas(&smp->bondable, BT_SMP_BONDABLE_UNINITIALIZED, (atomic_val_t)bondable);
(void)atomic_cas(&smp->bondable, BT_SMP_BONDABLE_UNINITIALIZED, (atomic_val_t)bondable);
return atomic_get(&smp->bondable);
}