michaelh/zephyr
1
0
Fork 0
Code Releases Activity

k_stack_init: num_entries should be unsigned

Browse source 
Allowing negative values here is a great way to get the kernel to
explode.

Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
This commit is contained in:
Andrew Boie 2017-10-12 14:01:25 -07:00 • committed by Andrew Boie
commit 8e3e6d0d79
2 changed files with 4 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
include/kernel.h
View file

@ -2000,7 +2000,7 @@ struct k_stack {
* @return N/A
*/
__syscall void k_stack_init(struct k_stack *stack,
u32_t *buffer, int num_entries);
u32_t *buffer, unsigned int num_entries);
/**
* @brief Push an element onto a stack.

9
kernel/stack.c
View file

@ -45,7 +45,8 @@ SYS_INIT(init_stack_module, PRE_KERNEL_1, CONFIG_KERNEL_INIT_PRIORITY_OBJECTS);
#endif /* CONFIG_OBJECT_TRACING */
void _impl_k_stack_init(struct k_stack *stack, u32_t *buffer, int num_entries)
void _impl_k_stack_init(struct k_stack *stack, u32_t *buffer,
unsigned int num_entries)
{
sys_dlist_init(&stack->wait_q);
stack->next = stack->base = buffer;
@ -56,12 +57,8 @@ void _impl_k_stack_init(struct k_stack *stack, u32_t *buffer, int num_entries)
}
#ifdef CONFIG_USERSPACE
_SYSCALL_HANDLER3(k_stack_init, stack, buffer, num_entries_p)
_SYSCALL_HANDLER3(k_stack_init, stack, buffer, num_entries)
{
int num_entries = (int)num_entries_p;
/* FIXME why is 'num_entries' signed?? */
_SYSCALL_VERIFY(num_entries > 0);
_SYSCALL_OBJ_INIT(stack, K_OBJ_STACK);
_SYSCALL_MEMORY_ARRAY_WRITE(buffer, num_entries, sizeof(u32_t));