michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: uart_ns16550: Remove support for hard-coded PCIe interrupts

Browse source 
There are no boards that need hard-coded interrupts so just remove this
build-time conditional branch. The way going forward is that all PCIe
devices should always use PCIE_IRQ_DETECT.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
This commit is contained in:
Johan Hedberg 2021-04-21 19:18:57 +03:00 • committed by Kumar Gala
commit 8cfa5deb16
1 changed files with 2 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

20
drivers/serial/uart_ns16550_port_x.h
View file

@ -76,10 +76,9 @@ static void irq_config_func_@NUM@(const struct device *dev)
ARG_UNUSED(dev); ARG_UNUSED(dev);
#if DT_INST_ON_BUS(@NUM@, pcie) #if DT_INST_ON_BUS(@NUM@, pcie)
#if DT_INST_IRQN(@NUM@) == PCIE_IRQ_DETECT
/* PCI(e) with auto IRQ detection */ /* PCI(e) with auto IRQ detection */
BUILD_ASSERT(DT_INST_IRQN(@NUM@) == PCIE_IRQ_DETECT,
"Only runtime IRQ configuration is supported");
BUILD_ASSERT(IS_ENABLED(CONFIG_DYNAMIC_INTERRUPTS), BUILD_ASSERT(IS_ENABLED(CONFIG_DYNAMIC_INTERRUPTS),
"NS16550 PCI auto-IRQ needs CONFIG_DYNAMIC_INTERRUPTS"); "NS16550 PCI auto-IRQ needs CONFIG_DYNAMIC_INTERRUPTS");
@ -98,21 +97,6 @@ static void irq_config_func_@NUM@(const struct device *dev)
INST_@NUM@_IRQ_FLAGS); INST_@NUM@_IRQ_FLAGS);
pcie_irq_enable(DT_INST_REG_ADDR(@NUM@), irq); pcie_irq_enable(DT_INST_REG_ADDR(@NUM@), irq);
#else
/* PCI(e) with fixed or MSI IRQ */
IRQ_CONNECT(DT_INST_IRQN(@NUM@),
DT_INST_IRQ(@NUM@, priority),
uart_ns16550_isr,
DEVICE_DT_INST_GET(@NUM@),
INST_@NUM@_IRQ_FLAGS);
pcie_irq_enable(DT_INST_REG_ADDR(@NUM@),
DT_INST_IRQN(@NUM@));
#endif
#else #else
/* not PCI(e) */ /* not PCI(e) */