michaelh/zephyr
1
0
Fork 0
Code Releases Activity

tests: fcb: initialize buffers to avoid processing uninitialized values

Browse source 
Running the test under valgrind identified three places where an
uninitialized stack buffer was used as the source of data over which a
CRC was incidently calculated, causing an uninitialized value warning
in the CRC calculation.  Zero out the source buffers before using them
as a data source.

Signed-off-by: Peter Bigot <peter.bigot@nordicsemi.no>
This commit is contained in:
Peter Bigot 2019-11-06 10:57:12 -06:00 • committed by Maureen Helm
commit 8bb99dc9ce
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/subsys/fs/fcb/src/fcb_test_last_of_n.c
View file

@ -14,7 +14,7 @@ void fcb_test_last_of_n(void)
int rc;
struct fcb_entry loc;
struct fcb_entry areas[ENTRIES];
u8_t test_data[128];
u8_t test_data[128] = {0};
u8_t i;
fcb = &test_fcb;

2
tests/subsys/fs/fcb/src/fcb_test_multiple_scratch.c
View file

@ -12,7 +12,7 @@ void fcb_test_multi_scratch(void)
struct fcb *fcb;
int rc;
struct fcb_entry loc;
u8_t test_data[128];
u8_t test_data[128] = {0};
int elem_cnts[4];
int idx;
int cnts[4];

2
tests/subsys/fs/fcb/src/fcb_test_rotate.c
View file

@ -13,7 +13,7 @@ void fcb_test_rotate(void)
int rc;
int old_id;
struct fcb_entry loc;
u8_t test_data[128];
u8_t test_data[128] = {0};
int elem_cnts[2] = {0, 0};
int cnts[2];
struct append_arg aa_arg = {