michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: flash: stm32 ospi: jedec_id read wrongly

Browse source 
Manufacturer id is skipped when reading jedec_id, due to wrong
address mode.
Before: flash_stm32_ospi: Jedec ID = [60 20 00]
After:  flash_stm32_ospi: Jedec ID = [ef 60 20]

Signed-off-by: Brian Juel Folkmann <bju@trackunit.com>
This commit is contained in:
Brian Juel Folkmann 2023-09-12 08:51:24 +02:00 • committed by Carles Cufí
commit 8b6382e68d
1 changed files with 13 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

25
drivers/flash/flash_stm32_ospi.c
View file

@ -345,6 +345,17 @@ static OSPI_RegularCmdTypeDef ospi_prepare_cmd(uint8_t transfer_mode, uint8_t tr
return cmd_tmp; return cmd_tmp;
} }
static uint32_t stm32_ospi_hal_address_size(const struct device *dev)
{
struct flash_stm32_ospi_data *dev_data = dev->data;
if (dev_data->address_width == 4U) {
return HAL_OSPI_ADDRESS_32_BITS;
}
return HAL_OSPI_ADDRESS_24_BITS;
}
#if defined(CONFIG_FLASH_JESD216_API) #if defined(CONFIG_FLASH_JESD216_API)
/* /*
* Read the JEDEC ID data from the octoFlash at init or DTS * Read the JEDEC ID data from the octoFlash at init or DTS
@ -367,7 +378,8 @@ static int stm32_ospi_read_jedec_id(const struct device *dev)
OSPI_RegularCmdTypeDef cmd = ospi_prepare_cmd(OSPI_SPI_MODE, OSPI_STR_TRANSFER); OSPI_RegularCmdTypeDef cmd = ospi_prepare_cmd(OSPI_SPI_MODE, OSPI_STR_TRANSFER);
cmd.Instruction = JESD216_CMD_READ_ID; cmd.Instruction = JESD216_CMD_READ_ID;
cmd.AddressSize = HAL_OSPI_ADDRESS_NONE; cmd.AddressSize = stm32_ospi_hal_address_size(dev);
cmd.AddressMode = HAL_OSPI_ADDRESS_NONE;
cmd.NbData = JESD216_READ_ID_LEN; /* 3 bytes in the READ ID */ cmd.NbData = JESD216_READ_ID_LEN; /* 3 bytes in the READ ID */
HAL_StatusTypeDef hal_ret; HAL_StatusTypeDef hal_ret;
@ -943,17 +955,6 @@ static int stm32_ospi_mem_reset(const struct device *dev)
return 0; return 0;
} }
static uint32_t stm32_ospi_hal_address_size(const struct device *dev)
{
struct flash_stm32_ospi_data *dev_data = dev->data;
if (dev_data->address_width == 4U) {
return HAL_OSPI_ADDRESS_32_BITS;
}
return HAL_OSPI_ADDRESS_24_BITS;
}
/* /*
* Function to erase the flash : chip or sector with possible OSPI/SPI and STR/DTR * Function to erase the flash : chip or sector with possible OSPI/SPI and STR/DTR
* to erase the complete chip (using dedicated command) : * to erase the complete chip (using dedicated command) :