michaelh/zephyr
1
0
Fork 0
Code Releases Activity

include: usb_ch9: ensure packing of usb_setup_packet

Browse source 
struct usb_setup_packet represents the setup data payload of a USB control
message which is exactly 8-bytes in length.

On a legacy build of GCC 4.1.2 for an OpenRISC-like architecture it was
found that the compiler added padding after the bmRequestType anonymous
union, and subsequently the bRequest field causing the structure to be
padded to 12-bytes in length with the fields incorrectly laid out.

This patch corrects the issue by applying the __packed attribute to the
anonymous union. This corrects the issue.

The __packed attribute is also applied to the outer structure for the sake
of consistency.

Signed-off-by: Joel Holdsworth <jholdsworth@nvidia.com>
This commit is contained in:
Joel Holdsworth 2025-05-20 09:40:08 -07:00 • committed by Benjamin Cabé
commit 8b5fe624e2
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
include/zephyr/usb/usb_ch9.h
View file

@ -41,12 +41,12 @@ struct usb_setup_packet {
union {
uint8_t bmRequestType;
struct usb_req_type_field RequestType;
};
} __packed;
uint8_t bRequest;
uint16_t wValue;
uint16_t wIndex;
uint16_t wLength;
};
} __packed;
/** USB Setup packet RequestType Direction values (from Table 9-2) */
#define USB_REQTYPE_DIR_TO_DEVICE 0