michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: clock_control: use device_is_ready

Browse source 
device_usable_check() can return 0 or -ENODEV, so using device_is_ready
is equivalent if we return -ENODEV when the device is not ready.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
This commit is contained in:
Gerard Marull-Paretas 2021-12-23 17:23:14 +01:00 • committed by Anas Nashif
commit 8b3560a119
1 changed files with 10 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

30
include/drivers/clock_control.h
View file

@ -117,10 +117,8 @@ struct clock_control_driver_api {
static inline int clock_control_on(const struct device *dev, static inline int clock_control_on(const struct device *dev,
clock_control_subsys_t sys) clock_control_subsys_t sys)
{ {
int ret = device_usable_check(dev); if (!device_is_ready(dev)) {
return -ENODEV;
if (ret != 0) {
return ret;
} }
const struct clock_control_driver_api *api = const struct clock_control_driver_api *api =
@ -142,10 +140,8 @@ static inline int clock_control_on(const struct device *dev,
static inline int clock_control_off(const struct device *dev, static inline int clock_control_off(const struct device *dev,
clock_control_subsys_t sys) clock_control_subsys_t sys)
{ {
int ret = device_usable_check(dev); if (!device_is_ready(dev)) {
return -ENODEV;
if (ret != 0) {
return ret;
} }
const struct clock_control_driver_api *api = const struct clock_control_driver_api *api =
@ -183,10 +179,8 @@ static inline int clock_control_async_on(const struct device *dev,
return -ENOSYS; return -ENOSYS;
} }
int ret = device_usable_check(dev); if (!device_is_ready(dev)) {
return -ENODEV;
if (ret != 0) {
return ret;
} }
return api->async_on(dev, sys, cb, user_data); return api->async_on(dev, sys, cb, user_data);
@ -228,10 +222,8 @@ static inline int clock_control_get_rate(const struct device *dev,
clock_control_subsys_t sys, clock_control_subsys_t sys,
uint32_t *rate) uint32_t *rate)
{ {
int ret = device_usable_check(dev); if (!device_is_ready(dev)) {
return -ENODEV;
if (ret != 0) {
return ret;
} }
const struct clock_control_driver_api *api = const struct clock_control_driver_api *api =
@ -264,10 +256,8 @@ static inline int clock_control_set_rate(const struct device *dev,
clock_control_subsys_t sys, clock_control_subsys_t sys,
clock_control_subsys_rate_t rate) clock_control_subsys_rate_t rate)
{ {
int ret = device_usable_check(dev); if (!device_is_ready(dev)) {
return -ENODEV;
if (ret != 0) {
return ret;
} }
const struct clock_control_driver_api *api = const struct clock_control_driver_api *api =