michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Bluetooth: L2CAP: Restore credits after receiving an SDU

Browse source 
This simplify the logic of restoring the credits after each SDU instead
of using an arbitrary threshold which was not configurable per channel.

Because the credits are restored only when the full SDU has been
reassembled it means the channels needs to be set up with enough for
the configured MTU otherwise there is a risk of the channel to run out
of RX credits before the packet is fully reassembled, because of such
corner case the code will now warn if a channel is setup with not enough
init_credits.

Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This commit is contained in:
Luiz Augusto von Dentz 2018-08-22 13:36:41 +03:00 • committed by Johan Hedberg
commit 8af4786e9f
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
subsys/bluetooth/host/l2cap.c
View file

@ -35,8 +35,6 @@
#define L2CAP_LE_MAX_CREDITS (CONFIG_BT_RX_BUF_COUNT - 1)
#endif
#define L2CAP_LE_CREDITS_THRESHOLD(_creds) (_creds / 2)
#define L2CAP_LE_CID_DYN_START 0x0040
#define L2CAP_LE_CID_DYN_END 0x007f
#define L2CAP_LE_CID_IS_DYN(_cid) \
@ -665,6 +663,11 @@ static void l2cap_chan_rx_init(struct bt_l2cap_le_chan *chan)
*/
chan->rx.mps = min(chan->rx.mtu + 2, L2CAP_MAX_LE_MPS);
k_sem_init(&chan->rx.credits, 0, UINT_MAX);
if (BT_DBG_ENABLED &&
chan->rx.init_credits * chan->rx.mps < chan->rx.mtu + 2) {
BT_WARN("Not enough credits for a full packet");
}
}
static void l2cap_chan_tx_init(struct bt_l2cap_le_chan *chan)