michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Bluetooth: CAP: Shell: Fix argument issue for unicast_stop

Browse source 
The unicast_stop command takes either "all" or one or more
stream pointers as argument, but the argument handler did
not allow this.

The documentation for the command was also out of date.

Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
This commit is contained in:
Emil Gydesen 2024-02-14 10:42:12 +01:00 • committed by Henrik Brix Andersen
commit 8ad8878d61
2 changed files with 10 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

12
doc/connectivity/bluetooth/api/shell/cap.rst
View file

@ -60,7 +60,7 @@ the optionally included CSIS instance by calling (:code:`cap_initiator discover`
(default 1)] [conns (<cnt> | all) (default 1)] (default 1)] [conns (<cnt> | all) (default 1)]
unicast_list :Unicast list streams unicast_list :Unicast list streams
unicast_update :Unicast Update <all | stream [stream [stream...]]> unicast_update :Unicast Update <all | stream [stream [stream...]]>
unicast_stop :Unicast stop all streams unicast_stop :Unicast stop streams <all | stream [stream [stream...]]>
unicast_cancel :Unicast cancel current procedure unicast_cancel :Unicast cancel current procedure
Before being able to perform any stream operation, the device must also perform the Before being able to perform any stream operation, the device must also perform the
@ -120,24 +120,24 @@ To use multiple devices, simply connect to more and then use :code:`bt select` t
the commands on. the commands on.
Once all devices have been connected and the respective discovery commands have been called, the Once all devices have been connected and the respective discovery commands have been called, the
:code:`cap_initiator unicast-start` command can be used to put one or more streams into the :code:`cap_initiator unicast_start` command can be used to put one or more streams into the
streaming state. streaming state.
.. code-block:: console .. code-block:: console
uart:~$ cap_initiator unicast-start sinks 1 sources 0 conns all uart:~$ cap_initiator unicast_start sinks 1 sources 0 conns all
Setting up 1 sinks and 0 sources on each (2) conn Setting up 1 sinks and 0 sources on each (2) conn
Starting 1 streams Starting 1 streams
Unicast start completed Unicast start completed
To stop all the streams that has been started, the :code:`cap_initiator unicast-stop` command can be To stop all the streams that has been started, the :code:`cap_initiator unicast_stop` command can be
used. used.
.. code-block:: console .. code-block:: console
uart:~$ cap_initiator unicast-stop uart:~$ cap_initiator unicast_stop all
Unicast stopped for group 0x81e41c0 completed Unicast stop completed
CAP Commander CAP Commander
************* *************

7
subsys/bluetooth/audio/shell/cap_initiator.c
View file

@ -66,7 +66,7 @@ static void unicast_stop_complete_cb(int err, struct bt_conn *conn)
} else if (err != 0) { } else if (err != 0) {
shell_error(ctx_shell, "Unicast stop failed for conn %p (%d)", conn, err); shell_error(ctx_shell, "Unicast stop failed for conn %p (%d)", conn, err);
} else { } else {
shell_print(ctx_shell, "Unicast stopped completed"); shell_print(ctx_shell, "Unicast stop completed");
if (default_unicast_group != NULL) { if (default_unicast_group != NULL) {
err = bt_bap_unicast_group_delete(default_unicast_group); err = bt_bap_unicast_group_delete(default_unicast_group);
@ -1224,8 +1224,9 @@ SHELL_STATIC_SUBCMD_SET_CREATE(
0), 0),
SHELL_CMD_ARG(unicast_update, NULL, "Unicast Update <all | stream [stream [stream...]]>", SHELL_CMD_ARG(unicast_update, NULL, "Unicast Update <all | stream [stream [stream...]]>",
cmd_cap_initiator_unicast_update, 2, CAP_UNICAST_CLIENT_STREAM_COUNT), cmd_cap_initiator_unicast_update, 2, CAP_UNICAST_CLIENT_STREAM_COUNT),
SHELL_CMD_ARG(unicast_stop, NULL, "Unicast stop all streams", SHELL_CMD_ARG(unicast_stop, NULL,
cmd_cap_initiator_unicast_stop, 1, 0), "Unicast stop streams <all | stream [stream [stream...]]>",
cmd_cap_initiator_unicast_stop, 2, CAP_UNICAST_CLIENT_STREAM_COUNT),
SHELL_CMD_ARG(unicast_cancel, NULL, "Unicast cancel current procedure", SHELL_CMD_ARG(unicast_cancel, NULL, "Unicast cancel current procedure",
cmd_cap_initiator_unicast_cancel, 1, 0), cmd_cap_initiator_unicast_cancel, 1, 0),
#if UNICAST_SINK_SUPPORTED #if UNICAST_SINK_SUPPORTED