michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: udc_dwc2: Disable control IN endpoint on SETUP

Browse source 
New control transfer is started prematurely from device perspective when
host timeout occurs. Any data transfer from previous control transfer
have to be cancelled prior to handling SETUP data. Unconditionally
disable control IN endpoint to prevent race for enqueued buffer between
udc_buf_get_all() called in dwc2_handle_evt_setup() and udc_buf_peek()
called in dwc2_handle_in_xfercompl().

Signed-off-by: Tomasz Moń <tomasz.mon@nordicsemi.no>
This commit is contained in:
Tomasz Moń 2025-06-09 10:14:11 +02:00 • committed by Anas Nashif
commit 89a81e3c1f
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/usb/udc/udc_dwc2.c
View file

@ -823,6 +823,7 @@ static int dwc2_handle_evt_setup(const struct device *dev)
* transfer beforehand. In Buffer DMA the SETUP can be copied to any EP0
* OUT buffer. If there is any buffer queued, it is obsolete now.
*/
udc_dwc2_ep_disable(dev, cfg_in, false);
atomic_and(&priv->xfer_finished, ~(BIT(0) | BIT(16)));
buf = udc_buf_get_all(cfg_out);
@ -832,7 +833,6 @@ static int dwc2_handle_evt_setup(const struct device *dev)
buf = udc_buf_get_all(cfg_in);
if (buf) {
udc_dwc2_ep_disable(dev, cfg_in, false);
net_buf_unref(buf);
}