michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers/gpio_intel_apl.c: fix return value for gpio_pin_read()

Browse source 
gpio_intel_apl_read() should set *value to 1, not 2, when the
GPIO input is a logical high.

Fixes: #15499

Signed-off-by: Charles E. Youse <charles.youse@intel.com>
This commit is contained in:
Charles E. Youse 2019-04-17 16:21:59 -07:00 • committed by Anas Nashif
commit 8905b0fe21
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
drivers/gpio/gpio_intel_apl.c
View file

@ -345,10 +345,10 @@ static int gpio_intel_apl_read(struct device *dev, int access_op,
if (!(val & PAD_CFG0_TXDIS)) {
/* If TX is not disabled, return TX_STATE */
*value = val & PAD_CFG0_TXSTATE;
*value = (val & PAD_CFG0_TXSTATE) >> PAD_CFG0_TXSTATE_POS;
} else {
/* else just return RX_STATE */
*value = val & PAD_CFG0_RXSTATE;
*value = (val & PAD_CFG0_RXSTATE) >> PAD_CFG0_RXSTATE_POS;
}
return 0;