michaelh/zephyr
1
0
Fork 0
Code Releases Activity

net: lib: dns: Check return value of net_context_recv()

Browse source 
Given that K_NO_WAIT is passed as a timeout to net_context_recv(), it's
unlikely this function will return any error value.  It's cheap to
check, though, so do it.

Coverity-CID: 170580
Signed-off-by: Leandro Pereira <leandro.pereira@intel.com>
This commit is contained in:
Leandro Pereira 2017-06-09 10:10:26 -07:00 • committed by Jukka Rissanen
commit 87ccb79a7a
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
subsys/net/lib/dns/resolve.c
View file

@ -674,14 +674,19 @@ static int dns_write(struct dns_resolve_context *ctx,
goto quit; goto quit;
} }
ret = net_context_recv(net_ctx, cb_recv, K_NO_WAIT, ctx);
if (ret < 0) {
NET_DBG("Couldn't receive from socket (%d)", ret);
net_pkt_unref(pkt);
goto quit;
}
if (server->family == AF_INET) { if (server->family == AF_INET) {
server_addr_len = sizeof(struct sockaddr_in); server_addr_len = sizeof(struct sockaddr_in);
} else { } else {
server_addr_len = sizeof(struct sockaddr_in6); server_addr_len = sizeof(struct sockaddr_in6);
} }
net_context_recv(net_ctx, cb_recv, K_NO_WAIT, ctx);
ret = net_context_sendto(pkt, server, server_addr_len, NULL, ret = net_context_sendto(pkt, server, server_addr_len, NULL,
K_NO_WAIT, NULL, NULL); K_NO_WAIT, NULL, NULL);
if (ret < 0) { if (ret < 0) {