michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: regulator: common: skip voltage change at init if already valid

Browse source 
The current implementation always sets the voltage before enabling,
even if the current voltage is in the allowed range.

This has some side effects, i.e. for PMIC regulators that are
pre-programmed for a specific value but allow voltage changes during
runtime. The side effect being that the regulator will always be reset
to the lower value of the voltage range at init.

Another usecase would be when a bootloader sets a specific voltage then
loads an application that uses the same driver.

The proposed fix is to evaluate the current voltage and try to bring
the actual voltage in range if the current voltage is not valid
according to the min/max constraints.

Tested on custom SAMD20 board with a custom RK816 PMIC driver.

Signed-off-by: Ionut Catalin Pavel <iocapa@iocapa.com>
This commit is contained in:
Ionut Catalin Pavel 2023-02-12 18:06:47 +02:00 • committed by Fabio Baltieri
commit 867c254801
1 changed files with 18 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

22
drivers/regulator/regulator_common.c
View file

@ -18,6 +18,7 @@ int regulator_common_init(const struct device *dev, bool is_enabled)
const struct regulator_driver_api *api = dev->api;
const struct regulator_common_config *config = dev->config;
struct regulator_common_data *data = dev->data;
int32_t current_uv;
int ret;
if (config->initial_mode != REGULATOR_INITIAL_MODE_UNKNOWN) {
@ -27,13 +28,26 @@ int regulator_common_init(const struct device *dev, bool is_enabled)
}
}
/* regulator voltage needs to be within allowed range before enabling */
/* If we have valid range values, we try to match them before enabling */
if ((config->min_uv > INT32_MIN) || (config->max_uv < INT32_MAX)) {
ret = regulator_set_voltage(dev, config->min_uv,
config->max_uv);
if ((ret < 0) && (ret != -ENOSYS)) {
ret = regulator_get_voltage(dev, &current_uv);
if (ret < 0) {
return ret;
}
/* Snap to closest interval value if out of range */
if (current_uv < config->min_uv) {
ret = regulator_set_voltage(dev, config->min_uv, config->min_uv);
if (ret < 0) {
return ret;
}
} else if (current_uv > config->max_uv) {
ret = regulator_set_voltage(dev, config->max_uv, config->max_uv);
if (ret < 0) {
return ret;
}
}
}
if (is_enabled) {