michaelh/zephyr
1
0
Fork 0
Code Releases Activity

net/mqtt: Improve error handling in mqtt_rx_connack routine

Browse source 
Avoid undesired behaviors by exiting once an error is detected.

Change-Id: Id8e6accd6cd096274fe1c40a615d290967f1d4b9
Signed-off-by: Flavio Santes <flavio.santes@intel.com>
This commit is contained in:
Flavio Santes 2017-01-01 16:12:39 -06:00 • committed by Tomasz Bursztyka
commit 8619d9d625
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
subsys/net/lib/mqtt/mqtt.c
View file

@ -415,6 +415,7 @@ int mqtt_rx_connack(struct mqtt_ctx *ctx, struct net_buf *rx, int clean_session)
rc = 0; rc = 0;
} else { } else {
rc = -EINVAL; rc = -EINVAL;
goto exit_connect;
} }
break; break;
/* previous session */ /* previous session */
@ -423,7 +424,7 @@ int mqtt_rx_connack(struct mqtt_ctx *ctx, struct net_buf *rx, int clean_session)
/* FALLTHROUGH */ /* FALLTHROUGH */
default: default:
rc = -EINVAL; rc = -EINVAL;
break; goto exit_connect;
} }
ctx->connected = 1; ctx->connected = 1;