michaelh/zephyr
1
0
Fork 0
Code Releases Activity

coding guidelines: comply with MISRA C:2012 Rule 21.13

Browse source 
MISRA C:2012 Rule 21.13 (Any value passed to a function in <ctype.h>
shall be representable as an unsigned char or be the value EOF).

Functions in <ctype.h> have undefined behavior if they are called with
any other value. Callers affected by this change are not prepared to
handle EOF anyway. The addition of these casts avoids the issue
and does not result in any performance penalty.

Signed-off-by: Abramo Bagnara <abramo.bagnara@bugseng.com>
Signed-off-by: Simon Hein <SHein@baumer.com>
This commit is contained in:
Abramo Bagnara 2021-11-12 13:30:46 +01:00 • committed by Anas Nashif
commit 8521b43546
6 changed files with 17 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

2
arch/x86/core/x86_mmu.c
View file

@ -564,7 +564,7 @@ static char get_entry_code(pentry_t value)
if ((value & MMU_US) != 0U) {
/* Uppercase indicates user mode access */
ret = toupper(ret);
ret = toupper((unsigned char)ret);
}
}

4
lib/libc/minimal/source/stdlib/atoi.c
View file

@ -33,7 +33,7 @@ int atoi(const char *s)
int n = 0;
int neg = 0;
while (isspace(*s)) {
while (isspace((unsigned char)*s)) {
s++;
}
switch (*s) {
@ -51,7 +51,7 @@ int atoi(const char *s)
break;
}
/* Compute n as a negative number to avoid overflow on INT_MIN */
while (isdigit(*s)) {
while (isdigit((unsigned char)*s)) {
n = 10*n - (*s++ - '0');
}
return neg ? n : -n;

8
lib/libc/minimal/source/stdlib/strtol.c
View file

@ -55,7 +55,7 @@ long strtol(const char *nptr, char **endptr, register int base)
*/
do {
c = *s++;
} while (isspace(c));
} while (isspace((unsigned char)c));
if (c == '-') {
neg = 1;
c = *s++;
@ -95,10 +95,10 @@ long strtol(const char *nptr, char **endptr, register int base)
cutlim = cutoff % (unsigned long)base;
cutoff /= (unsigned long)base;
for (acc = 0, any = 0;; c = *s++) {
if (isdigit(c)) {
if (isdigit((unsigned char)c)) {
c -= '0';
} else if (isalpha(c)) {
c -= isupper(c) ? 'A' - 10 : 'a' - 10;
} else if (isalpha((unsigned char)c)) {
c -= isupper((unsigned char)c) ? 'A' - 10 : 'a' - 10;
} else {
break;
}

8
lib/libc/minimal/source/stdlib/strtoul.c
View file

@ -53,7 +53,7 @@ unsigned long strtoul(const char *nptr, char **endptr, register int base)
*/
do {
c = *s++;
} while (isspace(c));
} while (isspace((unsigned char)c));
if (c == '-') {
neg = 1;
c = *s++;
@ -75,10 +75,10 @@ unsigned long strtoul(const char *nptr, char **endptr, register int base)
cutoff = (unsigned long)ULONG_MAX / (unsigned long)base;
cutlim = (unsigned long)ULONG_MAX % (unsigned long)base;
for (acc = 0, any = 0;; c = *s++) {
if (isdigit(c)) {
if (isdigit((unsigned char)c)) {
c -= '0';
} else if (isalpha(c)) {
c -= isupper(c) ? 'A' - 10 : 'a' - 10;
} else if (isalpha((unsigned char)c)) {
c -= isupper((unsigned char)c) ? 'A' - 10 : 'a' - 10;
} else {
break;
}

2
lib/libc/minimal/source/string/strncasecmp.c
View file

@ -17,7 +17,7 @@ strncasecmp(const char *s1, const char *s2, size_t n)
c = *s1++;
lower1 = tolower(c);
lower2 = tolower(*s2++);
lower2 = tolower((unsigned char)*s2++);
if (lower1 != lower2) {
return (lower1 > lower2) - (lower1 < lower2);

10
lib/os/cbprintf_complete.c
View file

@ -905,7 +905,7 @@ static char *encode_float(double value,
*/
if (expo == BIT_MASK(EXPONENT_BITS)) {
if (fract == 0) {
if (isupper((int)c)) {
if (isupper((unsigned char)c)) {
*buf++ = 'I';
*buf++ = 'N';
*buf++ = 'F';
@ -915,7 +915,7 @@ static char *encode_float(double value,
*buf++ = 'f';
}
} else {
if (isupper((int)c)) {
if (isupper((unsigned char)c)) {
*buf++ = 'N';
*buf++ = 'A';
*buf++ = 'N';
@ -997,7 +997,7 @@ static char *encode_float(double value,
* for a and X for A.
*/
struct conversion aconv = {
.specifier = isupper((int)c) ? 'X' : 'x',
.specifier = isupper((unsigned char)c) ? 'X' : 'x',
};
const char *spe = *bpe;
char *sp = bps + (spe - bps);
@ -1783,7 +1783,7 @@ int z_cbvprintf_impl(cbprintf_cb out, void *ctx, const char *fp,
OUTC(*cp++);
}
} else {
while (isdigit((int)*cp)) {
while (isdigit((unsigned char)*cp)) {
OUTC(*cp++);
}
@ -1803,7 +1803,7 @@ int z_cbvprintf_impl(cbprintf_cb out, void *ctx, const char *fp,
OUTC('0');
}
}
while (isdigit((int)*cp)) {
while (isdigit((unsigned char)*cp)) {
OUTC(*cp++);
}
}