michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: gpio: shell: streamline code

Browse source 
Streamline code in multiple places as follows:
- Remove redundant initialization of `ret` to `0`,
  as it is immediately assigned a value.
- Add `len` to store the result of `strlen(argv[ARGV_CONF])` to avoid
  multiple calls to `strlen` within the `for-loop` in `cmd_gpio_conf`.
- Merge separate `shell_print` calls by including a newline `\n`.

Signed-off-by: Pisit Sawangvonganan <pisit@ndrsolution.com>
This commit is contained in:
Pisit Sawangvonganan 2025-02-20 17:51:49 +07:00 • committed by Carles Cufí
commit 84bc26eeec
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
drivers/gpio/gpio_shell.c
View file

@ -227,7 +227,8 @@ static int cmd_gpio_conf(const struct shell *sh, size_t argc, char **argv, void
gpio_flags_t flags = 0; gpio_flags_t flags = 0;
gpio_flags_t vendor_specific; gpio_flags_t vendor_specific;
struct sh_gpio gpio; struct sh_gpio gpio;
int ret = 0; int ret;
size_t len;
ret = get_sh_gpio(sh, argv, &gpio); ret = get_sh_gpio(sh, argv, &gpio);
if (ret != 0) { if (ret != 0) {
@ -235,7 +236,8 @@ static int cmd_gpio_conf(const struct shell *sh, size_t argc, char **argv, void
return SHELL_CMD_HELP_PRINTED; return SHELL_CMD_HELP_PRINTED;
} }
for (int i = 0; i < strlen(argv[ARGV_CONF]); i++) { len = strlen(argv[ARGV_CONF]);
for (int i = 0; i < len; i++) {
switch (argv[ARGV_CONF][i]) { switch (argv[ARGV_CONF][i]) {
case 'i': case 'i':
flags |= GPIO_INPUT; flags |= GPIO_INPUT;
@ -361,7 +363,7 @@ static int cmd_gpio_set(const struct shell *sh, size_t argc, char **argv)
{ {
struct sh_gpio gpio; struct sh_gpio gpio;
unsigned long value; unsigned long value;
int ret = 0; int ret;
ret = get_sh_gpio(sh, argv, &gpio); ret = get_sh_gpio(sh, argv, &gpio);
if (ret != 0) { if (ret != 0) {
@ -387,7 +389,7 @@ static int cmd_gpio_set(const struct shell *sh, size_t argc, char **argv)
static int cmd_gpio_toggle(const struct shell *sh, size_t argc, char **argv) static int cmd_gpio_toggle(const struct shell *sh, size_t argc, char **argv)
{ {
struct sh_gpio gpio; struct sh_gpio gpio;
int ret = 0; int ret;
ret = get_sh_gpio(sh, argv, &gpio); ret = get_sh_gpio(sh, argv, &gpio);
if (ret != 0) { if (ret != 0) {
@ -523,9 +525,7 @@ static void print_gpio_ctrl_info(const struct shell *sh, const struct gpio_ctrl
const char *line_name; const char *line_name;
shell_print(sh, " ngpios: %u", ctrl->ngpios); shell_print(sh, " ngpios: %u", ctrl->ngpios);
shell_print(sh, " Reserved pin mask: 0x%08X", ctrl->reserved_mask); shell_print(sh, " Reserved pin mask: 0x%08X\n", ctrl->reserved_mask);
shell_print(sh, "");
shell_print(sh, " Reserved Pin Line Name"); shell_print(sh, " Reserved Pin Line Name");
for (pin = 0; pin < ctrl->ngpios; pin++) { for (pin = 0; pin < ctrl->ngpios; pin++) {