michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: display: ili9xxx: remove unnecessary casts

Browse source 
The config/data casts are not strictly necessary. Furthermore, config
was being casted to non-const.

Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
This commit is contained in:
Gerard Marull-Paretas 2021-07-09 20:18:36 +02:00 • committed by Kumar Gala
commit 84b8f5e62c
1 changed files with 10 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

26
drivers/display/display_ili9xxx.c
View file

@ -24,8 +24,7 @@ struct ili9xxx_data {
int ili9xxx_transmit(const struct device *dev, uint8_t cmd, const void *tx_data, int ili9xxx_transmit(const struct device *dev, uint8_t cmd, const void *tx_data,
size_t tx_len) size_t tx_len)
{ {
const struct ili9xxx_config *config = const struct ili9xxx_config *config = dev->config;
(struct ili9xxx_config *)dev->config;
int r; int r;
struct spi_buf tx_buf; struct spi_buf tx_buf;
@ -72,8 +71,7 @@ static int ili9xxx_exit_sleep(const struct device *dev)
static void ili9xxx_hw_reset(const struct device *dev) static void ili9xxx_hw_reset(const struct device *dev)
{ {
const struct ili9xxx_config *config = const struct ili9xxx_config *config = dev->config;
(struct ili9xxx_config *)dev->config;
if (config->reset.port == NULL) { if (config->reset.port == NULL) {
return; return;
@ -115,9 +113,8 @@ static int ili9xxx_write(const struct device *dev, const uint16_t x,
const struct display_buffer_descriptor *desc, const struct display_buffer_descriptor *desc,
const void *buf) const void *buf)
{ {
const struct ili9xxx_config *config = const struct ili9xxx_config *config = dev->config;
(struct ili9xxx_config *)dev->config; struct ili9xxx_data *data = dev->data;
struct ili9xxx_data *data = (struct ili9xxx_data *)dev->data;
int r; int r;
const uint8_t *write_data_start = (const uint8_t *)buf; const uint8_t *write_data_start = (const uint8_t *)buf;
@ -216,7 +213,7 @@ static int
ili9xxx_set_pixel_format(const struct device *dev, ili9xxx_set_pixel_format(const struct device *dev,
const enum display_pixel_format pixel_format) const enum display_pixel_format pixel_format)
{ {
struct ili9xxx_data *data = (struct ili9xxx_data *)dev->data; struct ili9xxx_data *data = dev->data;
int r; int r;
uint8_t tx_data; uint8_t tx_data;
@ -247,7 +244,7 @@ ili9xxx_set_pixel_format(const struct device *dev,
static int ili9xxx_set_orientation(const struct device *dev, static int ili9xxx_set_orientation(const struct device *dev,
const enum display_orientation orientation) const enum display_orientation orientation)
{ {
struct ili9xxx_data *data = (struct ili9xxx_data *)dev->data; struct ili9xxx_data *data = dev->data;
int r; int r;
uint8_t tx_data = ILI9XXX_MADCTL_BGR; uint8_t tx_data = ILI9XXX_MADCTL_BGR;
@ -276,9 +273,8 @@ static int ili9xxx_set_orientation(const struct device *dev,
static void ili9xxx_get_capabilities(const struct device *dev, static void ili9xxx_get_capabilities(const struct device *dev,
struct display_capabilities *capabilities) struct display_capabilities *capabilities)
{ {
struct ili9xxx_data *data = (struct ili9xxx_data *)dev->data; struct ili9xxx_data *data = dev->data;
const struct ili9xxx_config *config = const struct ili9xxx_config *config = dev->config;
(struct ili9xxx_config *)dev->config;
memset(capabilities, 0, sizeof(struct display_capabilities)); memset(capabilities, 0, sizeof(struct display_capabilities));
@ -300,8 +296,7 @@ static void ili9xxx_get_capabilities(const struct device *dev,
static int ili9xxx_configure(const struct device *dev) static int ili9xxx_configure(const struct device *dev)
{ {
const struct ili9xxx_config *config = const struct ili9xxx_config *config = dev->config;
(struct ili9xxx_config *)dev->config;
int r; int r;
enum display_pixel_format pixel_format; enum display_pixel_format pixel_format;
@ -352,8 +347,7 @@ static int ili9xxx_configure(const struct device *dev)
static int ili9xxx_init(const struct device *dev) static int ili9xxx_init(const struct device *dev)
{ {
const struct ili9xxx_config *config = const struct ili9xxx_config *config = dev->config;
(struct ili9xxx_config *)dev->config;
int r; int r;