michaelh/zephyr
1
0
Fork 0
Code Releases Activity

tests: mem_protect/userspace: use kconfig for other stack tests

Browse source 
This uses the newly introduced CONFIG_MEM_DOMAIN_ISOLATED_STACKS
to determine whether to proceed with the tests to access other
threads' stacks. This provides more precise control on when to
run or skip these tests.

Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This commit is contained in:
Daniel Leung 2024-04-25 12:05:52 -07:00 • committed by Anas Nashif
commit 8426a05e0e
1 changed files with 14 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

30
tests/kernel/mem_protect/userspace/src/main.c
View file

@ -553,17 +553,16 @@ ZTEST_USER(userspace, test_read_other_stack)
/* Try to read from another thread's stack. */
unsigned int val;
#if defined(CONFIG_MMU) || defined(CONFIG_MPU)
#if defined(CONFIG_ARCH_MEM_DOMAIN_SYNCHRONOUS_API)
/* With memory domain enabled, all threads within the same domain
* have access to each other threads' stacks, especially with
* CONFIG_ARCH_MEM_DOMAIN_SYNCHRONOUS_API=y (as it is expected
* behavior). The access would not fault which the test expects.
* So skip this test.
#if !defined(CONFIG_MEM_DOMAIN_ISOLATED_STACKS)
/* The minimal requirement to support memory domain permits
* threads of the same memory domain to access each others' stacks.
* Some architectures supports further restricting access which
* can be enabled via a kconfig. So if the kconfig is not enabled,
* skip the test.
*/
ztest_test_skip();
#endif
#endif
k_thread_create(&test_thread, test_stack, STACKSIZE,
uthread_read_body, &val, NULL, NULL,
-1, K_USER | K_INHERIT_PERMS,
@ -583,17 +582,16 @@ ZTEST_USER(userspace, test_write_other_stack)
/* Try to write to another thread's stack. */
unsigned int val;
#if defined(CONFIG_MMU) || defined(CONFIG_MPU)
#if defined(CONFIG_ARCH_MEM_DOMAIN_SYNCHRONOUS_API)
/* With memory domain enabled, all threads within the same domain
* have access to each other threads' stacks, especially with
* CONFIG_ARCH_MEM_DOMAIN_SYNCHRONOUS_API=y (as it is expected
* behavior). The access would not fault which the test expects.
* So skip this test.
#if !defined(CONFIG_MEM_DOMAIN_ISOLATED_STACKS)
/* The minimal requirement to support memory domain permits
* threads of the same memory domain to access each others' stacks.
* Some architectures supports further restricting access which
* can be enabled via a kconfig. So if the kconfig is not enabled,
* skip the test.
*/
ztest_test_skip();
#endif
#endif
k_thread_create(&test_thread, test_stack, STACKSIZE,
uthread_write_body, &val, NULL, NULL,
-1, K_USER | K_INHERIT_PERMS,