michaelh/zephyr
1
0
Fork 0
Code Releases Activity

syscalls: remove policy from handler checks

Browse source 
The various macros to do checks in system call handlers all
implictly would generate a kernel oops if a check failed.
This is undesirable for a few reasons:

* System call handlers that acquire resources in the handler
  have no good recourse for cleanup if a check fails.
* In some cases we may want to propagate a return value back
  to the caller instead of just killing the calling thread,
  even though the base API doesn't do these checks.

These macros now all return a value, if nonzero is returned
the check failed. K_OOPS() now wraps these calls to generate
a kernel oops.

At the moment, the policy for all APIs has not changed. They
still all oops upon a failed check/

The macros now use the Z_ notation for private APIs.

Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
This commit is contained in:
Andrew Boie 2018-05-04 15:57:57 -07:00 • committed by Anas Nashif
commit 8345e5ebf0
31 changed files with 365 additions and 330 deletions
Download patch file Download diff file Expand all files Collapse all files

20
drivers/rtc/rtc_handlers.c
View file

@ -7,32 +7,32 @@
#include <syscall_handler.h>
#include <rtc.h>
_SYSCALL_HANDLER(rtc_read, dev)
Z_SYSCALL_HANDLER(rtc_read, dev)
{
_SYSCALL_DRIVER_RTC(dev, read);
Z_OOPS(Z_SYSCALL_DRIVER_RTC(dev, read));
return _impl_rtc_read((struct device *)dev);
}
_SYSCALL_HANDLER(rtc_enable, dev)
Z_SYSCALL_HANDLER(rtc_enable, dev)
{
_SYSCALL_DRIVER_RTC(dev, enable);
Z_OOPS(Z_SYSCALL_DRIVER_RTC(dev, enable));
return _impl_rtc_enable((struct device *)dev);
}
_SYSCALL_HANDLER(rtc_disable, dev)
Z_SYSCALL_HANDLER(rtc_disable, dev)
{
_SYSCALL_DRIVER_RTC(dev, disable);
Z_OOPS(Z_SYSCALL_DRIVER_RTC(dev, disable));
return _impl_rtc_disable((struct device *)dev);
}
_SYSCALL_HANDLER(rtc_set_alarm, dev, alarm_val)
Z_SYSCALL_HANDLER(rtc_set_alarm, dev, alarm_val)
{
_SYSCALL_DRIVER_RTC(dev, set_alarm);
Z_OOPS(Z_SYSCALL_DRIVER_RTC(dev, set_alarm));
return _impl_rtc_set_alarm((struct device *)dev, alarm_val);
}
_SYSCALL_HANDLER(rtc_get_pending_int, dev)
Z_SYSCALL_HANDLER(rtc_get_pending_int, dev)
{
_SYSCALL_DRIVER_RTC(dev, get_pending_int);
Z_OOPS(Z_SYSCALL_DRIVER_RTC(dev, get_pending_int));
return _impl_rtc_get_pending_int((struct device *)dev);
}