michaelh/zephyr
1
0
Fork 0
Code Releases Activity

shell: use correct data type for atomic variables

Browse source 
The variable needs to be an atomic_t, and in one case it was
being incremented outside of an atomic_inc/atomic_add.

Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
This commit is contained in:
Andrew Boie 2020-02-19 16:59:12 -08:00 • committed by Anas Nashif
commit 831f6d5051
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
include/shell/shell.h
View file

@ -475,7 +475,7 @@ struct shell_transport {
* @brief Shell statistics structure. * @brief Shell statistics structure.
*/ */
struct shell_stats { struct shell_stats {
u32_t log_lost_cnt; /*!< Lost log counter.*/ atomic_t log_lost_cnt; /*!< Lost log counter.*/
}; };
#ifdef CONFIG_SHELL_STATS #ifdef CONFIG_SHELL_STATS

2
subsys/shell/shell_log_backend.c
View file

@ -73,7 +73,7 @@ static void flush_expired_messages(const struct shell *shell)
log_msg_put(msg.msg); log_msg_put(msg.msg);
if (IS_ENABLED(CONFIG_SHELL_STATS)) { if (IS_ENABLED(CONFIG_SHELL_STATS)) {
shell->stats->log_lost_cnt++; atomic_inc(&shell->stats->log_lost_cnt);
} }
} else { } else {
break; break;