michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: can: handlers: verify timing parameter access

Browse source 
Verify read access to the timing and timing_data parameters in
z_vrfy_can_set_timing() and pass a copy of these structs to the
implementation as recommended for Zephyr system calls.

Remove unnecessary typecasts.

Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
This commit is contained in:
Henrik Brix Andersen 2022-04-01 17:47:18 +02:00 • committed by Marti Bolivar
commit 81152d0aae
1 changed files with 11 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

15
drivers/can/can_handlers.c
View file

@ -27,11 +27,18 @@ static inline int z_vrfy_can_set_timing(const struct device *dev,
const struct can_timing *timing,
const struct can_timing *timing_data)
{
Z_OOPS(Z_SYSCALL_DRIVER_CAN(dev, set_timing));
struct can_timing timing_copy;
struct can_timing timing_data_copy;
return z_impl_can_set_timing((const struct device *)dev,
(const struct can_timing *)timing,
(const struct can_timing *)timing_data);
Z_OOPS(Z_SYSCALL_DRIVER_CAN(dev, set_timing));
Z_OOPS(z_user_from_copy(&timing_copy, timing, sizeof(timing_copy)));
if (timing_data != NULL) {
Z_OOPS(z_user_from_copy(&timing_data_copy, timing_data, sizeof(timing_data_copy)));
return z_impl_can_set_timing(dev, &timing_copy, &timing_data_copy);
}
return z_impl_can_set_timing(dev, &timing_copy, NULL);
}
#include <syscalls/can_set_timing_mrsh.c>